From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA02D41D9B; Tue, 28 Feb 2023 10:00:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63DCF40EE4; Tue, 28 Feb 2023 10:00:05 +0100 (CET) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by mails.dpdk.org (Postfix) with ESMTP id CA38E400D5 for ; Mon, 27 Feb 2023 13:51:08 +0100 (CET) Received: by mail-ed1-f49.google.com with SMTP id h16so25244851edz.10 for ; Mon, 27 Feb 2023 04:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Iflh4wEqm8jVP5zx73m5fDhz1u2w500BK1VQNLoZcZE=; b=Nt3vH7E4Sxq3ak8ASH3WIbCI/YavP2LSKj6wX65ako1MC7u/3gscy726UGvUdOLO78 nPMtArP/Bvh6wI34dmN06BYks15djHh23GdoknYFSqxe3OEoYq3V+NeTKzV83eL4R6on du3cfPhRvyLcJ9GJ3+gEWO8zDCLgJ1KIZIpEe31CimmEd7KOrb+SHQF/jJaBoLklzoEn MizI9by3cPM99AT3opMuamaecu6LCXOPOQl4P+/IuaH6rGEN/TRh+eUyqfVWlPaPvQ0A xR0nUo+mtR2KgYaXhKZCFgrw59B5LHVwlPBRxEWfkH9UsVOSswgO9g0vVso7fi/yikw4 M8ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Iflh4wEqm8jVP5zx73m5fDhz1u2w500BK1VQNLoZcZE=; b=6A/qiw7mXgwT6EoOpKZHQ4B3bhpWv8xy/ddvh+ZWsFEgTt2MvT7UOl2QlCJVcHog3n 3dk7+7Cng20jsmUyEBZc/gT3jaL5K+XXZV5wu12mRSZSeQP/E4OB5bBw9Dz5WF5cbn+B Aq0ZjFDbUgZJ6h7lLHvJZXKHxaswHes8gHjvUeGjFnPMgPgOhqJC2YuQN15x3ISnQZN9 Q+y1Ib1fX/cqp3E7W5odrHdUShC3tY4ldxGEEJCBp+PhM6EcO7JPFhIHTT0YgvWKq/GZ y69i92/bwqv7KlbKAbyf8cDZyfHK90Gzu6Ay4j8h6JmRGRwpHxX9ojFheNMqzljJh4v/ k8eQ== X-Gm-Message-State: AO0yUKXyeU5I3iLqgeNa7cokQomy7NgQ6HyapxvnDZuGq/7TSnC7+Kxf V0Lr2cZB1UQt6sSRd7VZ8jSkSBQoWIbTTBqa X-Google-Smtp-Source: AK7set+MX+d4sjVXBVCfa9coSt/Qt9k9iPysQdVpnyx5oP5m0WLwo8nANB7o1I7auM68VtGm8Ys2xg== X-Received: by 2002:a17:906:847a:b0:885:6a2e:f941 with SMTP id hx26-20020a170906847a00b008856a2ef941mr29407550ejc.54.1677502268281; Mon, 27 Feb 2023 04:51:08 -0800 (PST) Received: from ultra (88-103-135-172.rci.o2.cz. [88.103.135.172]) by smtp.gmail.com with ESMTPSA id mr23-20020a170907829700b008e4584e7235sm3164200ejc.47.2023.02.27.04.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 04:51:07 -0800 (PST) Date: Mon, 27 Feb 2023 13:51:07 +0100 From: Vita Batrla To: dev@dpdk.org Subject: rte_cpu_to_le_32 nit in drivers/net/bnxt/bnxt_hwrm.c Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Mailman-Approved-At: Tue, 28 Feb 2023 10:00:04 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi all, I don't know where to report this nit. It's not a real bug and I don't want to even send a patch for it. I'm looking if someone could just fix it in the source code. Here's the problem: drivers/net/bnxt/bnxt_hwrm.c if (enables & HWRM_FUNC_BACKING_STORE_CFG_INPUT_ENABLES_STAT) { ctx_pg = &ctx->stat_mem; req.stat_num_entries = rte_cpu_to_le_16(ctx->stat_max_entries); ^ this line should be rte_cpu_to_le_32, see [1] for reason req.stat_entry_size = rte_cpu_to_le_16(ctx->stat_entry_size); bnxt_hwrm_set_pg_attr(&ctx_pg->ring_mem, &req.stat_pg_size_stat_lvl, &req.stat_page_dir); } I hope that bnxt driver maintainer can pick it from here or please forward this email to him/her. Thanks in advance, Vita [1] Both stat_num_entries and stat_max_entries are defined as uint32_t in header file drivers/net/bnxt/hsi_struct_def_dpdk.h, see: /* Number of Stats. */ uint32_t stat_num_entries; ... /* Maximum number of statistic context entries supported for this function. */ uint32_t stat_max_entries;