From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19BEB41CB0; Thu, 16 Feb 2023 11:37:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6269A42D0B; Thu, 16 Feb 2023 11:37:15 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2130.outbound.protection.outlook.com [40.107.244.130]) by mails.dpdk.org (Postfix) with ESMTP id 58CA140E0F; Thu, 16 Feb 2023 11:37:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oECCnk5XgWEaAORbpJp0B9OEqgae4fgCi/jkrkaAp9KjUwJZhsWU1C0Wq/22PyevgQGgqQRfS9owcwsImtNQsNN8ZB67QbT8adwYyy9PG4RK7rvmwysApJMqi7SwIiuwKdiD4WODL3Vc9VyunTN4A1p2aDH7vUB1pB4s00mTgrnq6OmMZW29cioHRdw01Ckvv9RoEnhO2QuSUNlVJFJgy4di/kPJExjKTzyencFb1RhuzYVIj2+rXE4kl2SLNY+KyUHGM3lsh8H6KxPdT1oJ1exdaMswxjBXanyQZ8TmGi4mGX8ajvny0Zo6cmDKQ0JWCvb6FoseAzBvX9YeYZ01fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QxZhKLKd4LdNtXBkNuJ/7bLD9zowdlQsZ3Y3HK6po90=; b=e9IbkGUU6z22G+ZU7jilIaeSIJXqAzZvLMR0+LYcsOPGFYTfVL++H786CjFmaHCLal7Cr1DMRWZoqYfeG4/hcvd3ReSThCAVFrx+U3uBa7dk2Ke+07qLwZs39NkZVJUeaZJYQClBxWVrcIolyyc3+v0wMxT0GSZDHq2rv5T8ZuErf/6GXVkQUmWGdqkp04LqIF0PSVuza0KnCxkoNrpgmO1wmXr/m67luYO5/fUgI+9bV+v5A5Lj0R/KBkbM9+iJ3cEjS+6sOEzHtQ9KBvHifawlwpbmTrEM3HVDj/Qvpd+MS8tQyXGIJsteUM9gJNu949LWwJDHsp37EVInSvJprQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QxZhKLKd4LdNtXBkNuJ/7bLD9zowdlQsZ3Y3HK6po90=; b=IMI38/5z3f9Jz7kVvokV3ntiYe4Yxhc1ThQs+9mRm8gikNGQNatBGcZ0oYtYYxWy9fkWqZlD0h5EVOr19WlRG4T1uUkO5oV3MQ1pALxDOE78MgE7Ltv7rzbIlT6kU/8TTAp2Lkb66GRKn7+159BRZYPGrIdmYc4rNO8+5JMB+5Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) by BL0PR13MB4403.namprd13.prod.outlook.com (2603:10b6:208:1c4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12; Thu, 16 Feb 2023 10:37:08 +0000 Received: from SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::90b0:f667:bccd:64ba]) by SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::90b0:f667:bccd:64ba%9]) with mapi id 15.20.6086.026; Thu, 16 Feb 2023 10:37:08 +0000 Date: Thu, 16 Feb 2023 11:37:00 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Kevin Traynor Cc: Ferruh Yigit , "Xueming(Steven) Li" , Chaoyong He , dev@dpdk.org, Luca Boccassi , oss-drivers@corigine.com, Peng Zhang , jin.liu@corigine.com, stable@dpdk.org Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk Message-ID: References: <20230208091544.22122-1-chaoyong.he@corigine.com> <1856a555-e7d5-6dfa-6cf0-c4e170b81482@amd.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: GV3P280CA0106.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::21) To SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB6037:EE_|BL0PR13MB4403:EE_ X-MS-Office365-Filtering-Correlation-Id: ed3fcbd5-7829-4d5e-cea3-08db1009c087 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lxCnURJvZ7PxwC/JkA8uGygT3Md4oPhKWYk8Fkz+mkBUfVsBMQcGY37R6CUtRA+uSNTVTmfCZPiZDu2oOlTkfMMpEKdBvaYuEmyAumgTW96ZjY/PVvU+S8LIo6cJdBdo/ZLedaSZ2Vl/Enmd8OXAScy596uOQObxrCms2uP5gz4NoRo71iopfi+fZcNyeyNCxWRNaIt1G/kTF8jdinS9CvYNQ7RM6McGfvTJPzLF1i/8MLWxINoMlxI4ajJU4wNZowa69xJQYHKHkQ0TpnNuJKf8sqYTNg1FpttIVtoDq30b8z7RLsAiVMfvcqS9OqeiZ9SpS/u3r20E3aQadmPQk+p5XkcBcaTw5hfNn/GfQ8gXWg8zlTBeF1+OTB6JAKg0GLNpNMjIgTYQCTNlCnZ0NtKr+jkLlkv+OIjLPJ3g6J8m/A/hAtyXjIsN8+wboFrunfjI0HIxmjh7HGs7PeMWEoiutJKpJkOb2WbF16NlWBRzVLjAy25L/DeA/pd9YeO+646a/vWt24CV5w/qNNIqllkpEenfliKGcsX+GhIkbJ27Mbn8ll2pibnFt3xpyyKKS6UYxqXUY0Fp7QGuP5EZWlIGYI4/QKUt5zcFR4Ycu3P1tRY4UY4dEe2y0MXVBtux5T3DWDnCYqo44mUngYCaOUmEbzkE3I4CzoSQQyMVxZg94uEumj4Xvb1UU1MxID6FxTtP7zeTfHrNY5dNcBMJ+Xps4R67EzNW1jzGkhfGG5M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB6037.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(346002)(366004)(39830400003)(136003)(396003)(451199018)(66476007)(83380400001)(66556008)(8676002)(6916009)(4326008)(66899018)(41300700001)(38100700002)(66946007)(66574015)(8936002)(316002)(54906003)(6486002)(966005)(38350700002)(5660300002)(52116002)(6666004)(86362001)(2906002)(6512007)(26005)(186003)(9686003)(478600001)(53546011)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?yML2S8V4nCSb7jy68e/VBUjOCZo9U9p5B0o2M5Eg6iTCVv04f/PWdk/6AI?= =?iso-8859-1?Q?TIJSC3gYCS12B0Ofd+uQGSHlWp2CZExMgbJgbKcXfj2qMk7Fd95tdVOSso?= =?iso-8859-1?Q?b27fSzcq6a9JfyeGFZJoqAkY0BzbJoIwvcZeosjVTjI3XyK82lo86+XSm/?= =?iso-8859-1?Q?Fk3ua8YbW7uKUG/MzP3tv+4zWPREbHCW1UdIAEVw2edUFEJjRROhOQsygT?= =?iso-8859-1?Q?1AR2qZgaloYDT9OrHscQoFosRWXWUyqpJwnUL9hwd4uMfzAJmehgRylQMd?= =?iso-8859-1?Q?ubNie0Jk5pcFyv1HJfV3Unz7OKNU7PAo5q8VQSiiFOfzO6Nx9U36kZRcc+?= =?iso-8859-1?Q?nwN8B/9LDf8G9Bq6z7EvKARqGlaX7FHFYmZsVzpvBxC7VcNGvOY/PDCn7b?= =?iso-8859-1?Q?MXvGJnfUHoaUksCPz6VoAjPZ+UhE7FfJSoUNAdugwfi43Rq+LXTTE6URvB?= =?iso-8859-1?Q?plon0DKchbAbYbxpQch11vst3JM/rleWVN8jD8Cc2orVMQ0+8W2hg4y6aX?= =?iso-8859-1?Q?CAuYl5CY9dZzTZnFyUsKhlPpAWiAmhYcFlNoKEy894aCmrHTfwVzWbWfz7?= =?iso-8859-1?Q?sAnMLRjvKVEH+YyW2/uzpitsPFDe6wk+RuTHNPg6cChDJav0bQXLY4wOwz?= =?iso-8859-1?Q?31oNsedDwO26topzh6J8hGjaVSIZAkrpsqZfbzOz7Bfvhj1KrVWlP7y1S4?= =?iso-8859-1?Q?FT+9v5s2HBXusqK29o/J1t5dCcSZynr2BeZh3lKwXvL6rErtuOu8eYwUM1?= =?iso-8859-1?Q?gU1MYoFC6NcYZy9fQZDNDOKgdQwC9W00RtpRH8543djVSYcKo/zNAxwaGm?= =?iso-8859-1?Q?izNsXJmAiwDl/gZDxeTcuzP7/SmmmFbnaO9Fq6+yBHO0cAjN2HWwBmq7UZ?= =?iso-8859-1?Q?RXLc2o2+7VpPAn58njdQqrk4v6IE6VvJB4U7P5R/cEO/Bl2GQbLO0B7GPv?= =?iso-8859-1?Q?YlV6gswtacjb2noNj9PNw3a20wPYOG1sIxQ4+qb7sCDUTI6E6E+tgLZUtL?= =?iso-8859-1?Q?I6RpfC7gvQ1JluZ3teTa4cDOM1Hvof+yCBWQ6lpOkdUBOMN2/v76riKr6y?= =?iso-8859-1?Q?PZoBWljvoofaR6Zw54JL3RBFWCjwbg3cnp/6kiNJedX1ucRFpW32/0GCa6?= =?iso-8859-1?Q?LLnWnuBEgrBELTbXCURxJ+akmBpOmrimkO2UJD0YcyzU5m4uW64aTE6VTZ?= =?iso-8859-1?Q?hjBM2C+ZhKJYrUo3VixXGSAJE7dqErHk3KtRaksNyKE4DhNJsEXhj4rpfg?= =?iso-8859-1?Q?L9QSDqtHvM2dt5tDZvNnWj1VMM1Bi4b1v80LY/YiuHIPZzARMiAFTAO/DQ?= =?iso-8859-1?Q?ggLIG74dXTz2nsslUhGjnayZGjMKr4/XiHSKxH/a/XYi3YOqYQp07+ojA6?= =?iso-8859-1?Q?K5I64+wvZ4eSNKT5vCSAKRegQ7lsXdK7QzEQ2RVJDWhtxa8dVwmRc4P3dr?= =?iso-8859-1?Q?y63Qs6MtRb32ssRHn8+60ZZu5kEEC0kXDqKyaB6rLzUDQuE4Ib64qk0pfk?= =?iso-8859-1?Q?aXXbsW+EqE5VYiwHjzdnmRTk0Jl3z+b0pRqc/0rL8WyR7J+gnN0c/zVKl/?= =?iso-8859-1?Q?b4jINKNI61L/Z7ivPPSQqLtRDetpCICC5Nqb9FkhrrVc7SqwIOG744l7tX?= =?iso-8859-1?Q?ZlFBE4fsfoESzir5O/luPIdykRUegp2dcyKFJjxoFmVcOv1bZosgEb+A?= =?iso-8859-1?Q?=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed3fcbd5-7829-4d5e-cea3-08db1009c087 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB6037.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 10:37:07.6120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FjibO2T1jN/5Em93ye4cmqcZf77m79Mt7WiDUNidQNxAme0mVH07V22b107XzESQGBJc951TBysLGxRc6YMdrYgej6Z78wm6mgB+1Gc6Eg4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR13MB4403 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Kevin, Thanks for your input. On 2023-02-16 10:28:34 +0000, Kevin Traynor wrote: > On 15/02/2023 18:28, Ferruh Yigit wrote: > > On 2/15/2023 5:47 PM, Niklas Söderlund wrote: > > > Hi Ferruh, > > > > > > Thanks for your continues effort in dealing with NFP patches. > > > > > > On 2023-02-15 13:42:01 +0000, Ferruh Yigit wrote: > > > > On 2/8/2023 9:15 AM, Chaoyong He wrote: > > > > > From: Peng Zhang > > > > > > > > > > 48-bit DMA address is supported in the firmware with NFDk, so enable > > > > > this feature in PMD now. But the firmware with NFD3 still just > > > > > support 40-bit DMA address. > > > > > > > > > > RX free list descriptor, used by both NFD3 and NFDk, is also modified > > > > > to support 48-bit DMA address. That's OK because the top bits is always > > > > > set to 0 when assigned with 40-bit DMA address. > > > > > > > > > > Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") > > > > > Cc: jin.liu@corigine.com > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > > Why a backport is requested? As far as I understand this is not fixing > > > > anything but extending device capability. Is this a fix? > > > > > > I agree this is a bit of a grey zone. We reasoned this was a fix as we > > > should have done this from the start in the commit that added support > > > for NFDk. Are you OK moving forward with this as a fix or would you > > > prefer we resubmit without the request to backport? > > > > > > > I am not sure, is this change have any potential to change behavior for > > existing users? > > Like if one of your user is using 22.11.1 release, and if this patch > > backported to next LTS version, 22.11.2, will user notice any difference? > > > > > > @Luca, @Kevin, what is your comment as LTS maintainers? > > > > A bit difficult to know. If NFDk is not practicably usable without it, then > it could be considered a fix. If it's just extending to add nice-to-have > functionality then probably it is not a fix. I think we can treat this as a nice-to-have and not something that makes NFDk unusable. As stated above, we marked this as a Fix as we *really* should have done this in the commit which added NFDk support. @Ferruh, would you prefer we send a v2 or will you drop the Fixes and CC tags when/if applying? > > It would need to ensure that it is tested on 22.11 branch and there are no > regressions. It is only relevant to DPDK 22.11 LTS so Cc Xueming who will > ultimately decide. > > A guide below on some things to consider for this type of backport is here: > http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported > > > > > > > > > > Signed-off-by: Peng Zhang > > > > > Reviewed-by: Chaoyong He > > > > > Reviewed-by: Niklas Söderlund > > > > > > > > > > -- Kind Regards, Niklas Söderlund