From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 714BA41CB0; Thu, 16 Feb 2023 11:55:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF33E40EE3; Thu, 16 Feb 2023 11:55:24 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2130.outbound.protection.outlook.com [40.107.237.130]) by mails.dpdk.org (Postfix) with ESMTP id 2DB8740E0F; Thu, 16 Feb 2023 11:55:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLLcGqtUD33mQZefzkW3Ryzl5Otg85IYhUyIEqmNw72ZqyM0hgJSZPOjk1r/oDkIGZw7+T6+lLx4yI798n2NnsvJ14zemJveNtGtgnuiGaFsTqQy6g9LxndfhkHvQavcg19f1YEuP/BS866AClhm/QeiwwtnQljc3KWBgQJA+HvseOPbZ9VhHhv+y1I+Kup2XV37V/lDILDBcDUt0evW5TwiRbcPzHa83PgHSv3MVSsLWt03Ml6ZDGb27l9Ofj94eHWoJTbM/AU2DG41RYb42HQuwMmlKbNpU6z1vYOoklttD6Qj6RNKrIVI9VNaIQ0eK+W7iNWzWyRwrR5NMsQerA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pBN9ZuM1/+QL8Cp+lYqNmuee9XltJfZzXgBtwb25U4I=; b=BvNXhbtFMWp8SKdWpVn3EwAorJhSd5MvF9s/dYwMGPo7MFqDWLTkq7gzKvc2SEfsGCYDp0gUkL55i2/t/eUUXvNawA2n/mE4W3p88FOZGp4WFoyGAticJt9/GESwFjoUtHby7Lb2QFyLkoXdjzyqQcAAnFF2941gLLOOiL7oGrc5H4DTbmVP8TDhqcGDBmvu7vIGeLET2ZnXrvfrjjj1hQ9oYyo4T0PK4yFTTP/SwXZLQymLKt9rHA32S0CtAFjAs09E97NbAbdQqe65RNJGMl+6HMTA6Rv45aPeNb9OxtqPawoKWjNMcAwMx/HQ5mb4qZ0RK31W/tRlKS2Zb47JHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pBN9ZuM1/+QL8Cp+lYqNmuee9XltJfZzXgBtwb25U4I=; b=P5hOUkLPG6Ku7RcCvxOys9Ct0wqm7c91KaPryft6FcB8a/BhwHcPaGM9KjcBrCD43ZOIm+jGV5YOKmOb9mJbmzTSH17Cd4Sbb9cSfRifY3GpbVK+uqDBPSOgsiD3cuMzXIW+qJByDhflmKs9JpoOEglgv486muaLkYz9HekfuM0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) by BN0PR13MB5101.namprd13.prod.outlook.com (2603:10b6:408:148::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 10:55:19 +0000 Received: from SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::90b0:f667:bccd:64ba]) by SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::90b0:f667:bccd:64ba%9]) with mapi id 15.20.6086.026; Thu, 16 Feb 2023 10:55:19 +0000 Date: Thu, 16 Feb 2023 11:55:10 +0100 From: Niklas Soderlund To: Chaoyong He Cc: Kevin Traynor , Ferruh Yigit , "Xueming(Steven) Li" , "dev@dpdk.org" , Luca Boccassi , oss-drivers , Nole Zhang , Kevin Liu , "stable@dpdk.org" Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk Message-ID: References: <20230208091544.22122-1-chaoyong.he@corigine.com> <1856a555-e7d5-6dfa-6cf0-c4e170b81482@amd.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MM0P280CA0020.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:a::15) To SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB6037:EE_|BN0PR13MB5101:EE_ X-MS-Office365-Filtering-Correlation-Id: 353bff2a-c605-4567-a7ba-08db100c4afe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: odi8ldjHJAoOVGGNDxBA681jqZxPKD2Ujq/aQP7QzrJnWhK/n4aATENQ3ejoKOvngihnpTQfZsJjYp2YMWKwnE8yO9yUNN8Czz42FG7c6zYD6Y9RoND0T5JvXQ/4WtKRJUxdWDy5lck2woNLULvgrDpj8h4YjIzpKlmOl9uzDv3kuWNCTfUiyl5yFehmZFijuie2pMV7HA0C6ltG5WJVgyEZuqrYAD/8U8SjNCeb+40FD1EeQarXInyUGX/kr42KOxgiAq9AlDipkmx9vCsahgpzYpBXBBtTvZLenLtYmzMFBRRiguVQ/HGcc90KO+iGCAYroVtIdPUiXdGm62IeIAGQkBPwWUUJrYqFpQfSD6VlfW5hsMuKHAOc54+V5Y0wTNeokMx61Io3HiDPUItYGS9wgPRnLk7YjIG7Cf8lAwMNmnGEJok8pCZAjLOp69W6xsNBbnTQGUaBSDZt1nxoT1JN5bsfCMX+z7TgPvOGtIlDpjABCbMyVWteHwz3Ns6TU4qOuKOB7p355kcBgteST3XFB/9/aYUlMvgSvqeg34hoZvPkVm1E8RsdNL1la0MsB9GWaowG4mhqPzSR3GJ5WiYiQyPlLSMEmJa9GkMSZc6AHmmOnOU/81J6uncIo28g7XKXjPbjJIq5X+jP4hbbpAYht6azQaueESDDrLBqGbuZzipV6t6j04elloVvncnluZ8/YAOqKO8H9hMRQIeTdfq5Tr4Gh6m5+Tgo4+M32B9beiYAo6K0iE3DmaPB7nwg X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB6037.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(346002)(39840400004)(366004)(396003)(136003)(451199018)(44832011)(5660300002)(83380400001)(86362001)(66574015)(52116002)(6486002)(6666004)(478600001)(966005)(53546011)(26005)(9686003)(6506007)(6512007)(186003)(4326008)(66476007)(66556008)(8676002)(66946007)(6862004)(8936002)(6636002)(38100700002)(54906003)(38350700002)(316002)(2906002)(41300700001)(66899018)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?W1ocHgnWBdg2jxvud6C7J4rhDhvmILgj37i5BH9eR/YHu9HPBMXSqRgjz9?= =?iso-8859-1?Q?jG+FE48ONzgVGS9Bck1Yt4ChYaz+6AWPYdMzos9JKlMjbcrQD4ZiFbsL96?= =?iso-8859-1?Q?CQa2vJ7cVdpBc+/bYYmOYaSuphxucm1fnsqD7DZ2XO4YRqINmVXwYMK5DB?= =?iso-8859-1?Q?EZm9a1WTtMslOoPHADuxv3HL0UsA9XCdyyQGULn6pOIP+tGEfUD8eCpNy5?= =?iso-8859-1?Q?HO4RC6FzFr7KqN2PsgH+VZwh+ULO/G5Cjf6xS093MT7yEqZgmOO2XNlpyb?= =?iso-8859-1?Q?0GIbodkQOySPZ7Kj9dDysf7t+aeS5GSuGKT2i5DhOTXFkrn7Zl6rbOmDVr?= =?iso-8859-1?Q?pBBg7Zq8bz/RrOdaAno7jPsoEBLkvL6FV6z5cIaaMbPdVMAfmL01P1s8wf?= =?iso-8859-1?Q?iVBCMMw9IishwVznQvFD+jgLOFlmWp/v5motN/KJ2t1mgd/dgv2mArvuQ5?= =?iso-8859-1?Q?cFIePv15hFp/W67fshqJf7UbIo6mesFw3sxjJs9Ozqi9O93ORddOuNhxeg?= =?iso-8859-1?Q?zJRTixlEA8iJjPq6Zv3bVQdINAzfa2o1Mr/OyTUIUnHmEvuRKWwyFVi1y3?= =?iso-8859-1?Q?19cT9+vU804WgatsLktFzzA8lFpdvYyi7D7R9UgXITHiHTzRBWWXj0OSQb?= =?iso-8859-1?Q?3fCQa/hqwHMzPO5pLgtziOM8zn3kXPQeAknQHr6QxJPeQKye1nHdrHoCmD?= =?iso-8859-1?Q?Qd/wCoGJu9ze7BVxAEMy3+XJRgEyjsW5EWqGIS18Kx43+7esz/xy6TK8h+?= =?iso-8859-1?Q?NFzLkqGhWmqpBf9ZCeF83Hl19R62tzIC1m1FMKBrRBnpj0oxmB9h5AzPbC?= =?iso-8859-1?Q?S+7nmWTbSwX0icmMW0N+3XwH8rTSKnTTYPN6u7RbGoPJVvoiOFHqSbbUrJ?= =?iso-8859-1?Q?ffLa4zjLAhHmRzJmjvwUkP6JqPn+rA8w86vilcXtGiuV9Tl94TrSDCUQGP?= =?iso-8859-1?Q?jsBt41k3wj4w8uyYpwHGBNZlAFVZLVdejI6CXZMPIydaxPadc9it/P45nS?= =?iso-8859-1?Q?Gbet5XGF1ZqF/pwugtPzaCdDlCPaTgg2j8WMwQjmXZb2RgNP9m5eer93XM?= =?iso-8859-1?Q?iLTV84Psn7dMYf3HlXhgXRwht+OS5sH1KUw3tUQaEUP0oFPKDbDozL+pQt?= =?iso-8859-1?Q?2Sboig4x1uX1vGNjlY4IXQ0yZn/10z0VofAOyXXjp2Ov9UJpY0Ty12yMOm?= =?iso-8859-1?Q?JX609duIH1tYRuv+n9AvJH2byXabzTXf4ja4D8JBGwRXa25UJXX2tD+Lo/?= =?iso-8859-1?Q?oV9Md1a3bgrBy1oR5wRnU6zVp8v3HImBPFSaP260PhqWIbMni+QzHjXg9/?= =?iso-8859-1?Q?pTR/fqSFx/uZSKg5ryCDIzpiyChFE80718fnKsCrUeKgeopBLfE3eYIVmg?= =?iso-8859-1?Q?3/QAnmHYP0XBJQt1vVLGIf6rw4vRiHr458yeU2Gp5r4NE/FDvAJkNY8w3K?= =?iso-8859-1?Q?a9ywT2nYH6ObZd9ST/nh5JyZ2rQvNGMI+8IMVejl3g9JVA6dbrg62cRiYv?= =?iso-8859-1?Q?5zkfCI6CZpi2S7vZcBFIHkGmZXhy6agy2wD5Owu8cz15C9LFvgyQ1m65Ao?= =?iso-8859-1?Q?AiyP29wquB7SROrWCoUj4EuE/uP4LBeyTYDmj1HiZoQkVXbakAfZt1lNXc?= =?iso-8859-1?Q?u8FXohgg7VRJ3KdJnHOOdZU6temLOsFe93Ojyc+rJzAcqW03BHePdmIw?= =?iso-8859-1?Q?=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 353bff2a-c605-4567-a7ba-08db100c4afe X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB6037.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 10:55:18.8943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1C4FcZDv4khKbXAsiIcv+CQgoL267uh8a2zsBeb8qDtO+A1+zt44gMrINeFF83qagn7j75e6K77Y1hOuNXYuRt/GUiP2P9oy9ksfu/ByfxQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR13MB5101 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello again, On 2023-02-16 11:41:13 +0100, Chaoyong He wrote: > > > > -----Original Message----- > > From: Niklas Soderlund > > Sent: Thursday, February 16, 2023 6:37 PM > > To: Kevin Traynor > > Cc: Ferruh Yigit ; Xueming(Steven) Li > > ; Chaoyong He ; > > dev@dpdk.org; Luca Boccassi ; oss-drivers > drivers@corigine.com>; Nole Zhang ; Kevin Liu > > ; stable@dpdk.org > > Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with > > NFDk > > > > Hi Kevin, > > > > Thanks for your input. > > > > On 2023-02-16 10:28:34 +0000, Kevin Traynor wrote: > > > On 15/02/2023 18:28, Ferruh Yigit wrote: > > > > On 2/15/2023 5:47 PM, Niklas Söderlund wrote: > > > > > Hi Ferruh, > > > > > > > > > > Thanks for your continues effort in dealing with NFP patches. > > > > > > > > > > On 2023-02-15 13:42:01 +0000, Ferruh Yigit wrote: > > > > > > On 2/8/2023 9:15 AM, Chaoyong He wrote: > > > > > > > From: Peng Zhang > > > > > > > > > > > > > > 48-bit DMA address is supported in the firmware with NFDk, so > > > > > > > enable this feature in PMD now. But the firmware with NFD3 > > > > > > > still just support 40-bit DMA address. > > > > > > > > > > > > > > RX free list descriptor, used by both NFD3 and NFDk, is also > > > > > > > modified to support 48-bit DMA address. That's OK because the > > > > > > > top bits is always set to 0 when assigned with 40-bit DMA address. > > > > > > > > > > > > > > Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") > > > > > > > Cc: jin.liu@corigine.com > > > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > > > > > > > > Why a backport is requested? As far as I understand this is not > > > > > > fixing anything but extending device capability. Is this a fix? > > > > > > > > > > I agree this is a bit of a grey zone. We reasoned this was a fix > > > > > as we should have done this from the start in the commit that > > > > > added support for NFDk. Are you OK moving forward with this as a > > > > > fix or would you prefer we resubmit without the request to backport? > > > > > > > > > > > > > I am not sure, is this change have any potential to change behavior > > > > for existing users? > > > > Like if one of your user is using 22.11.1 release, and if this patch > > > > backported to next LTS version, 22.11.2, will user notice any difference? > > > > > > > > > > > > @Luca, @Kevin, what is your comment as LTS maintainers? > > > > > > > > > > A bit difficult to know. If NFDk is not practicably usable without it, > > > then it could be considered a fix. If it's just extending to add > > > nice-to-have functionality then probably it is not a fix. > > > > I think we can treat this as a nice-to-have and not something that makes > > NFDk unusable. As stated above, we marked this as a Fix as we *really* > > should have done this in the commit which added NFDk support. > > > > @Ferruh, would you prefer we send a v2 or will you drop the Fixes and CC > > tags when/if applying? > > > > Actually, the DPDK app using the nfp card with a firmware of NFDk will coredump without this patch. > And that's the directly reason we consider backport this patch. Wops, you are right I was thinking of a different patch when replying. Sorry about the confusion. Yes this is a bug fix that should be back ported. Thanks Chaoyong for correcting me. > > > > > > > It would need to ensure that it is tested on 22.11 branch and there > > > are no regressions. It is only relevant to DPDK 22.11 LTS so Cc > > > Xueming who will ultimately decide. > > > > > > A guide below on some things to consider for this type of backport is here: > > > http://doc.dpdk.org/guides/contributing/stable.html#what-changes-shoul > > > d-be-backported > > > > > > > > > > > > > > > > Signed-off-by: Peng Zhang > > > > > > > Reviewed-by: Chaoyong He > > > > > > > Reviewed-by: Niklas Söderlund > > > > > > > > > > > > > > > > > > > > > > -- > > Kind Regards, > > Niklas Söderlund -- Kind Regards, Niklas Söderlund