From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 247ACA0584; Wed, 19 Oct 2022 12:53:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B85EF410D1; Wed, 19 Oct 2022 12:53:48 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id B989640E03 for ; Wed, 19 Oct 2022 12:53:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666176826; x=1697712826; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=mG8CjdRflh/dcPG29OjjTsu70vwKJMXXhPY1bTkNokc=; b=Y+tVrcbMFqKD3oxCqz/xtT650a18jijHyaiMaN1OwQk20ka/oI0h/uzK bnqzJyeJUdVlob+MuUr7/V5VmKzry0a2OQsZvZPmj/NKnmnciRyGBV97v p5qqj/j27CZ4scGX4vZ6GTCVltGqFrZvz51Dlo+fEfC/jRVoa6nbNYnuh FCkH2y6uYwbhQpJEXSqJokvZYlz3P+zT0FKfICZYfZ3w23DBU4ZyKQCSu i4Ur2MAMYq+m1DIO8qq188Dxmt61qNbju/z+sjXWBs0bC1GHk0inAlvuR cLJNy+5qboS3wIIYJtzw07mglKvB+BX/GoOR3WH1DkQx8ckI1ubrGR1AS g==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="293771490" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="293771490" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 03:53:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="771722813" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="771722813" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 19 Oct 2022 03:53:45 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 03:53:45 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 03:53:44 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 03:53:44 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 03:53:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n6W4G+uSf9hbMMEefgJNp55PhPmfB3Ywg46C6bBWPgyKsJyk86WsmoiL4JSFKX6RrhHe1zjSO2GdKR81x1eRAvPLTOBDVarGgKMPAcAePjITevoZ2QU+kGVIPN5gVoWT7Og/WnG3x3b4T64cctyD7Wqxk5A+zsma4v3tc2ZW8wFuLOb6N3I/Ro4pLkfwhmQTJdN2tn6PUUttLfpxdxXUorBPgnY1hXfMHq4xXAWLjERVmr1rMc0IcFzwYTs794wzIFjcT1ip5qOdxEII0HyEBsotQj9/jJ7jzmU253w33awKoLrENOVhOdkPewMkombqZ9r4wGy0Wp0AN17UN/RaVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UJVdqEqNAvXE5OzF84SRpVH5kzGRkYcPuDJS77qAXSk=; b=OxIF5Oa5a91ax57TbhUS8dxcJ6VakT13HMLFkP0B9McL8mTf4vK7BoGxfnWXEy1v3u/SerwItwZLQB+tFpawrz/hc3cWhhVAJ+cGOQrY5aK5tFz0Hzjl/f77H8pAfdPdVsicxjK7CmuwBEt0Yarw/LetXUnDgsIqFXKFk459cYqV66ApPYO6huGN0yDPSdnDnLwNtfc6yOO8gUHix2Gul1nnPIvJjHYCei0TSASGOhml3JdIpn1XXpMg9BB64Hdhqfg31tjVBPiHcaAzA3PNuPWG6T65124IW/Vh7tusDsNFFHg2ejnzzvpF2fTOuvGoHyN5EIi9EvSeh4/UxqpAtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by CO6PR11MB5649.namprd11.prod.outlook.com (2603:10b6:5:35b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Wed, 19 Oct 2022 10:53:41 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 10:53:41 +0000 Date: Wed, 19 Oct 2022 11:53:34 +0100 From: Bruce Richardson To: David Marchand CC: , Jerin Jacob , Sunil Kumar Kori , Ciara Power Subject: Re: [PATCH] trace: take live traces via telemetry Message-ID: References: <20221013074928.3062458-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0525.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::8) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|CO6PR11MB5649:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c2627f6-dc97-402b-8ef6-08dab1c02eed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JAwR0DiNRkj4Gc15HwOfDUVHmpceTHXg/1uXWWhJUIL1c6nB9890Sap9KSQ/OzeJdqWEP07bjwSabZk71bH48Rnt8206+9irqVuiW0kkP4CqPVWeWhw1X+FeXBVNsXn/sG1qeQ126Yrwb6543t3xNiKanYa+RJqCZ0Za8IRACuQST1G33ho3/Eqfx1yXcECw3dFs7H5hNGY25408q7ek6X40iCT2axHQL5cw4qKjjb9kkSHuERjq0eW1YClS/UFkUfL/FgOsUeC6ERJ+9I83Jvh7h/dSyR3K7H3B4ReeQhb999lUyZOFz0wZMhxPjDlKsckKmmLVHT9BOkpS/K0x39AZbkg/WhflVI6ZdUA4+U3ebYFKbNtraTej9Npf2GyaD5B2BChHb5cJtCUS3OAu8Ahl9WbK3gX2+xBOfV4Jgics+EWFanKbJP/KI748tUeqFreSgQx8NKIttAKiP9rRPwei+EeVE6DgK6C9wEfm1l2MrTVwfUeWwU3uiZP44c8fu5LtUiATv8RQ9PLPlVouNvvhuggumEEMvR9YA/MAXS2ul1Mof6b+a9qRHGtedEECDVvyzW+ZSYcrkwkrbEkAeC4A4ix7pP24CYqdDaAbu13S6vHQ3QCDDjQTTfm9dwjEhidmpk8VifiD81sKjFmoZmkG4RmjpglAYw8VAaijdhCjRZDVW/2yydoJ8do1pabZDsXlNx/vyPXcoM+S5Q84tg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199015)(6486002)(478600001)(186003)(5660300002)(2906002)(4326008)(66946007)(66556008)(6666004)(107886003)(66476007)(6506007)(54906003)(6512007)(6916009)(26005)(8676002)(82960400001)(41300700001)(316002)(8936002)(38100700002)(44832011)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hwLmu65rIO4hl4y/NEEMj9agGuUWuwfhm34AqkXHc9M2TxoC/rs+o7X7qI+1?= =?us-ascii?Q?PWHFSh1ziW7o1aLgn1ToOUzpqAT48aScR/MGrOXoHM22u1QMs1yqsRdjawPn?= =?us-ascii?Q?FnAZpF1TJjvIOVDcgFJK7yqAeoPKv4K6F0oSypJiRmDn0V1caFfwKWCiCcUN?= =?us-ascii?Q?vRcw+XO/MUOijp6n/masPzCRzmGufMHfW6Gk9sqGI/jDxz8ovLLBd1IoYTOD?= =?us-ascii?Q?tis3VPwB0WGve0LL7CRcR1M93+QUxwfzxacY2cw0dNUOQjscCBtIqj0dUb5k?= =?us-ascii?Q?9aJrYTJiXAQA/pcqLlbp4k2v/wYHJ77vQHkOzbH3e3Es+nzS9RLCaGHVvjlw?= =?us-ascii?Q?8k19x0YEQrWEjY0rXwsDDSzAeRAMX1syc8mj8r4FbSQe9sKU6iR5bqkgCbQf?= =?us-ascii?Q?UEoC3SeY4jHuJVAOzReR9Xpxtc0rDiYLMH96nR0ow9gF1CLf401OEadrif8O?= =?us-ascii?Q?v5ymhxmosd8OS00oa1JoY9b/LNBVoDeDBCVwMPDIjcalSjibnFP7PIW9qjcc?= =?us-ascii?Q?e+WcU79/wFMrBeuZxpN+NMSNxc213SiUZli3TMnbqkHViU3NDJTjXRQBzwCq?= =?us-ascii?Q?dfODzU0CS5jrStDcGXRDu/QVW0eU/295CcJq8W+gGn5jyjpyhtzApUFuRsd9?= =?us-ascii?Q?qsmR+pL320asMeObrCxdQDxA2L/gKNQGWYuydzjKpoEIqVL+4Y5cJ2foLYQ5?= =?us-ascii?Q?Xxh9zWU9oR2oGUv/J+DgqJt8nv6528wliGAyE+60FWiQExm8li6Vc5jy24ZO?= =?us-ascii?Q?K+flY9R+4qW134J9YcZ6oGLFUp2sX/R0HnVfXv7OptogdHb/WBStVY6/q3DH?= =?us-ascii?Q?blQeEK6DvPaVaUNFeYvoF/7AN8lElee8M2vwyIHYXD47C7tk96ceg1j9w+zq?= =?us-ascii?Q?OC3WciZiiQ96o8dcyaOs2beu8xvQDZdvpkikRNDbYujLgf4p8dY343btW81Y?= =?us-ascii?Q?ciqV+d9hNhZT+j02BxAt5GqQ75x31OhmgAYNXuWezMxduGJOu2wXj2feHQww?= =?us-ascii?Q?8h1kVWHlEiD+d3gYTv+b4sTJ8HSuvWlBAFU6hkLnS2vDUB15dejVlSwSnhFw?= =?us-ascii?Q?370TZdsfXXeOUrZ3HW/0y5JpNu8iux0SaEXVwQWftGN1xQdY2nC9ujTLEjhv?= =?us-ascii?Q?ELjZt3vzW48Gf8VjCiSP1oo4u1vqPtCWTh5r+370pgEBMRJDhhq6W/SWk0rJ?= =?us-ascii?Q?P5ZNC7V69KMX8WpsEcZi6emWF5yYbTr/w/3kvoGYDtcyCl6rFDrXgvGAvr55?= =?us-ascii?Q?4N/7nkOM5YtHUgwyb2/e2v7JxncLgvpaNNF6ysTF0HiyZq+2iQw/xwDnTOuP?= =?us-ascii?Q?k44lXAeBfmo1sKwg4pfdI8R/b4N4ZFwJ+4WvaOXUT359rqgCTw/5jDdYr6Xm?= =?us-ascii?Q?XxGWz76onjRgB+2KfDldzJ1FjCMF2X/Z5Q2fQg7lKh+Yu8MxKCtwj9Uvd7YX?= =?us-ascii?Q?d9sGRlruu6HgJPACt9M54uDbTXuZlhe0tPhcWFeccqUGiuXyiq5GGrluThbp?= =?us-ascii?Q?I5ZsiBPb4jQn/146yLLQdMqAzb3TayZu3e/sNvYri2cH2TiLz7P9vE5nW8qt?= =?us-ascii?Q?69sr5lHn5oGpPb0R1rJfKa00RB65IwTv+ntkgDrxXj1ihVeCq1uzYeVkhP1i?= =?us-ascii?Q?Dg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8c2627f6-dc97-402b-8ef6-08dab1c02eed X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 10:53:40.8473 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bXYpNV3QbsKSmeJXs1tu8tiWeFpCWpewI9vVFjuEXcurj+i2bB81QcZOLKqiwzwu+oar5XsJaGpHGpEWdV7gGFAlcifRVjoOcdHMHHwPNIk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5649 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 18, 2022 at 02:14:37PM +0100, Bruce Richardson wrote: > On Thu, Oct 13, 2022 at 09:49:28AM +0200, David Marchand wrote: > > Register telemetry commands to list and configure trace points and later > > save traces for a running DPDK application. > > > > Note: trace point names contain a '.', so the list of valid characters > > used in telemetry commands and dictionary keys has been extended. > > > > diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c > > index 34366ecee3..5b319c18fb 100644 > > --- a/lib/telemetry/telemetry_data.c > > +++ b/lib/telemetry/telemetry_data.c > > @@ -106,6 +106,7 @@ valid_name(const char *name) > > ['a' ... 'z'] = 1, > > ['_'] = 1, > > ['/'] = 1, > > + ['.'] = 1, > > }; > > while (*name != '\0') { > > if ((size_t)*name >= RTE_DIM(allowed) || allowed[(int)*name] == 0) > > I don't see an issue with allowing "." characters in dictionary names, so > for this part: > > Acked-by: Bruce Richardson By way of additional minor follow-up: * I think the addition of "." to the list of allowed characters should be a separate patch, rather than just added as part of this larger patch. If doing a separate commit to add boolean type, this could be a change in that set. * There are a couple of API doxygen comments for the dictionary functions, rte_tel_add_dict_*, where the allowed characters in the name are called out. You probably should add "." to those comments too. Regards, /Bruce