From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D0BCA0560; Tue, 18 Oct 2022 18:20:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8651940395; Tue, 18 Oct 2022 18:20:21 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 0D8964021D for ; Tue, 18 Oct 2022 18:20:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666110020; x=1697646020; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/ZgdiFpuVnpcyNtd6EXxRRcjvcsyQIOOYvxzQkNbqQs=; b=Q28bf6L6+5tfwBum7O3Sz6yFscHfW7PF3rya0Foq47RrhxaJDXWLzvtL OvDRWajEGYtoZYp3en74cmyqSd2NcpPpBJh3C8Qxga7nRCkQ5gYq090ba 8wqpo0XwbtZ1Iq5figaRNjGMaZ4MmxbRtW8R128jAoSOk5/o1UVJCTDmv y3MVNp/nkUpbVnUOK5NA6q+u0vPA7+28RnhhsFRuo72IUsTml+57DW37E bc4ExS/0/jSdFlKtWYy7dRZb5eTGDqvpbCIAO9RDJ8avbqKx1cno0RERg zUjDTz2odB8rhmseHNR1zi8nME3GOoO5w02tWpUw3cRto1qHZ7BuMO4jV w==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="285878176" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="285878176" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 09:20:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="623693068" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="623693068" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 18 Oct 2022 09:20:18 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 09:20:18 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 09:20:17 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 18 Oct 2022 09:20:17 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 18 Oct 2022 09:20:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YcAuQ1mQ3DS02Xx1RI42CISk4u6FLjdKgfJdzc/cfd3RJUPOXxcCW14za696k+EeBZ506HX/MKcpvZwC3sFbyvpSJmJueXdgupNkA40F5mp1O6nIQTYhybU1eiVTYs6HXu7XC3UzaMMvYKG3e5dkCLpye8RJwSbA947PEp9kS4cTKsQXgIG3Hm/MkdRwZk/Zln7Vqv3os1laWotyjoNiXvrOUa4npzm29JsFKfQ3PVwIzYCKgK3yaOClShI5JViF4HCAsMEWYXoHix4F5aGx56o8TkbTIr6cyAn1Ib5Mc2V/az6TW/f50t/S+uU68hotJaQJ/W940MIB1iKh/OIRVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pv66tqCLaRAVcgUz2uzP9/+a1cPZkBD1agbDS1hooJU=; b=IaHpmc0rnu1zrcwOeyhEo9jukeElhlKMrqw7fyGZuW/U3qQp4ZR6J10eEQJZO14q+AWG+k21HMC6g2Dq8VULeDzl6h4LWFsk+5bOnMd+3kW3y+H7oojkIkCa5MGYCkjxBmP8vMd2zarUGZ5L0/iY04Whzdn6IuZ3PE2yJyYvg0RbNSd/bH4Xo4wuYN6J2vgwlOnkpJBQFE8c176Y5yXbCSJCoVCbveqAjKcpTfTlSd4DO4rpVRNvlny1kaspHIQBE/zBR0kNgdcG70F+eKVVW3phvuZA47+uVor/u9BuUaKttFAPiUZDqzE9qDgL0Q0QK3505KyXPNp87V+3xguqag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by CH0PR11MB5362.namprd11.prod.outlook.com (2603:10b6:610:b9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct 2022 16:20:16 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 16:20:15 +0000 Date: Tue, 18 Oct 2022 17:20:09 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: David Marchand , , Jerin Jacob , Sunil Kumar Kori , Ciara Power Subject: Re: [PATCH] trace: take live traces via telemetry Message-ID: References: <20221013074928.3062458-1-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D87411@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87411@smartserver.smartshare.dk> X-ClientProxiedBy: LNXP265CA0057.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::21) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|CH0PR11MB5362:EE_ X-MS-Office365-Filtering-Correlation-Id: 69a4b29e-a1a9-4014-c22c-08dab124a414 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CbpcrE3k0aHzQe6ZSOQwSTAP8TtYHz/VNkForV1X8ivMTn5w0qKZCeOJB0xNOswRBYbC8j2Zlkl8g2+6gGwyXBYdqdxltiW4ZL7YMAxgGA9OKX3gE7cyYX8kJlfuyggd2gaMa4HkOfypmg3P29XVyD9gR9V138aKa/fHL5/qBLOXEJEb4z5f74xW/dHi8Wa7uClmsDQAbKF/CD/DDjcvgsh6ASVTpbMneMbnDrMhPPbBbZXdG1enqEp5556pV0CqEnuuschHgyMJmO4d4nJ+KqaQj1Tz7Sloa5UrROpVDoqA2q0DQSwn2Vev2nyspFcjoAAMPdJIaRV9avx13KlMblt85IJVSlqK3k6/swfLTpJVSK6uezaGJxl+sW3mloPCiU7JUxOjQ2TUJE4qaES9sIAlKrEKvLvaWqfB1Pd41cuM9/t4LMRSRx8hTvy5YImHDGu8g2pBxNBHD3gmQDWilhyGiGZR3PYwUiLPYmH2u196nqEvOa0A+DE7AOwJckpjkrkeUEHo4uh9LRCeKPRWPFYAxoXwC1Yj+eD2Twp+RDv0PNQ9+1pdsQlMyklVI9HFbJhEBkzyWl39pg+jlSoJvug5haYyKpSYedvU7UVWq7jSn3lDpXtJQSA7sUtnY0jdIBTXkfi2zdHsMQFvMX2an2jKT3GHl0caR1eULWi9MT2oyb9ua5KsuO013MFbcMLSWfMFuu4qu98syoxXhrMgnA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199015)(186003)(86362001)(82960400001)(2906002)(5660300002)(8936002)(66476007)(44832011)(41300700001)(66556008)(66946007)(38100700002)(4326008)(8676002)(316002)(6486002)(83380400001)(66574015)(6916009)(54906003)(6666004)(6506007)(107886003)(6512007)(26005)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?tvCh1h2ZPNLyxYNV/yfKnKfGJQ82y9rvcMFJIaxLALAajDmNtG5gGW2gJJ?= =?iso-8859-1?Q?SubUCW/sZsiPUq3sbJP4TGbRfWJtOovtmU7V4dN29RfM2qTsMAUviiwUHy?= =?iso-8859-1?Q?uPbSfUr3cPhI4fYreDJQMjLWtkR+y9/DxpxojTu5TAr4vv7tFJSNv4kBUe?= =?iso-8859-1?Q?yT9JG3huEQ+RhlQ4RDE6Ai6wu6BPo2o0chjEV8L2a0l7PTW3QTTWXOjdM7?= =?iso-8859-1?Q?vS3iFmWKH3Qb9p3XVJvviMFD1aX2g1zETHK8EtAp+n5S6b2+oEbGSl4O0+?= =?iso-8859-1?Q?KCZGW2nWxy3o7oHysKKBhY/VaA7VcmkMNea4RFKXDMmPFkzGJHALBSakm/?= =?iso-8859-1?Q?HT9KgePqWOwk7LTUoopVPg84yXb4Zy58S64IrqLxeHNO2QDxaxqmpGkzUa?= =?iso-8859-1?Q?X+5C6wQPDwaLA/zD12XiNtTDj2nkc3CceytZVMf5/w6K/ssIlz7toAcun+?= =?iso-8859-1?Q?koIirvdFytqtkyI08NR46Ble4B7Rq61FdV/u3eBkkvcMRUwzleQ74R/Dgq?= =?iso-8859-1?Q?ULD15Q2JiBO1xxsS9+iuq5+ahvAmGTIhgdwQnU3qNAkYmS/zNaM4y7Czz9?= =?iso-8859-1?Q?4pwAWjHPGXF+lvxOP21dsxm5fbs5iaajeIwLmq10NgW635rFu/wC6O0VVG?= =?iso-8859-1?Q?QT/pevwWXGlxGQ59UpboZH2IAZby34KvFaSqG7tvO3W2bw/HaTCqHvfr85?= =?iso-8859-1?Q?tkCx34PvqnZutXktXyT7gZUck3zbk33quuK/wmKBnvZDKVmq4oNP8VpiUs?= =?iso-8859-1?Q?sHIb+gh3+DJiQFP15DVsPT+p8qeK8JWj66ryalC0+kC+0AF5HDN2lKfo7I?= =?iso-8859-1?Q?aJCDTHWVHr0e/o6BFgluB3CONHsDe2Rm07wYRhlV2svoS1h8+F8pLBsqgV?= =?iso-8859-1?Q?uci/FiecHjcOZnkw+FdUTRAABwJpbYN0Vcw38LmN/EyOwhJTFLaouOkR6M?= =?iso-8859-1?Q?m/TvGq0k6ocL9ZNAPD/cnZ7TuLaZ7V4AMyFPbwX4Pp4eH5Mldqrq6ML3pj?= =?iso-8859-1?Q?7qwFuxwJd1yDh6kjT2Eburi6iAMCGKfSZBR81FKIEbOs2zOsmSdUCc9zbP?= =?iso-8859-1?Q?6kQhXwNaNH4P15yJkgJZ5wJXm/VB1+EDyFh+cqyNaOUogMEd5woXGy0esB?= =?iso-8859-1?Q?6N0yBRzUwRx9NYupVMKKetRbiYZ+KUZLnQeCjzI763XLcGqaeRpvRwoA+T?= =?iso-8859-1?Q?m0RRtc+nqZCBzMETTOm9pKcLgIrb46T2u7nVnXfE3RYnmNvWqvQ50pGQVN?= =?iso-8859-1?Q?v5aM3RXXb0p69IXK04qEU05NxOAVItct66Sh1n+ZwtBFp5A6dMlMcmTO8N?= =?iso-8859-1?Q?v56dYuaB0NorryS1bbWRSOi7Cw1AEA6KYJkLdfKVXtUPbaOUh8TjaDQ0L6?= =?iso-8859-1?Q?LcytzEGPKZNuwDAPyJSUZNwOof8Oxs4+xqM/8yRjfvCpdO+uOzeBhofYP/?= =?iso-8859-1?Q?ISRs78GX4zDcQygFykSMUGKVNA+GdqlCMJxHCwnZbEIvAJAWPufgSkKKa4?= =?iso-8859-1?Q?A/WIHXsIVo5DZJrHnwaSXPyU1DWgwK+cVQz3EBX/9miJRdP2x7zAXrmq/l?= =?iso-8859-1?Q?xwLfIAjV3O3BBX7Sr9pkjY5YsKyBzkRyfmJsEeEn/ZJHzHX9Z3rVOLrCcP?= =?iso-8859-1?Q?eM2SJbgcAuIqlL0s9la9HeEFogYnSnyaFPQnyX9A0xb1H4lX7gSkRwtg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 69a4b29e-a1a9-4014-c22c-08dab124a414 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 16:20:15.9078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cPCXu8oFYAsMZ4+uhT8u25lFnU6ybtn8YGt2QFgF9U9eSva6oDZK0gtTq8Hf7gnVBTWqUaWIOOdyS3b+HSmfNB8KbD3DiS/3Tf+3oXSeVEg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5362 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 18, 2022 at 04:33:49PM +0200, Morten Brørup wrote: > > From: David Marchand [mailto:david.marchand@redhat.com] > > Sent: Thursday, 13 October 2022 09.49 > > > > Register telemetry commands to list and configure trace points and > > later > > save traces for a running DPDK application. > > > > Note: trace point names contain a '.', so the list of valid characters > > used in telemetry commands and dictionary keys has been extended. > > Regarding '.' in telemetry commands and dictionary keys, I agree with Bruce to allow it. > > > > > Example with testpmd running with two net/null ports (startup command > > from devtools/test-null.sh): > > > > --> /trace/list,lib.ethdev.* > > {"/trace/list": {"lib.ethdev.configure": "Disabled", > > "lib.ethdev.rxq.setup": "Disabled", > > "lib.ethdev.txq.setup": "Disabled", > > "lib.ethdev.start": "Disabled", > > "lib.ethdev.stop": "Disabled", > > "lib.ethdev.close": "Disabled", > > "lib.ethdev.rx.burst": "Disabled", > > "lib.ethdev.tx.burst": "Disabled"}} > > Jerin commented that "Disabled"/"Enabled" are a bit verbose, and suggested shortening them. > > It seems to me that these values are Boolean, and should be true or false (not surrounded by quotation marks), instead of some string representing a Boolean value. Note: This would require expanding the telemetry library with a Boolean type. > > Alternatively, use integer values 0 or 1. > > If we want to represent Boolean values as strings, I vote for "TRUE" and "FALSE", using all upper case to indicate that they are magic strings - and also to help avoid confusion with the JSON true/false Boolean values, which are all lower case. +1 for integer values (at least in the short term). I don't think we want these as strings. /Bruce