From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEDD1A0544; Mon, 10 Oct 2022 10:34:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E297940146; Mon, 10 Oct 2022 10:34:54 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id ED3D640041 for ; Mon, 10 Oct 2022 10:34:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665390893; x=1696926893; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=US351uLF87Grh6Af3GxJqktLgRpwGxUoKb38tz/3Jrs=; b=CWseDEArgHI6SYNXUfxl5h49A9C9sW/VoCP+iHdZJSVGrWXGfJah5AsE Cy7TjqKVtGCUmrqQ6CYessp3soLcu/3dk/1iBkeDc/o2Qp2TsKOVay2k2 ePTK3FPk69X9s8Y0s6UBSuzojQpllCoEBZ9Ilu8DTMDRHqA3gZMvLkPVd HQVDBNGUKK7BFtXQosRqPGVDKbQYZ4vcIliyd+32mERyjW+OQSk8XDVzd Gu+bWpRtzxkarmH1boWSeuwnQKIu17LIreCFb3j+2BnXud+n+2l0EKLq1 bFu5s8SOVkO3rOhhS2BJ2CkwI25oNVRuJrTaPyarLgzWd96i8GlMlPZVU g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="283900337" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="283900337" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 01:34:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="801001782" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="801001782" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 10 Oct 2022 01:34:51 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 01:34:51 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 01:34:51 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 10 Oct 2022 01:34:51 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 10 Oct 2022 01:34:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kBwFReGlalF+iqziHHBHSnG45Y1BWJ9MPqofS55uROauqfs55872XewtfcW9bvHYbtgWwNnxUNm4jq4Q004X9nkynOvo3J/5xnOXcDTQc+MBv1TlBu7o8iVZN4k3WjB7fjDVF1fjxhHSNK/TjeeWekm96930hupfyZ2IoRC5CJdrtHKQJglljXnUwrNsfyT40L1XkNNg+11Tf4+/CAOK+bUbwnJto//yheshCa9vhJ5SoD9IyGRELpyxDPDsfppDt8K/+9CaLhI4SzaBESbUqY0fNuZFZ6LJhwVReTqwpeJ9/ZNyexZIpuWkVg3lRJWuRjGPOhHYfZ7VSXIXDKuhEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OCdF1eRDLmgZ/nCqYCIN0izPWiX4Nxqp9rLH3crJV5A=; b=bceDZOKRdpQ2nNmrNA58awlvNtLEZ1TeOU8oVoJ47kBrzqTRSEg4OXDyMr5Op3lQnwsw4LoNpT+YqnPRvoVG0LRx8QQnsdK4imSUGmD1LM722hzPd91/ofpMWnsPim8aBMmpokysoWThrNn4MzZlkT2IJITp3NGt/rfPslU/0toHBBDyItTBLrPgWzEhiW5n/xa1iBu8olE1+AceUhaCo9d9Y007EN4DdqvV6HitVB/esDhmzmfbY7N41PvRDzR5HifC2G3L/QcKzTHngyP3rZjZcHlQCrju5i1M8tST16QP7hdkIiTphSro2hC9+Dvuv9QFhlrrawV+wF1YSTjNVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM4PR11MB7184.namprd11.prod.outlook.com (2603:10b6:8:110::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.22; Mon, 10 Oct 2022 08:34:48 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 08:34:48 +0000 Date: Mon, 10 Oct 2022 09:34:40 +0100 From: Bruce Richardson To: Omer Yamac CC: , Ferruh Yigit Subject: Re: [PATCH 1/2] drivers: suggestion on meson without version file Message-ID: References: <20221006071923.755507-1-omer.yamac@ceng.metu.edu.tr> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0097.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::13) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DM4PR11MB7184:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e2246af-16f1-489e-bab6-08daaa9a49ac X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Db4gt/y7V6qLs96jiKaetXEpw/B/Y1CXKGWY4hVpKZVE2BAvIMa64HWDoiDH5QnIXSl6TdvueInqupn4Wgjsr7Aj9fpjhckWGX/m8wS0ZUoYurRRQeqRiIwI6DGrcLVCXhDNT8HsAiQR9uadv4pRmC7KZDyk4Q110IahfKswwsIHyazAYqieJaynZ1ZkUmiGnMXAAyJWwpTGsLAtdtvHjSLqlpx7V0YPLMx7gHhAtLzgvSNQ2mzCcIvA4q6LEJHBXLPRuti79K9iuXhBiQjN3XE5/UMePHHrg401wi22i++tTWjMbzLo7wThWV1/7Qw2MEamr941nfCwQ1CX1763f3WSbYSxW3znE54uNcHh/oXtJUyhKnWifDMdkii75x/uaAaedHr2ka3l4AP8uOvOVTy+XhUG3FRMk2jt82Zchap41MR7dYjCOhQ66IQ8bdb2WvSZkEBNaWR/YAhSuwGh+2Pc4eiIt8RuBcXqPg6x6E1qlsx885k5EL3PFiN1yU5vAzOD6zh6vM2m7sKJ1/Jnkn7WnV/6k/WtoXgRHyZ0sfWhN11Zn5f3w4WLMm/A3TF40glS4eDfV3PX2KyWgNGN0pdy51b46ocdk4NztGvVEVtSzV0I2s2FIu86bmq8kMx4TsPY/tMUhtDaqREvXKUW7laZYKVYhtc1J8GN2ygLS4mkxFZeTGph6ebP04Q1DXZzo7aa9+PDWV5teMOdgJLQ5g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(136003)(39860400002)(396003)(346002)(376002)(451199015)(38100700002)(82960400001)(86362001)(44832011)(83380400001)(2906002)(66476007)(4744005)(5660300002)(186003)(6666004)(41300700001)(26005)(6512007)(6506007)(4326008)(66946007)(6486002)(8676002)(66556008)(6916009)(8936002)(478600001)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iGCZfzLBL4YWtzz/GdUMsk3XLTCiBhl7yp1NTyFBsGxMUjp4VZxfbx/yDo+4?= =?us-ascii?Q?ChBA1UtGHtABRpeg1ufq3kGhveIKmg/IrdMgYbRdpYGgV+peFGRwQhySFNqu?= =?us-ascii?Q?SiLPkRdCYDk0DEkKoAikZ0fJ/KGFkGr2bGNyMtQ+Vn1Vz0Huvn0O+c2tAviG?= =?us-ascii?Q?G2PgAFInZ2xwgdRBYYtHoXZmussSvktEWuNOA+0bs3MYSBwZIFP0GbV31etK?= =?us-ascii?Q?6y44pT0WUssNMiSo7cE7zBoBzLle2wrvLqB0SZicpMUricPpKngEEeOOUhLg?= =?us-ascii?Q?UE78Wursji7zoSu5YlHQ5Z1VGKSlzw51l6kbmnEWl3CLXPiJQWIgBy2wly/P?= =?us-ascii?Q?FHdz53xuLrSkXcjqjP6GM6gCe4FiPVsawkv/Ry2pcDZhxEVY6ZQNjkA+wSrn?= =?us-ascii?Q?0LClYROupmVEFuOm7pVehR1ubVB55FZWEbJ3t1ZyKN3nlqY4xAoze5pzYtMU?= =?us-ascii?Q?jXmSyLm4xhXClZySh7GIzpg2LrOEMuAVyoV2Sp3kcAuytCKpc723xQaw8XAu?= =?us-ascii?Q?KKv3WhO0/Wx4zw8RzHL1l1oFoC1uNu1Z6udzjliD61MT908RjjkqhgXsPSt9?= =?us-ascii?Q?2k1eM2kRid0XcUmsedLrWmY6P29dNCQxulJWTFnbw8eOO5OM7NttWHwaIWTQ?= =?us-ascii?Q?k25vJzxppjlLlZLLT2i/OHPeiSDgMh9xZitdvs3UwXN4VircJFzXeB/NmkI2?= =?us-ascii?Q?M+OTAlcWvIVUhfiyzgHhlrggX89jyraMH+mv4W5f4x8G5puEIp/4r/WYD1o/?= =?us-ascii?Q?Q7AjePTY/xMo9CFTNwGF2upCfOVT6uiGCDdc/0IOaStVva2kIh0XYzRtyEmY?= =?us-ascii?Q?N6Wn8BJlHjCx53oa3qDDZ1GkCzIekXxDHOhiRcBQ/rUAVm4D47rjEBWmewIO?= =?us-ascii?Q?6oW6LTc2nXuHQWmP3SA9Du55MRTy5L9doB5JP1FjIEmNwwuabd5y98xoTCa6?= =?us-ascii?Q?uJFHfKa03y7EU8hEokSRp2dIpAfQS35KNNbqSvEM1FiL298nxK8ZJIGXz966?= =?us-ascii?Q?M5yJRYOQtpuPhlE8tJQvsTlSGOgEAvlNvpDQkhmaqWsDCNi5eu58+mJrZnOv?= =?us-ascii?Q?FuUck8vKYBLYwLRqQzMHJ2UhUS5DwZORpwa56P6g4l/AXfkdUHzkli8wn16C?= =?us-ascii?Q?CACqYG2oJWPGudnF56xXwTK5PJGh8FYCXAW7K1El4jtZJSuPjxJL+s1AfF9O?= =?us-ascii?Q?P3ose97Ux6YNPFV4mAHLHwKGo2XbxHe+JGSyh0vWBy1zy52HHohCEYaOafle?= =?us-ascii?Q?bPNg1zO7ZUJHLj/YaGfmUmLYuY/TlAPFFGjLYeNNWLis24WtStkyN+vHRRgW?= =?us-ascii?Q?db26GzYvslZcMHiU7fPr4IKFJVTbk45aAAQKURjwHWUwrkF4uZcMtwtyQsxo?= =?us-ascii?Q?xjL8XWe+Y+iKuVyMB5GqUBK9DT2guqqGQRC89JCYjwwhXeI6Q4rm3H/s+1CN?= =?us-ascii?Q?3PTo/rDAsN/eZ2l14F8o0ARllRKeUL6Y9oiycQYjS/S5oT/R2rz1GsBD0EFr?= =?us-ascii?Q?Qo5FQoLtbe65P8SyOWrCBwMzwNjrZvP7YpQp+gAdnDlBJFgt++4DljsTBRHz?= =?us-ascii?Q?gSnTLl90ywVjI/nGnHViUxKHhjb9apzbyrH+gX5wlu2TJbuZFqgizSwaomLN?= =?us-ascii?Q?Ag=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5e2246af-16f1-489e-bab6-08daaa9a49ac X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 08:34:47.8620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g4VCPvGXApvOUGGLFK1R6V8RcJz7x2OVYbUlpThTRpwVFkiSwvTWG6zGzevZFkdURAvZzbabFQV6wNwjTS7Eh/xuwGsnn8IReXHheGikKc8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7184 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 10, 2022 at 10:41:57AM +0300, Omer Yamac wrote: > > > Beware that the shared_lib calls use both lk_deps and lk_args > > parameters, > > which are only set inside the "if" block you added. > > This will cause problems in that: > > 1. If the first driver doesn't have a version.map file, these variables > > will be undefined and you'll get a build error. > > 2. For any subsequent drivers that don't have a version.map file, the > > old > > values of the variables from the previous driver will be used. > > > You're right, I missed that part and I will add a "else condition" to set > variables as empty. Then everything is OK? Don't add an "else" leg as it will complicate things. Instead, initialize them to empty at the start of the per-driver block, where we initialize the other variables. It doesn't matter having them assigned twice in the one block. Thanks, /Bruce