From: Bruce Richardson <bruce.richardson@intel.com>
To: Markus Theil <markus.theil@tu-ilmenau.de>
Cc: <dev@dpdk.org>, Thorben Roemer <thorben.roemer@secunet.com>
Subject: Re: [PATCH v3 2/2] build: export dpdk_includes for subproject usage.
Date: Thu, 13 Oct 2022 17:38:59 +0100 [thread overview]
Message-ID: <Y0g/I69QP4iC9z+6@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20221013153537.7891-2-markus.theil@tu-ilmenau.de>
On Thu, Oct 13, 2022 at 05:35:39PM +0200, Markus Theil wrote:
> From: Thorben Roemer <thorben.roemer@secunet.com>
>
> In order to perform things like LTO more easily in
> our DPDK applications, we use DPDK as a meson subproject.
> Also export includes in order to be usable in this context.
>
> Signed-off-by: Thorben Roemer <thorben.roemer@secunet.com>
> ---
> drivers/baseband/fpga_5gnr_fec/meson.build | 2 ++
> drivers/dma/dpaa2/meson.build | 2 ++
> drivers/event/dlb2/meson.build | 2 ++
> drivers/mempool/dpaa2/meson.build | 2 ++
> drivers/net/atlantic/meson.build | 2 ++
> drivers/net/bnxt/meson.build | 2 ++
> drivers/net/bonding/meson.build | 2 ++
> drivers/net/cnxk/meson.build | 2 ++
> drivers/net/dpaa/meson.build | 2 ++
> drivers/net/dpaa2/meson.build | 2 ++
> drivers/net/i40e/meson.build | 2 ++
> drivers/net/iavf/meson.build | 2 ++
> drivers/net/ixgbe/meson.build | 2 ++
> drivers/net/memif/meson.build | 2 ++
> drivers/net/mlx5/meson.build | 2 ++
> drivers/net/ring/meson.build | 2 ++
> drivers/net/softnic/meson.build | 2 ++
> drivers/net/vhost/meson.build | 2 ++
> drivers/raw/cnxk_bphy/meson.build | 2 ++
> drivers/raw/cnxk_gpio/meson.build | 2 ++
> drivers/raw/dpaa2_cmdif/meson.build | 2 ++
> drivers/raw/ifpga/meson.build | 2 ++
> drivers/raw/ntb/meson.build | 2 ++
> lib/meson.build | 1 +
> meson.build | 1 +
> 25 files changed, 48 insertions(+)
>
Rather than changing all these meson.build files, I think we should be able
to check in drivers/meson.build if the "headers" array is empty. If not,
then add the include path, otherwise skip it.
/Bruce
next prev parent reply other threads:[~2022-10-13 16:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 14:47 [PATCH 1/2] build: allow to conditionally build apps Markus Theil
2022-10-12 14:47 ` [PATCH 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-12 15:21 ` Bruce Richardson
2022-10-13 15:12 ` Markus Theil
2022-10-12 15:19 ` [PATCH 1/2] build: allow to conditionally build apps Bruce Richardson
2022-10-13 15:11 ` Markus Theil
2022-10-13 16:36 ` Bruce Richardson
2022-10-13 15:31 ` [PATCH v2 " Markus Theil
2022-10-13 15:31 ` [PATCH v2 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-13 15:41 ` Stephen Hemminger
2022-10-13 15:35 ` [PATCH v3 1/2] build: allow to conditionally build apps Markus Theil
2022-10-14 7:51 ` [PATCH v4 " Markus Theil
2022-10-14 7:51 ` [PATCH v4 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-14 8:45 ` Bruce Richardson
2022-10-14 8:44 ` [PATCH v4 1/2] build: allow to conditionally build apps Bruce Richardson
2022-10-28 12:31 ` David Marchand
2022-10-27 13:13 ` David Marchand
2022-10-27 14:22 ` David Marchand
2022-10-28 6:43 ` Markus Theil
2022-10-13 15:35 ` [PATCH v3 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-13 16:38 ` Bruce Richardson [this message]
2022-10-14 7:56 ` Markus Theil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0g/I69QP4iC9z+6@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=markus.theil@tu-ilmenau.de \
--cc=thorben.roemer@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).