From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C399BA00C2; Thu, 13 Oct 2022 18:36:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7460840697; Thu, 13 Oct 2022 18:36:52 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 1E88E40687 for ; Thu, 13 Oct 2022 18:36:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665679010; x=1697215010; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=eP/AfNGBoS/aBlcymBlD+gWxjNmPgB3kPieFrETcREc=; b=RpYPpiqlukJxTfQOVWMBcR73t7sDYiLsJHixT+7vFNJFo5bgnu5lHMKR ZESskO+KPuObe+JucN1HZzfLEHCrmVNozOLOMAPnLi2ILF+6NCMYh0FXp LyL44PYJ97f7Dinhwn5HwWnyISCJrZLw16nNb67Ld2teb/c/Cwnlfckit BICfkSaT3ehMtqodtzVG+PExAPBVtctbi44mUcfZC4wB0DMmhmNdI1kfy elXHHupvfn+dpctob3LTGbSLoh577moLtm7wROhw9CDo2hRP43j8uyJkB 7Yg9cgPyElzTvem4Zro0thGzVF7bReNYn1z8tWh8bdTYAVpvrgW/iIMWZ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="285520071" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="285520071" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 09:36:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="872401302" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="872401302" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 13 Oct 2022 09:36:31 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 09:36:31 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 13 Oct 2022 09:36:31 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 13 Oct 2022 09:36:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SzptMpqZoy9qVSSa0NWtwh4y3fDgLJZ11Ta27cu3X3ZD29SlDgNNgVRy56418K/m5n60578hLjgLuXnH9dTc6WJoJE9D1I2Wy1nmWlGbjAsBX9N/mj0Zl2ICL1T9QbRYtyhk+JOTP+OrgFksbpWc8dswpGPkXBwtyP0YwmLFxzVgdjpkD+7wNZT+OxU6ZGjqCwvKvd9/+Hu8ufvglOoybTtTMdPql+lLFKXgVCHah5Lu1yCo/wWZFcp9aKzLAigLPoPrxS/NJpVKrMYuhjdggO3j2cJgaW1bdOf8PfRsT1+H3b8NKmzQ7iJ2GdclpTWukZC2KERDwemgOjhUJj/a3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HVpGARurJY1cpknRoaBoSgQ9UeZiUz/uKIB618Yi59g=; b=XA/i0JwJkKnIz67slpVXw4KE4rXe6AIssq8VFtC1r1Xh9Q6t9K6Ut/m5QiOrUyjPcQ6VN6TgcJFgiUBIz3do8mrSW0KS16hh2Cs+InyP4Qy0ZvAk4QVswr7i5jdPwnmkO+LxHTEW5xvPjnzcDhbeh5XmL3UUtDvjkGBdb/ghkioUTTqTXffA8G58qB/erKFOpqceTjrq9y8o6zy2HDpLyLIpZsdnXBxLH0RMpPZnZccd/4VT1hdZKxy0njpK2AjQrHbepE5PBNayHhRc3kPXoPG42IHQteEnKD4Q5NLjALrHh4rCi4Wc2HZOjlJz12VIiANNhnZUXD0zxD9jk+oBCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM4PR11MB5325.namprd11.prod.outlook.com (2603:10b6:5:390::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct 2022 16:36:28 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5582:9796:3aaa:aa1%12]) with mapi id 15.20.5709.024; Thu, 13 Oct 2022 16:36:28 +0000 Date: Thu, 13 Oct 2022 17:36:22 +0100 From: Bruce Richardson To: Markus Theil CC: Subject: Re: [PATCH 1/2] build: allow to conditionally build apps Message-ID: References: <20221012144704.77973-1-markus.theil@tu-ilmenau.de> <56efd282-60eb-cfae-78bf-c601c4ea5856@tu-ilmenau.de> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <56efd282-60eb-cfae-78bf-c601c4ea5856@tu-ilmenau.de> X-ClientProxiedBy: LO4P123CA0039.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::8) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DM4PR11MB5325:EE_ X-MS-Office365-Filtering-Correlation-Id: e261ae15-0593-49b7-463e-08daad39138c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lKzZZ3C8JP91mTzu4MN9vFl30zLwXYCHSk98axPdRXyenRaQGlOBPyGk+W2qpCjpa8q7UUPWDSU6Kq0bFWn9OQ9U6o7Gnx6P5xVs1QFp7X2kw8dl5e665QLtxUQDIZk3kyxnYANgBuw5gCXrTXbI1nvasujIrAXeg674wO8+D1bEbOfyFrNGM/K8Pm23N6Z9hCdBoRMSLeLIJqluuFMqUugY0DdKTPj58o18ZEWQw14Vr5Y0wdGbKofxitJrkj9iLvJqI7OmOupjmzk6aMo+G5ARYWfaisK+YBpSst5HJGJoPKUZAveO5uBhCqFWH/ctRvlWE/IdXQ/8RwBp6u4/cjIy+9SO2OGdvEJQ/iX8LinuA/RgVfPxVeSOVKt3g0VhkZKQHlvXhkq9DdtPoyURK4uPSotPxACoER1qpwIfhAFFGryixNzE/hh5kQy5TCFe111T9AloQYwliiMev5DuslNDLEw0byPy1YFAZdFcaB14wvnau4BuXhU2wbCVsSFPnRIYm83zuDcw3Vg3/pPPJicoLl/rRT2cPcDgw/COS8rQyYeyX2eOsEWsLQH/hD0oVIBknNQ//nZgLAC1KP9z2/CkBtKXw+imrHiPDvOkHi80g74xtwgvLhoxbYxaD1yvcr3fY/1kBKw6lEUVGsh+KAG8HgeSUVKETRaY4ILqw8fDbyXagDVkFzJiJ1PTTFJbRXD6jQtsuo/euOGFj8nB3mwo7Ck5YM8ABMCecr14/lxrXcQHdT+qki5ctOdOo8jW X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(136003)(366004)(39860400002)(376002)(451199015)(186003)(83380400001)(86362001)(82960400001)(38100700002)(44832011)(5660300002)(2906002)(4326008)(41300700001)(8936002)(8676002)(6666004)(478600001)(6486002)(53546011)(26005)(6506007)(6512007)(316002)(66476007)(66556008)(6916009)(66946007)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?80o1RSrME/oXRonNYbFJsqPPZy39jt4oNX+d4Ie8jxFr5B6DEOY/XZvuqxVk?= =?us-ascii?Q?KsI1J0X/+dDOGRxMqSNTv1APYlC2dZwsqRrgMVkRtBRjXtTseudYoUtIZdCD?= =?us-ascii?Q?7Q9xX3fKAxtTm7DufKjNi9SZD853XO1U/95BO3WVfYRIyha5rCWKZ2NyAI3q?= =?us-ascii?Q?APG310/0RIMim1Y6cn9CaBXqJKuXu2Ga9EneE0HDXxUmxI9gvAmX+xePheqb?= =?us-ascii?Q?kMpfs0S280rZuTNI2hRPQEgr1jhpc+cC7rS7h9rn4RSg6xM4Wh72+PFOq2Wq?= =?us-ascii?Q?CNgf3W6yt7xN8FSN2LoUVEp0RgQ9iAruyD+6raw3QXUUTBSoMAaX70ZW9YsU?= =?us-ascii?Q?EQHykEoscZRVdRQEq7ct3K//KEhUnDSUeVKalzizH+g41vqV0GNwfHURAgAu?= =?us-ascii?Q?nblinP821WuLZ6HodcSn+gXGivbSJo30lrCFknqcHJ/Zz6AlrN+QYiLFzkjp?= =?us-ascii?Q?Q/ch6vPMdm/OP/r7BQw8rnfzHMSXzH63wlvW8+RXOIpKZbo3sJ6yM9vSb1wY?= =?us-ascii?Q?wbU2pJeJi65UoLlwFjXCvnWF8673CpllryhLyZEkEt9L+rNeG8TIurU3DSrm?= =?us-ascii?Q?gPyskq1Dksqk5e7SyW/gX2AYXr6rWNfSGoQlb7VgXlggK9FLqc+HBS44U9eD?= =?us-ascii?Q?qZKj6EOFJbQjoZbULikfYbJEwwRoBaPc97Zjeynr5Du862poCYl2nzmpeFZR?= =?us-ascii?Q?tS6XCy7kHt8UDYRN8q2DvOOYtdNm55RIyQclRPyL9zfSumFWRpFGS6KpfoCN?= =?us-ascii?Q?vq2XrKor39mwYf6Sk8Nduxd8IQiBRGEJAP6sinw7Z0F46grLpMZPbOoL0b3o?= =?us-ascii?Q?rm9xgfPgMNBOxkmUq8l3LFUbE8R7F50lgNncmuheF1J8Cu/BU+d5Ti7gmcbF?= =?us-ascii?Q?fz6ymPavZwbn0foWsjkEXk9b7njCjW0cA2Cy4FvtvTS7av2nmHLKTGQzoV4m?= =?us-ascii?Q?giS9ssiENII7bhxvs1nqjEyLibuAyeLKD3IephMTeCe3Doz6eya/64rm6hCE?= =?us-ascii?Q?JhzM7mLTyo4H43uP6wWRS6tuDJehZQSLmLSE36VITkIIwJqABds4GTMaRa7w?= =?us-ascii?Q?GO3bX1iJUMTN0fGh6mgqyjq/9nRXB++jKiprXOjn3tAeByhI1KhRxB0BEgnl?= =?us-ascii?Q?yz1IJay/NVOfZdgbXsr0EP9txakruM5DzOoN91xVVHAPc3usKPrknVh33blF?= =?us-ascii?Q?Hy6ai/Fj0CDCxKtBwSHqQj7Fk4eLiD1LxYP/x5Ykqbkl6m5VN1eWyTdopqC0?= =?us-ascii?Q?I1YUNeKQM6i98Kwr1C3e/DQWcfBOc/re5OUpHlly0Q2Hed3TqrIwSvAnxgO1?= =?us-ascii?Q?U4+Y3LDaPP3PjQ7ceYw5DVQ5pg0IlwWcxV/qdF4UgFzZYn9T1vwxIn4Me3Xm?= =?us-ascii?Q?4JAxp0Ks06nsnuGvpM8R6btE0SWysLOc7a25SJJF8g4JvCaCT/TvegH/8D4B?= =?us-ascii?Q?g2zs06Gi6kVH10YIWheTd32U+2SexdHlzEx+FiU0uIpqGGnREtktAjQOb4UU?= =?us-ascii?Q?b/p+ecAWQ9sZyA5ctJbJG7UFTyreBPucCp1bNWVM0bhvH6NOvegHc5Vmaz9+?= =?us-ascii?Q?GpUDlg6DrIX9jTMgRn8qCjslWRraJuFNzuW9HEPHTzfHl+8ruCqr4/ZshC6P?= =?us-ascii?Q?cA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e261ae15-0593-49b7-463e-08daad39138c X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 16:36:28.1391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: abmTjXynhF8pv5RlBFYw7GxnvlJHPhqMYpZGNz7RVb5gZmK6goJObLB5M1QSLl5TC5aFckWaYMAB4FY3iImKRZEP7ynBvrMyFydkJr1GW14= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5325 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 13, 2022 at 05:11:38PM +0200, Markus Theil wrote: > On 10/12/22 17:19, Bruce Richardson wrote: > > On Wed, Oct 12, 2022 at 04:47:03PM +0200, Markus Theil wrote: > > > Makes apps configureable from meson, like already > > > possible for drivers. > > > > > > Signed-off-by: Markus Theil > > > --- > > > app/meson.build | 17 ++++++++++++----- > > > meson_options.txt | 4 ++++ > > > 2 files changed, 16 insertions(+), 5 deletions(-) > > > > > > diff --git a/app/meson.build b/app/meson.build > > > index 93d8c15032..4d9c8ee814 100644 > > > --- a/app/meson.build > > > +++ b/app/meson.build > > > @@ -1,6 +1,9 @@ > > > # SPDX-License-Identifier: BSD-3-Clause > > > # Copyright(c) 2017-2019 Intel Corporation > > > +enabled_apps = get_option('enable_apps') > > > +disabled_apps = get_option('disable_apps') > > > + > > > apps = [ > > > 'dumpcap', > > > 'pdump', > > > @@ -27,7 +30,11 @@ if get_option('default_library') == 'static' and not is_windows > > > endif > > > foreach app:apps > > > - build = true > > > + build = enabled_apps == '' or enabled_apps.contains(app) > > > + # let disabled_apps override enabled_apps > > > + if disabled_apps != '' > > > + build = build and not disabled_apps.contains(app) > > > + endif > > > name = app > > > sources = [] > > > includes = [] > > > @@ -41,6 +48,10 @@ foreach app:apps > > > ext_deps = [] > > > deps = [] > > > + if not build > > > + continue > > > + endif > > > + > > > subdir(name) > > > if build > > > @@ -56,10 +67,6 @@ foreach app:apps > > > endforeach > > > endif > > > - if not build > > > - continue > > > - endif > > > - > > Does this block not still need to be kept? Is it possible that build could > > be set to false in the subdir or other logic? > I will move the block to its old position in the next revision. Thanks for > the hint. Not sure you need to undo the move, you might just need two copies of the check. If an app is explicitly disabled, you may want to skip the "subdir()" call, so having two "if not build" checks would make sense. /Bruce