From: Bruce Richardson <bruce.richardson@intel.com>
To: <luca.boccassi@gmail.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH 2/2] docs: sort files lists in generator scripts
Date: Mon, 14 Nov 2022 14:29:43 +0000 [thread overview]
Message-ID: <Y3JQ12AZXkd86IWK@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20221114142225.85403-2-luca.boccassi@gmail.com>
On Mon, Nov 14, 2022 at 02:22:25PM +0000, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <bluca@debian.org>
>
> In order to build the documentation in a reproducible manner, sort the lists of
> files used as input, since walking the filesystem is not guaranteed to be done
> in a stable order.
> When converting the scripts from shell to python, sorting the input was lost.
>
> Fixes: 53bb9a073f4f ("doc: rewrite shell scripts in Python")
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
Seems reasonable.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2022-11-14 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 14:22 [PATCH 1/2] docs: add +x to " luca.boccassi
2022-11-14 14:22 ` [PATCH 2/2] docs: sort files lists in " luca.boccassi
2022-11-14 14:29 ` Bruce Richardson [this message]
2022-11-22 14:27 ` Thomas Monjalon
2022-11-14 14:30 ` [PATCH 1/2] docs: add +x to " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3JQ12AZXkd86IWK@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=luca.boccassi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).