From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A84FA055A; Mon, 21 Nov 2022 11:31:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC1C840150; Mon, 21 Nov 2022 11:31:52 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id DF1DF4014F for ; Mon, 21 Nov 2022 11:31:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669026711; x=1700562711; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=24UjLta0IYBptuNt99JhSGBEk8hVNS/O54cipT3aA30=; b=NtYvPljcKOu6iq1wZWr+zBEN0tepFfEANGmzxYTZOsUAvheYUxKOLoMj ywS0jeyl+y3LYDizDkmlxTcU2QrQq7v41Os9oD0Gy79upufUYYM314M7A hI01JUFnJIwGD55x+c6/gsKMxKutj6+BAQY8fdFzUNe7jZyDzasDlsThO peAPUsgzbdF3SfYz8IeLpN5BRVUqDi1F+Vy81fv5lXPNtjrexmF1mEdj4 mRkS6vGiKusctXWNGBykkdRtVgwsPvj6HQWeyb7OWREInq6OUuvPH9qz9 9aa1Ji8KdbOd7ere+oV41Yk7dokAQBH5eRi9badYh+vn1scPjyBXZJAJs w==; X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="399814606" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="399814606" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 02:31:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="815668064" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="815668064" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 21 Nov 2022 02:31:49 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 02:31:49 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 21 Nov 2022 02:31:48 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 21 Nov 2022 02:31:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bozOmsQKOOMOGQJjrMEnRoQroHGtFIKOuAZ2K86f3/Qyc5W2ha6ZXgWI7YAf7el5gyi0HKk11TYvx4gY1CJdAB5ESo1c7NuBOltpkSW4Sm0t5FZIq1OvW8W/na/bb8+TYjZEkrOWtqyQeOyUeIB6z9zxemJbLh4Dj4P9QIyrMErd+wQpouXiYbtiktrIsMRvOGSBrPpi1NjgVt+xWWbwC+c051NHjK53jioZc7F+gzJi/v9EtXHh4tWvuC8KFsfHr9N4kr1a28ucuHG5hJP7On1CZr+ALTfhdv/jpd3qsiUeYNaGCmu6FFKZvG/+NRU/NGcgJafkDNZFyoJE3/Z8kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4UGbyJszwvUOA/uDj/1Oz9/CbSgjbCcCHZ3eY/d/1Ys=; b=RTV91A/dfIYtr7e2SDS892Lp1wHnU5Z3nNASOmG+441skSEw/10V9i4gWVOABsNkZHz1NadotMHFOpz0rHCcDDYgKs12Xhjv00vAvEQ3i+taqSq7o5UqiXU6jcO/aZjUXk/syUDORgyTr4l6itXCHeNCRWDVYtl7PvliC4clJKRHjxTXh0zsuU4y6R36TS2JErHaqAr/zba9ygESBGlXQuo+6n0QG7QDAiKlEbxBdnnUm/80rzaKoVdpNtacZ3XwpIhLp+vHC5VoeBQVVaMN5hii1Z9QVzyfTQKfFDtag6+yiQ8gjJmsPsUMofdf8cCD+fTIkB7t9xNSxQXQKTU67Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by PH7PR11MB6953.namprd11.prod.outlook.com (2603:10b6:510:204::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Mon, 21 Nov 2022 10:31:38 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::d136:9b16:f5d7:30e3]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::d136:9b16:f5d7:30e3%3]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 10:31:38 +0000 Date: Mon, 21 Nov 2022 10:31:29 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: Subject: Re: [PATCH] ring: build with global includes Message-ID: References: <1668813728-9940-1-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1668813728-9940-1-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: LO3P123CA0010.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::15) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|PH7PR11MB6953:EE_ X-MS-Office365-Filtering-Correlation-Id: c885abcd-a963-4367-db32-08dacbab917c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +kOQ80VF9cSuGZ9Q9w3ttdVUwPlX0M+kegRNSO1CEQxywGKJgMeAx269cDqysYwCnvoHjkDJ1hYsRphmzmXnRfGpmewW7cI2h7qpQmFKRum3Fx0f4DufJJF42GZ7eSlLvHu8YIMcnAR3DzDFG/Yrlrmpl64BNyTQr0E+W1TFyW0qFU+9Uu2v2nuWeQMIR7K6P7a+FnmF7vqQ6lxgXXLuCUtQobe5tUkDE+uLdWKmNTt7K/EeqHcG00vMBr1jVhSNxrToKrtxo7hRiTGqtj/B6grDgXOp1mays4JPL3ZKTFQ/b10AStIaN6SheOh28z6yq/Tysj+uv+7s6Hm+H9XALvhAeMMXqhb2kjLtD0qQ3ZladUj0gp39fpPs4nHnyoAFmloy62ZRCa7R/2CH7cdJwR5S4a7g0O7bEksNRfbC5J+jfjthPfbR97DQucB+1aaRV3MmVi3STKNXC3hSwhXjo/vlP+Oh2jocCVTH56P/obHbrf9tvAZ485XisLUt+bP7AfU+dzxweFLjMbf84ozUQtjczlkZ4UaO3OpgO5x60fvsls4QweHaPWp+SgZG3MTkHj6fONEiyJXGHwzfSsF3J/1VsBCZ+Peh3Cp5YwyLFYd8QEHntjcGfmvuxQ9MDl8j1Yw1ZoY3ZsHEwv3YvDTKNg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(346002)(376002)(396003)(366004)(451199015)(6506007)(186003)(6512007)(26005)(6666004)(6486002)(2906002)(478600001)(38100700002)(82960400001)(86362001)(8936002)(41300700001)(66946007)(66476007)(66556008)(44832011)(8676002)(4326008)(316002)(6916009)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zHJphICqZCH731RS2x0sZXOdRPANN3cffRf7WfPDqThkvss85LWYY9CTmNsv?= =?us-ascii?Q?Bk73ms+joaOHlwZJE4s1lgayROevnTYqbAE8FzzctLfkZTSF8TXiciBaJ5Ob?= =?us-ascii?Q?NWAJY+zkybbWLYKqQkYn653pFre37sm4hRD7aJ/qa1+zdgKvTri+LeSj/l+b?= =?us-ascii?Q?9xDyBCRGxTXCMnRul+Mhm5cx/8O+zdHEn/Ru5jGdaVebaVWtsHfhm8oSKigq?= =?us-ascii?Q?YK/+S3Y7QkWUDXN6tgpdBFKHZ1b/3l6xihPhxz0E39C4dMvd8Zh7oVZQ0ez2?= =?us-ascii?Q?0jJvPSKM4O+yswRbzoGA/AYy4qu1hndGSUEm6xTrr2HIEVnp1l5dc0iHcuql?= =?us-ascii?Q?C/Qc2E26Ws2b/Jt8D8Ld8rcAun9Dr4iaVWDW25ztnOt2QufnCarsmIYBq2L3?= =?us-ascii?Q?oNF6icHCsWfY1Zpb2tLhV3e4LqseIFrD4w1AwgkGf7oJkdvsxDE9EDciu0IF?= =?us-ascii?Q?+iqzIhorz4zX6EItS3ziw/1FF01q6PaMFIMOdb6DOrcpPiCLrrXt8ZgY6Ti2?= =?us-ascii?Q?fZ383m5Nlm+fHK3HzIPUVd02ttSNxBTqLjr3/ARHlvcoaO/rJKn2+7QiV5kD?= =?us-ascii?Q?JyvIJTiEYoexXLqEYWbHZ7lbmYu/bHwvX5ShABkloF+8OiyAq4gUoT1EWcfJ?= =?us-ascii?Q?mCiNNCNJKtc8tTFiiS2lxLJ+oboOxm8uQ5lA1HInSKqGmcyxj6P+birWpxDs?= =?us-ascii?Q?fqEQWQDucJQsltSYKxUCOaK3RLMQ+IlU7V27ZYPq56ngcv4DfPSMdMEBFfJd?= =?us-ascii?Q?uirgFecHfqeJ4p7LfdK+5ShwIwVVfARuRqt4At5n/MKRv3rlHF5xOQI9mOuQ?= =?us-ascii?Q?cx+SCfUDPIPRgiJzFT2wmTOx9spA3WIhs6u0CNh9odyJxwbJJjRthGIc91wt?= =?us-ascii?Q?UUwKEdA1tjJEL4M71VNVucBOVWPhQXmo1EQsmKL2CRqzEm1HvcmfKVmZ+KWR?= =?us-ascii?Q?pyOScCdqCZEaRdZT0tcBRKmIdglgm0eDieglP74mNsKoALkwf4Sa6oOiqsrj?= =?us-ascii?Q?iKGEz90NoE6uYmhYTA5IeJIweWsEjBfCVzBm4LYA3eNzwxArP4g7Y35BiW7V?= =?us-ascii?Q?soAMfDZKbvdUnbfUdv4hqzk4BA8xV2UBSJAPGT0Zvj+atZYVEkBCB1kYBx3/?= =?us-ascii?Q?N0APbTpLBvnDKjIYwHxLttEr5uer2YinMeFmVRO+m212GG7jaGTs2aBCGO8T?= =?us-ascii?Q?fxGYmgjLiY4WQshZXH4T6CyKdl5Zrgeg3SHkJqh5copyEN37ANE5ICKPe9Hu?= =?us-ascii?Q?qSYsy0MuYx7vMtcu4+UvKdsbSWKfTvuIvT2GrvGMTkyCHMBNJAfUk+MxDqZh?= =?us-ascii?Q?PXAy3HY46BfH1gXL2Kofv20Rtngs2H5391ZxH3xWAKXHDAq7ambfYfkOeOPf?= =?us-ascii?Q?NNsznZZpAl3kEMVKlFRv5KdwK653C0ZrTWubBBWkSSTi287VwA0OrNlxAvtD?= =?us-ascii?Q?oTVu+VHHfOvR87/LqiE3IBhZ0283ftUtLbGfTGJDRfgWB+2i9tkGzkDjh/yH?= =?us-ascii?Q?B+fwNI03pAOtOC1mtrizsx6wrLkWBYcu4oYIQvO9MzUiL2dJFkvXsPRaz9Tl?= =?us-ascii?Q?zlSAGhJarVnMSME3D8UPpip1lajwjKHSKZ+DVzWXkWq7u/fuoFd+llE8wPwe?= =?us-ascii?Q?mw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c885abcd-a963-4367-db32-08dacbab917c X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 10:31:37.8945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wpZhjN60KkLja6ubixJE7tFyMcEeSrpg/vsV2fFduRlGrw33DW2kvF7ta1vlNGxDAUjJl/94rKaap0UZRg4G801kFjwX8IGsQZOcHqvYrqE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6953 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 18, 2022 at 03:22:07PM -0800, Tyler Retzlaff wrote: > ring has no dependencies and should be able to be built standalone but > cannot be since it cannot find rte_config.h. this change directs meson > to include global_inc paths just like is done with other libraries > e.g. telemetry. > > Tyler Retzlaff (1): > ring: build with global includes > > lib/ring/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > I am a little confused by this change - how do you mean built-standalone? The ring library depends upon EAL for memory management, does it not? Also, no DPDK library can be built on its own without the rest of the top-level build infrastructure, which will ensure that the global-include folders are on the include path? In terms of other libs, e.g. telemetry, the only reason those need the global includes added to their include path explicitly is because those are built ahead of EAL. Anything that depends on EAL - including ring - will have the global includes available. Can you explain a little more about the use-case you are looking at here, and how you are attempting to build ring? /Bruce