From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 037BCA057F; Tue, 22 Nov 2022 10:18:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8E2D42D54; Tue, 22 Nov 2022 10:18:09 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 0D567427EB for ; Tue, 22 Nov 2022 10:18:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669108688; x=1700644688; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=m28jzJWYDxQmvRETCnnh3HJFQAv8HzeHUp2rcVmM1eI=; b=T24bsVVedY5WpgDuogC0gaxRQ63T0JZPAsYVIzdnC9I/+yFJyzcGrBBD HXWeq2M1v6jq0utXVHamxk6hELmilzWo3fdKXBZyVOfjU04Q4kO6Ye+py HiwIKp+KZspea4iNMKTzzFb0rOS+28hfby+jQGIz3ZBASCLyyF5cxCs0Y EyU6ESdsmJDP0s5UQfFLV5x3Gbrs0FKsDZ0PNFaTF5N6UrCf1sLLHwnQ1 RNmDlFE6kiu3YkLC+aEODU0nX8gkeLWYDwxJ4r0CFit9+HptDbFzk7TaM l6ipbdhXJTvcoG5ymhu/dTvTQV0BCBbEOqFVH48oxydyQgFmjw2l54u2O Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="315592553" X-IronPort-AV: E=Sophos;i="5.96,183,1665471600"; d="scan'208";a="315592553" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 01:18:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="674287644" X-IronPort-AV: E=Sophos;i="5.96,183,1665471600"; d="scan'208";a="674287644" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 22 Nov 2022 01:18:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 01:18:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 01:18:05 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 22 Nov 2022 01:18:05 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 22 Nov 2022 01:18:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9iSE5tbxQurM0CRtbZ+IE79m/IyVQ0FZWnD+QwmEFmroCJ+FXFPKoDt9e0BpcgKpLhITPOpzP/1M6pux/rPgQ20Vcq2OrB2QkUk1Qy0czXOYzYPW5KYQekpTw8PMKI/whV6fr3mXpx/KKCeO0D/ifBT1fPCMkPGGMX5xXXCgQq4R0MmrIu7dXBMy8EEeJZts2T2ywm+/FxpsSm8Cws+5bZQ06U4nqSYlRF4InEQYEpWC9qr7jfG369F+jXlGRVIsdxRoXD82nrSpidD2AlPl05q+gauWozwTKd2JVBSDJscTzPAuHPposq8p4coTFjG5j2Kp9mNLE26R7Px4ZE/BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lcHIFmy68jZjd5NXRjd6U2QIIbsR1OkbUOO8NO6QkKk=; b=ngz/SKG3R+StICDRDwDP1yNe67fivvBBqW9eUN+jsA56pTSHYZ+OORgKP2ssIgIUUcAi5UHZEpFN2V+oNLE0/nyymIF1OCx9roCzHEA8hHRepgDwioAhPBj99suJ5CQdenYbrZze7WvuXHKGP0s5GdvTU65H0bBBwf9PeMUYY0GmFB7Tac/W4q3s5eXmaUyLG2/WR418k3FY2lenJ1bNlml0V92ew1jRZc7hqYv9gGKzcmazN1nPLyuQlK0ebve92ql4AZAZ8dsdR9KNVfWPV0hig+fwk5kYvOe4Ebm+nQEu7g0C96YNQaZ1/xudJfuH84grYXgZH3lCGxUGziI0qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by MW4PR11MB5798.namprd11.prod.outlook.com (2603:10b6:303:185::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Tue, 22 Nov 2022 09:17:58 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::d136:9b16:f5d7:30e3]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::d136:9b16:f5d7:30e3%3]) with mapi id 15.20.5834.015; Tue, 22 Nov 2022 09:17:58 +0000 Date: Tue, 22 Nov 2022 09:17:50 +0000 From: Bruce Richardson To: David Marchand CC: Tyler Retzlaff , Thomas Monjalon , Konstantin Ananyev , Subject: Re: [PATCH] ring: build with global includes Message-ID: References: <1668813728-9940-1-git-send-email-roretzla@linux.microsoft.com> <20221121195327.GA24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <7452459.EvYhyI6sBW@thomas> <20221121224856.GB24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0018.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::23) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|MW4PR11MB5798:EE_ X-MS-Office365-Filtering-Correlation-Id: 2101ed44-6043-487d-2153-08dacc6a71b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8cFkkxwtMUKFHhgpveelxw5XWxnmw+3f6guYq7c0Y1H0OoyfVPszW2F5HAnNVU+U4+mX2zm3T2cq7QJbjKx3OZPrueODHQldDy6Z/iPyTSltlKKA/oMhPUXHm1PkR2d93YOwHwO/mqUxk6XxuiLpbY4LzloisRcl+uLW6cpPD1d8VvMtjHn26fWv7nbDsa8H93DTKiZMsWbiJaB2QbBORoD6PZrU1d31k0XsfEBBqydt5p2VZ9BSBB05MmoLxMNqn6aq705GQvvI1bhHiiXfOg1ysleB6P2guWmnVtWx04N7UaHkgPE4FRSg8g25ybQlNncb8OSNjQzw0csyqnYZNK1oQKXn78wwCb1KppBX6trpxjmhdH5tbr/iLQsr2J0DdkbILV4Qi3uTCmQfsUhsu9tKord3uUxt3OK8y+2KBySHWqtbV2FnvIZ3LR4GdMY0kcTWsX3VxNH+gt1k/VTSQ0e64kNyfFreySo+2UlLR/flU6CoUf4UPuknLcWYqdT8BwBQULr1mum1gYYy/lCYtw4W83bZnBOkayjO+vsCAv+Zt/ZP2JD2V3rONw/nquvGUyv6nCHqWZfAmoLeTTLsFTRMC7WVvPHrcw0X5KOrMPox4JVG3eCfwk6GbFvpufUdUyQpWVp7LdXV/NQCb7b3WQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(396003)(366004)(376002)(136003)(346002)(451199015)(38100700002)(86362001)(8676002)(8936002)(82960400001)(2906002)(4326008)(41300700001)(5660300002)(66556008)(316002)(44832011)(66476007)(53546011)(26005)(6506007)(6512007)(6666004)(54906003)(66946007)(6916009)(478600001)(186003)(6486002)(66899015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9QhbUCJrdJXS2Gx5CeteI95RmIsQl6JXMDL3Je+UrbAgbO6yoMcF6NkIK/YT?= =?us-ascii?Q?2xuj2aNvfnGGW7lUYW5hNgn88oKIET5pXrErJfeE78U/dL2hxk9G/3Ukx/jo?= =?us-ascii?Q?IKbgehBwEa8Fi6iyQs3AawkwXJLy1tCfAzbeiaDs9ZVxctlKLKe44qUo4GyF?= =?us-ascii?Q?q8R/6SWNLqVJUGNV+Dtj9y66fpLkslnwrjXTxiPFCCJ3ND0yFbbVeDdPFqXs?= =?us-ascii?Q?y/38oal1cfN+ZqliTU/yXatRplWAGH5sQuSEaSjuYvoKLhXnNqkdihVODF7S?= =?us-ascii?Q?nLSFoVtdz+t8OcMe0LKlHj0xEsvaPy5jm4UkhW3n3LD+gYAOfpz1o6uYjsP2?= =?us-ascii?Q?k086bXveF07CrtjcGOKZKaQMk5pVYmWC8ZD8C5FO6mW+LAaOcGtn6ngQYl+B?= =?us-ascii?Q?L457PDB5DjqXvm+xiPWFmsT0T058wd0mYs1JkrxIN5yn+5qskjDwxPRgfTUa?= =?us-ascii?Q?hp/pUJCwcrKGYHSPOrijI1FB6t9406Q2jY4SRfVqoQT5UzGOkisBr5LR1lYZ?= =?us-ascii?Q?T9faT8PZ02Nu/t8Ua5a8J0rSoJpy0aDO0MZc4Few5Y4opY1JRcj2IGU2Oi4P?= =?us-ascii?Q?LwENB1rnqMuS/3TaaikffqyksFVZrYVK3qnuuwM/TxiCYorsYZkTJDxAapqM?= =?us-ascii?Q?4sUN22mBU9iwrH6XB8QUFFTnm7voPUPYvBvQA4Rhz5VSoXYmqIFxmRTP5z5U?= =?us-ascii?Q?t75rmOVtEe27ePhHPNhG7CIgfDju3T2q6ijm7sStdeL2AvY0eUOPynsTZGCA?= =?us-ascii?Q?YC0YkdQ1IjkGkeSV01ZsfBJZ7p1d5rPrRhtvA4FJKsFfprgUzeKTHcOCKpAD?= =?us-ascii?Q?lvuHlo8eaNgPtqn+Ismw4B1nSU0PeRuh7nAhmB0Gx6Ug1tIlUoBF5MVAGhWD?= =?us-ascii?Q?z0seDGOMjSzb2HvI0kWJwlIh+WR7hF4noeohtHqvufdz4J8edcv9+Wewlg6I?= =?us-ascii?Q?5QcU61dGycObuJHfrAraHq+/ZdSj8fVVsAiOEAcknnxcMh4w9cC5oS0Vf8xj?= =?us-ascii?Q?wEjZNOX0wCIps6NAF13b5M5ccmERTPB93ulyl8TuB1+DTWs2O1ZWb9Wv4KWi?= =?us-ascii?Q?tTMUJ/BNdEWJVW0oV0APKp2u51qPpVhp8bAF+2JY81/A8bezietCPCDXcbZc?= =?us-ascii?Q?MF+OwoDFpRaARBg9OiPlo6C8y02w1/xCO7diTfdsxot9RehzESqVYGO5v19T?= =?us-ascii?Q?sGKmJP5cmHwLgkAxP7RP/zRn+TwCG8sqwkWlxy6xVpS2j/POBzYTjiO4pZH8?= =?us-ascii?Q?PtJ3COFwI1uEumx88NYsIPz63d4R2JKdfKoK/h3f6p+oT0g2tUP5ZzEImc9z?= =?us-ascii?Q?gAIDI+A0ALgRQpSdMTIbDpEaG5JUkKwcuiMbGiubbl1R/saFYAPbKQnmGxrl?= =?us-ascii?Q?hmaUu1xob0oDIv6eASva0VDR3luKV2dqp+EOSAycJ8aL1w/9t2lBEf5j5irU?= =?us-ascii?Q?WjhX0I1LuPT6SVr1j5sOVaL2/9lGLFO02olPAWYhS76wfEMUnBVCI79VUC5i?= =?us-ascii?Q?i7hexjYTnwrPNR6dIhIAsg45e8bG7XuII2ZFvHWYikVDqz97aXuslWoAtH1Z?= =?us-ascii?Q?2gdaPfmuFueYtztsnrXjrLLfz5WUZrWfaDfDdPpOVnd+gEwv6YT9nIUT0K1o?= =?us-ascii?Q?fg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2101ed44-6043-487d-2153-08dacc6a71b3 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 09:17:58.6103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pEiQ0sBfy88VQrk5ChHrBfBrtP9JmKqppxO+CzzuCmeqD9D2dIlE5pNWHIeX5snffZJJ64k4jiaSiGSKGo4qc6EbOGso7SEnyDzuCz52JBE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5798 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 22, 2022 at 09:51:53AM +0100, David Marchand wrote: > On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff > wrote: > > > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > > > 21/11/2022 22:27, Konstantin Ananyev: > > > > From: Tyler Retzlaff > > > > > e.g. i don't see. > > > > > > > > > > deps += ['eal'] > > > > > > > > > > is the dependency on eal the library or just eal headers? because if it > > > > > is header only it is equivalent to telemetry i think? > > > > > > > > rte_ring.c uses bunch of EAL functions: > > > > rte_zmalloc, rte_memzone_*, rte_log*, rte_mcfg*, etc. > > > > > > I think deps += ['eal'] is missing in ring meson file. > > > > i guess that's what i'm kind of getting at... if it was there then the > > patch i submitted is not required since depending on eal would drag in > > global_inc. > > It is implicitly added, via lib/meson.build: > > First eal is parsed before a lot of other components: > > libraries = [ > 'kvargs', # eal depends on kvargs > 'telemetry', # basic info querying > 'eal', # everything depends on eal > 'ring', > > Then, there is: > > # eal is standard dependency once built > if dpdk_conf.has('RTE_LIB_EAL') > deps += ['eal'] > endif > > Since every library in DPDK that is built after EAL depends upon EAL, it's added as a standard dependency. However, if we prefer to have more explicit dependencies we can remove that and add it to what every libraries need it. [Ideally, I'd like to have all library meson.build files call out the full list of other libs they use, but I found in the past that it caused the configure time with meson to balloon as it tracked recursive dependencies, leading to entries appearing multiple times and then having to be pruned down. This is why in meson.build files dependency lists have been kept to a minimum up till now] /Bruce