From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 975ECA00C2; Wed, 30 Nov 2022 16:42:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 821F040395; Wed, 30 Nov 2022 16:42:36 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 42BA340151; Wed, 30 Nov 2022 16:42:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669822954; x=1701358954; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=LKgb1INDGdyw4nystail7ieO8B1o3wlOU3fWO3wmzko=; b=ZhXSVfoqdtY9I/Vb5GgehHVwB1jyRFRjBGikXSIr9izAVz7CU8zfbrme jCRqKfH4lidNWEF5RExh/8z2812kGdyK6MhBf7bzgCt7QIjejrBRKKKcv HMQZgM5T8Lhji9rMcHKNInoBbuZZ3yyE6YmT7xCWTlPkW7cn5QQLZsxId +sdmD7rvWJpoL7xyprwSJ2S0LjrJvGEsKJ6kakBbxmtK+lBW1F5bYT6C7 ku+p9ktui2oXSgwcnYp/qiQaAAAZe2FpZOb/mxdZVE3mIHIOAmxWStV1i ah7rN5mdz033aV4oHoFjpjFB7eaqz45LLcBxs2nbf3YOKjHv23/+9J8kM Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="377587340" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="377587340" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 07:42:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="786505719" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="786505719" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 30 Nov 2022 07:42:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 30 Nov 2022 07:42:32 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 30 Nov 2022 07:42:32 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 30 Nov 2022 07:42:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ResZCF8ZWCjxsGn01yvyDHHnMo2qkOiaI2OKzIDuWvSX2aTge5ot32o3QSy+jkhiPt/MwqBBklSWJU+ILFsDx6QokQ01DqPgXV4PBw/bTkriCumrMeazkjXUF+OK0ds7hShqAZI+T1WnXvwgDoZ7xGXQautEmnqsLUmHn5zT2ECxuKxHkpm3+sRIe5JeYjpXsnixTp4kKhCEg+VQjAxJNpUHtLJKzrJp8b550BJ6X22zreaTqGN2XiGZqohACovpP4T9Xn+JjmamWNsAhwsMo8NUz3WXtPDcOwCOr94bPhN3o8BjPykX8QYyWOVI3D5L6lZ/rgtMlCHmZPrvHAP2AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cn0pw+0STR7EOYPlvQUZyNM4jPqeiU3bHCa9ptfFe24=; b=Vt2f/tzUng90L+d/F4uoulwHKr6L/rgrPHiEKflwl/L8g1ypjlQWELc0RfYnDcNOp1aycIN4XUhSq5rMlvKjET1CcBsr/iDfT+LCrJJ2S1HuVlyvlyucRZkpGmZDaIEHXuB7QUQGLRCm8QYE/p1fGHnG684gapFrryitxyYaRHpBSo38uqHgTonDWJ9b0hXS/iBur/qkgi5bLwTqc5g2FJgCuX8PS4EVJmxnrNXf6y1dTRJ6Qp/33Hr8ffFtA5q5who7aAzvvwVgNzLHUMmLUEiCF+q/0OFarNJceCqXHyl2TCMvuGgmHDDMgYEtt6NSAZqELUb8jePmtHdUDl7muQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DS0PR11MB7578.namprd11.prod.outlook.com (2603:10b6:8:141::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 15:42:28 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::18bd:edae:ad31:a228]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::18bd:edae:ad31:a228%3]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 15:42:28 +0000 Date: Wed, 30 Nov 2022 15:42:20 +0000 From: Bruce Richardson To: David Marchand CC: Ferruh Yigit , Luca Boccassi , , , "Thomas Monjalon" , Abdullah =?iso-8859-1?Q?=D6mer_Yama=E7?= Subject: Re: [PATCH v2] drivers: fix symbol exports when map is omitted Message-ID: References: <20221129140032.35940-1-david.marchand@redhat.com> <20221130100204.214181-1-david.marchand@redhat.com> <191d5966-dd66-3a26-2789-6c6e5ce78aa2@amd.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0294.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::11) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DS0PR11MB7578:EE_ X-MS-Office365-Filtering-Correlation-Id: 57f16fc5-d76d-48b6-ceb3-08dad2e97c14 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3EekeSs52dWpfMBQdODzD5oCe52xPtHNl7APipu2nI/lIKFBoNYC//2oHWSzKTloTbeNCl7yfk58dLWFOO+iyUDe/pdni33JWqpbhlO22kiHaPErO7iVmS3DeSUe4a7R0kRPX560Q5iUos3G/wW/l4Wml1LVwxXBJUGJyut6vjiAN3tTMwdNAjh7u8UUoi07broxZaWki8YeC8RFPUa3X4nQxFhFnuboyOx5MNEoAuUXW7cTFYhc7QPQGGHuAtN/dUMTs2OgIUoQ5PSaHGzYy0d6Qrmvwv09UL/w/Sbjfp3TJUSgVRer5+ddL7WDq5Tg9Ap20QFbjBCEnds6Wq+y185XSK6yr1GRIicXgEVqPlcQS7mm1bfnJbcyJKVCKKzm303tE6lHY0lLRLr04d7M+AFrB6S2GEbfbKj1Sm9ab4LByW/17nBKdc7LbYRGbtJpWDBiRIOEU9SAJfC2d+kfP87h6N1/bK7PDIbornViVgRNszK4X32TqF9BByUeLwwzS2UksN7HaeucErwcyBl4j/rt352kL3vZDOc/KfrrFAdVttBo3MmFZoemqjGRhrKjgg9ERubWiV0s1bZi8fg5TVgbd86uYoRtEu3cwn7j/51JAMw32c0VAhn8PAB7pHQXNgwXsZEWqv8DTVh53OdQLw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(366004)(396003)(376002)(346002)(39860400002)(451199015)(316002)(82960400001)(38100700002)(478600001)(54906003)(6486002)(6916009)(44832011)(8936002)(2906002)(186003)(66946007)(6506007)(53546011)(26005)(83380400001)(41300700001)(45080400002)(5660300002)(86362001)(4326008)(8676002)(66556008)(66476007)(6666004)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jr8mg+/Amu7g4iXudCypR9yzoNIU6gVWbw+MYiYDaYIa5x8nNwkFICXj/sGD?= =?us-ascii?Q?mnlH74yBdgKJu0BGza09q6CJnMOsIjYHKXOOmT+T0Rf4eypbsy8aKFsqkijc?= =?us-ascii?Q?pxbd640C+SGPgEeAKRq4oWQULhJ8WvxmyMDir9vAB37fcCOnb+offzeZkso7?= =?us-ascii?Q?J60P4rIBhJwJPgyvkug82vlNssEu8zU1LHQGsX6CaOP/hEkdzhCLbgqnekze?= =?us-ascii?Q?2j+0Cdwi9uZR6PPnSnWzrT6/3us7V/rZlXw0LHeSc5rwxa5w9Tqo8bYn/x7S?= =?us-ascii?Q?lvz5k6cV9uRn5vjmOKIQLiYKOontLz4ZfgcKCaNoyb6ndzzhEfBOcxnnBOAW?= =?us-ascii?Q?MXU2G4WYuLyh7psqaekB1Ghnz5GHJ0A9o5iCmNgGxB3MAqGYGP/utGi3TRLs?= =?us-ascii?Q?qdwwnEv3jXfeZJC6vf7GBaPNS9BB9tRlR4tMrMSxyCZ6wFTdkkHdYeR5EWBg?= =?us-ascii?Q?v6Mvn1Fu81JsA+8O3aZyFETVdEI7FlSReYBkISjuKupYzqceYJC2de1MtabD?= =?us-ascii?Q?2LHWIlOoRp4+SueIAqN8QMK2f5h9xRxXzILSTzo9D0lTD2fWTPU3mMsA9aW6?= =?us-ascii?Q?xz5LGCw4A3MNz563aTvwcnbzqC+tX5+VdfLXgine9ccQffd8QTqAqlprPfX2?= =?us-ascii?Q?NtjAUDw94/M+zcqgxtUHiEZ6Kd1lLC6YJplEBHScI1JGC7Ky2VNzTGkvfWqD?= =?us-ascii?Q?sbdUgJ70mKBe2gw2NPtOhMPLZAD5I+pEcUEchgrr9jTf1fVMQASsPlUqowf4?= =?us-ascii?Q?dSjAefb15f3Z11Jp6wK5oJW/9+HfReS+h3RF2Uq37CeGOJowlrigrCWbiUsw?= =?us-ascii?Q?YVpwRog8FFBKOhpATf0un3gKs3t5hYJpBu/jgXUtJHJPvCJ2tZAEy1V83Fbh?= =?us-ascii?Q?/7ksSTsLgMySHiklBej34r0ot3wa8sPI4xu6EZu0xTg0YLA1IxTFsojpLyeG?= =?us-ascii?Q?TdUECwOYIYP0AIePwEdVN9FYv1M653YWPQGf+YdN/NcrQrhlDqGwGniPiZk6?= =?us-ascii?Q?w/GWwb2QuEszG//4/Xh+BFEymybBcKvIHgDJ0wJ1IsPoo9tTcbL15ITjn1Ct?= =?us-ascii?Q?vXq4fNq4biiLXY7VnRPJbdku5mAqA8tUuq5epW6XKxzoM62ghkhrnsnQyxAq?= =?us-ascii?Q?2GLxKxHh+k8xHRrAUSBlvk6ZVqn/9DRRdEBE4PZGFRFJAz5SRLPApf8I/OrQ?= =?us-ascii?Q?L8zVXM4Pgka8+lzp4eZYzAkWzHLO1LafCWMFd76wbLs9CY6VrVPj82RVAhBd?= =?us-ascii?Q?Zx3bwMKoQrrTT5ayC4na1QNP/Ib77aosjJdvGAbhINQSX9zadZDelZ8u263E?= =?us-ascii?Q?5EBpSK6Z5iTFVfQfEAWFKBgstIr+KZ3pTWr8Do+ddekjMlvUO+WhJrXPFVbY?= =?us-ascii?Q?QNYJY7tmvRFCkie9z6OqhKhnv16Sw/Fqh18qlunxTNSslsUZ3WHRA1U8RBDd?= =?us-ascii?Q?EIZgGZcrow6AYBBkZOhe2YFyhnUpczO4yVpQXjGlk03IBFvkbCymMn6VykVz?= =?us-ascii?Q?kd3KVOUqIMXjDAz+Ctn9TnvEI26wdqRxF7B+gT2EjFjAs7XJZKL1L8gXO8Y6?= =?us-ascii?Q?pBK/R25AtV6vzCQDg6SqhRbA6psjbjviTRS2wSVx0q4tPfba9JFtgsNBQ26x?= =?us-ascii?Q?vQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 57f16fc5-d76d-48b6-ceb3-08dad2e97c14 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 15:42:28.1203 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AmrhmwQzHfbaWOpDlRlCb2zwh292yECbvhVL/xA6FuVeu52AnuJpbU7z6ItZIWtkc2Li1svu5mRPBMVGgQ33ZqzCTwbxgOZKe8KInAw6wtA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7578 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 30, 2022 at 04:02:26PM +0100, David Marchand wrote: > On Wed, Nov 30, 2022 at 11:44 AM Ferruh Yigit wrote: > > > > On 11/30/2022 10:02 AM, David Marchand wrote: > > > ld exports any global symbol by default if no version script is passed. > > > As a consequence, the incriminated change let any public symbol leak > > > out of the driver shared libraries. > > > > > > Hide again those symbols by providing a default map file which > > > unexports any global symbol using a local: * catch-all statement. > > > > > > The checks are skipped for this default map file as it is intentionnally > > > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol > > > maps")) and there is nothing else to check in this map. > > > > > > While at it, move Windows specific objects where needed for better > > > readability. > > > > > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > > > Cc: stable@dpdk.org > > > > > > Reported-by: Luca Boccassi > > > Signed-off-by: David Marchand > > > Tested-by: Ferruh Yigit > > > > Tested v2, looks good. > > 'check-symbol-maps.sh' warning fixed too. > > Thanks Ferruh. > > Bruce / Luca, could you review / confirm it is ok for you? > LGTM, thanks. /Bruce