From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4298A0543; Thu, 15 Dec 2022 10:41:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1AF440684; Thu, 15 Dec 2022 10:41:49 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 3968340223 for ; Thu, 15 Dec 2022 10:41:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671097308; x=1702633308; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=h5s6sv1a31zyJeVhoJfdEK2qOgWZ2EVyA1MkIPieQbQ=; b=VlQ/dGAe8JLiI+O+hmHtbRrAjsoAy0ydxdRxFlqnXK/9QdP8sSo0npv/ GxgTkjtpuscl0WEpb9SXNUih/4PnOBvl+/lsXs6dTZbqVzarq3prHdU50 yRayYLWa2MbQ0SQ2G1EdR+ni4m62oP6WRjd8AO0fwEzU7C/3palLSdI/L 6XGjv2oZJvvkYQMhoBLCS7+vJcQLXoMChlfdvMZGiVMZXGNKvwNECH3nC fn/heU4X+cG5kw8zwG9UOZmyowU4tDnMwzEFUkwHdxXH1NnuO3pbPlUg9 hH41PkWpb8VL5ma+ndBc0GEOy/MirXvhGavxVuKF27X+N28zlXD0N7tM4 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="298979993" X-IronPort-AV: E=Sophos;i="5.96,247,1665471600"; d="scan'208";a="298979993" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2022 01:41:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="681789477" X-IronPort-AV: E=Sophos;i="5.96,247,1665471600"; d="scan'208";a="681789477" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 15 Dec 2022 01:41:46 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 15 Dec 2022 01:41:46 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 15 Dec 2022 01:41:46 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 15 Dec 2022 01:41:46 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 15 Dec 2022 01:41:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WXw1G/iGASwCHALHCH80Ac3nKjMN+FYRzq/ArfISqxFuezn080gsm0oPknPrZllNqJj2/F3o1DyFLHm8dixnW7xDpXrEhFIaRfKQPNxlp4IK47ZTZOTGXbxyFkfcpkjunv9XFauP2Cc3SENRYDGsLPC7PCHULuj0HdplFFDXl4/ua79HyuAfem3I3NvRkN926J9HCwgbAftDLHXpcyZi2CA4DKnND1i4v+VcncFU7/bsi7UQ+KGRfRh8LQgJ0ZY5FvZ6D5Ck6itZ7PGm06gRqOXM2qR9gjqJnxX5ywXYaf5hdcaYcI1quAsx9FNxwUqSLZsHyXYgsFHs53tcWnZywQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZF+lZV+lKPX7aPDz/ZrwrOEsj59mLrElt8e82KyZSso=; b=SCPbl3KeiTNdC9zX+oKP+DIN45+7GS1Gll2PmKA0wz6YoiulKqsriRmbbzZvvlP24QR7BX9NWSfNLDfe5iUmXmN18kNYZLr8rDA0XRmt23V0laymqtZaXwTllrAb/pq592+PMzJtnOrNJsCSBSyA1T7U+4MiydD5UJ90C4w9MOvMZwftjRtkQADSTJds5/5Qp0xwoRZH8VGW9nvU6YCAzk1EZmielCoi2k8nb8WqHezZir5oPKndfxdxocv62EKy85DAdcLaYKSuSLmoTeyEWW7cIPxTb9jsihwDYt08PaxY7kpaoGVUWlI8sIp8+iAu5W6CjJHmSjy8GKj+BNEe5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by SA0PR11MB4544.namprd11.prod.outlook.com (2603:10b6:806:92::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Thu, 15 Dec 2022 09:41:44 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::18bd:edae:ad31:a228]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::18bd:edae:ad31:a228%3]) with mapi id 15.20.5924.011; Thu, 15 Dec 2022 09:41:44 +0000 Date: Thu, 15 Dec 2022 09:41:38 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: , Morten =?iso-8859-1?Q?Br=F8rup?= Subject: Re: [RFC PATCH 1/7] telemetry: rename unsigned 64-bit enum value to uint Message-ID: References: <20221213182730.97065-1-bruce.richardson@intel.com> <20221213182730.97065-2-bruce.richardson@intel.com> <20221214173005.GB31935@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221214173005.GB31935@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-ClientProxiedBy: LO2P265CA0033.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::21) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|SA0PR11MB4544:EE_ X-MS-Office365-Filtering-Correlation-Id: 1572f954-2945-494f-220e-08dade80938c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BhopTqultlFUE1NR2n4mVPwx8yrVsWvNEBhl7ssUh2ZH0nskPf13dhbdY1rV4sPVxdkzX79B3vjX91Z5Uhew4D4iFsQLS40grsKeczYjiirMSUsQxDh575h2J8TZoyfLKb1nsT9fSTZUOCiJwwjela1nKSG/biorDCTvqi4EU+QoLLTBl5Rfv2Yw6iwcn/bIrOLsJnerQxQ3ufUb/YDrLF3BtzShtYyUEPS998j4CYB6y6irrxifUx8/9cddTaMzKC8/PEmBFyH+qhBqyXt5BZq1kf4KkNxcj3P8p4akKXs0ykDEq7l3gsx+5wQFWfnol5ZkLzqNKeh5sJbpi2GVY0BCzlfevePUetG7BQ3lyjZr/hTwX3Er4wMLl8uXtYfjO4snYZFe+PUvsnXaXHI1K1gWc1QXFivbqueRAMOO3lDX8BHX2I1qtXfGpUOPUWot+xXqZGkTnBptaxbJYoMefJRHmZEEgYrjQ2Tekf0uAsyl6bmk09oxlwun3TplB9D3hd/O3W3P9Dt1rU3zmO1YGQYBfdKlhEe9ixxN0Y7ARVj2mgyCvMIV+rQT63bFpAVRqj1F9BYG7V5cKClgvDyFTjHvqIXA/aNInsttC32ybYrPPDkkaiEpxFFJbyvdub/87vQc2JuWoVEIiM8y+EdS9A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(396003)(376002)(366004)(346002)(136003)(451199015)(26005)(66556008)(41300700001)(4326008)(8676002)(8936002)(66476007)(316002)(6916009)(66946007)(82960400001)(38100700002)(6666004)(478600001)(5660300002)(6506007)(6486002)(186003)(6512007)(44832011)(86362001)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?DJ/zeXP/wFzxC4wxQ15PFRtmwTQNgIYKcpoLDZh69nMr9E6sFvY2GhAjEu?= =?iso-8859-1?Q?LpnU2C4tuPi9fvHUGUxWp9J4PfWeVwqfEBZFBGpClKlr5MBgRoIbu0BCmi?= =?iso-8859-1?Q?H2IAemyNhc0Go8gMTaBQ7+nNXwwkd95gW1wf5tt7X2szsPUOutVkGigLRF?= =?iso-8859-1?Q?bzCDWV9qPJs30L3nUwKGUmIja+BrM4h7Hni6LAHjZD9JbkGurf6G1z9kGN?= =?iso-8859-1?Q?D8ADvUkzCaERdNv1XWaaPgxySBfOEb5biXQElJPeHSJ1uEK7/ZeG2kELBE?= =?iso-8859-1?Q?BK2EqV6hQdsQi6rQPTaxuzrQ6aa2wZmM/Rp93hh5lLBlbVLwKRJVipPANI?= =?iso-8859-1?Q?CIfhavhfE/BeSCLFjD2OTgf2ya694nIWc1geU66QMiRZwQXjGUxiglh7qA?= =?iso-8859-1?Q?l9wEyyEehGwj5x+XqKmGVrBVycAEJrfSqlYlY625cPXWIDIbcKv8wKpFn4?= =?iso-8859-1?Q?UOsxqS+GxtiTlFVl4SES1lu1fnkDN8p0ew6wOEa1KVLn1RD03ghWfdNLce?= =?iso-8859-1?Q?Q3UDnTvWJxgQZyDORmoaofXAel6iKVTk6TfBzeigAzor8/vvhr0Idiwb8R?= =?iso-8859-1?Q?6UEVmkWo5K3T0VyQ0FuvYciTVYgBdwwxYzl3RdXPEWDPF0nRLc24qf/SoE?= =?iso-8859-1?Q?OSG4wIoWlpJgHVDItmPKnz0i9sbGeCshTUIz80vQAzRlBF0lxyv5eU2ww4?= =?iso-8859-1?Q?mvyyjMfp/8YzzmUUhsJFADw6lvaddarkUgzRwgHCyYyN+yUnx65oZ5FQB9?= =?iso-8859-1?Q?pos1Q3g6Me4sMpytj3oNTFUct1KvAeBM/GwwZt680sanZGD9FvB6zRNEvb?= =?iso-8859-1?Q?8d7GrDt2h89UnMOrBf0EDUjJpCT0WH6ncHWDEVPerf9t5tRcEEQM5WHBsf?= =?iso-8859-1?Q?GrcP6qv3EOPD1FNOxVwts+eAGry51Qr62GFLSUm8bA08PIcEpy+CEJZ4dS?= =?iso-8859-1?Q?IPC7lA5ogq5VMNpT88CKWpbBptMkb/4hpUzrlGCv4PX4VEVLL1aYiP3y8D?= =?iso-8859-1?Q?/8c/DOSJgnoBvYwFIoNnAzZiY97u2BwX06SfteWmOgR9nYppEYbcn/e9ME?= =?iso-8859-1?Q?AtJMtuVKnlB7BkjCEwTrPJ173pgVbAQLxVzyKE4HP3tXQtahTYjF4/GAJx?= =?iso-8859-1?Q?bGHfS8OS8DpxYzpBeE/rc2KIJIiXU/v5dx7+80TFud2BsZI2fzZ3AV6kD1?= =?iso-8859-1?Q?FS9ofu8C1YoUoiyiKint2nkg8b/PZH7JxRDA4cnPRS260uBL9lG94ebdDH?= =?iso-8859-1?Q?tW+Zj/ShTTqYc79IovsMlYEU2mnU5L228mqRk13FFzQ1VCcQ1p5dOkFhvG?= =?iso-8859-1?Q?tM93cf4fYIh4CLMGpf095hesa7PktD/mYFBRZOhhvUhPoDJ/89HwJc0SDL?= =?iso-8859-1?Q?cLUyPaeFRd8jkh+KXGabp8jZFLrf+EjsKEPkHrMl85jaPgiiA9CAcZZJiF?= =?iso-8859-1?Q?oKNzcqu7iMRNLELSJQ1z+FPWVJFBD+whoPP983NJFYSB5U0CpSiOR6jBYo?= =?iso-8859-1?Q?pz/4oNi84JQrVXQjINOiVNEvW+Tk/Q0EqMfS/9S2rPjI5xjL7ugIZ+wiXP?= =?iso-8859-1?Q?/bN4bc+tod/RBn+FJ2s/Mp7TE5ElGupuAogVfNFQx61THGVcJpxqg5TdNB?= =?iso-8859-1?Q?AqxMYwpoSxyqKFaAWa1H7zn2fpw4SQ3xBpVpWPYHvd8RHdezdTtibbPA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1572f954-2945-494f-220e-08dade80938c X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 09:41:44.1460 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r1ZOP5IA6on6wj2u7hojqXqAqFURFDxvYkFHONhB8BnZcGGhGqX5mIQGYMt/vCFk4QfP1NyAFdz44LShRS3mCWtVFiuytPBEyKRTPMQa6JE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4544 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 14, 2022 at 09:30:05AM -0800, Tyler Retzlaff wrote: > On Tue, Dec 13, 2022 at 06:27:24PM +0000, Bruce Richardson wrote: > > For telemetry data, rather than having unsigned 64-bit values and signed > > 32-bit values, we want to just have unsigned and signed values, each > > stored with the max bit-width i.e. 64-bits. To that end, we rename the > > U64 enum entry to "UINT" to have a more generic name > > > > For backward API-level compatibility, we can use a macro to alias the > > old name to the new. > > > > Suggested-by: Morten Brørup > > Signed-off-by: Bruce Richardson > > --- > > diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c > > index 34366ecee3..3c996484ec 100644 > > --- a/lib/telemetry/telemetry_data.c > > +++ b/lib/telemetry/telemetry_data.c > > @@ -18,7 +18,7 @@ rte_tel_data_start_array(struct rte_tel_data *d, enum rte_tel_value_type type) > > enum tel_container_types array_types[] = { > > RTE_TEL_ARRAY_STRING, /* RTE_TEL_STRING_VAL = 0 */ > > RTE_TEL_ARRAY_INT, /* RTE_TEL_INT_VAL = 1 */ > > - RTE_TEL_ARRAY_U64, /* RTE_TEL_u64_VAL = 2 */ > > + RTE_TEL_ARRAY_U64, /* RTE_TEL_UINT_VAL = 2 */ > ^^^^^^^^^^^^^^^^^ > > is this supposed to be RTE_TEL_UINT_VAL? > No, only the comment is to be changed in this line. The ARRAY_ values are different and are internal only. Those are renamed by a later patch in the series. /Bruce