From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0E7BA00C5; Mon, 19 Dec 2022 14:22:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90CF140685; Mon, 19 Dec 2022 14:22:55 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id EF1D140146 for ; Mon, 19 Dec 2022 14:22:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671456174; x=1702992174; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=iPYawM4WGKIYjouuz+pJqqTXJfiQkAKqkmsAPJGBZ8M=; b=V2c1u4uFKVj/fobgTGJRqi9pV9hjRyJE/eorZ+qYSuvK0zV+K+Xrn9Si 646NzU+qVVgs5Nn6H1ZA/O/AoH19gJ0Nc66tsHiyB6crAystJgDOUj4S+ VoNLDGqeXCE2x/BkaDSIp/Lhaeb/pUGhAI6podgEr7nt1k9tCujKw/QCC Gnr8hrdEeAznHsaQjXjtE1t4H+B/ExiplrYSLsjADyvw4aqoWWrjGgSBi 4MYRvWQY5mjxdW1PFSQctZNiZWt6/NtRkEvG5fj6kjQRA3YaKQW5Kpapi 7opVG02V8O7do5jMRhNMa1SPskjb8v3iZdHfLJz3tYAMMV75tIj0wndT+ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="318033869" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="318033869" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 05:22:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="628298318" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="628298318" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 19 Dec 2022 05:22:50 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 19 Dec 2022 05:22:52 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 19 Dec 2022 05:22:51 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 19 Dec 2022 05:22:51 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 19 Dec 2022 05:22:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nGmbjqfU0Vh6Zw4PUGRJnCDEzu86LfZLCAzwx2JLEQrnIhMb/X+ex0xSxh1fdKbNJY1yDO1EdDwzNnaURuEkOqbXd40ZJXuOlGbyk1icrKr0rLSfa7ETar7yxfIZe32dooTka+oeduf5qvYG1QbutdO/SjPaPpZmwLnafmtcibDuDgBZlt5V8kL3xTn3Jjze3dm6wH2c8vkXt2FjOaONt/0/ujKrW0NYh9kOkfCPvbIFjw0Se7jZBXd12GakOQJM2G7zxUllECfJhV0SdLIs1yNNN72bl5wxnfDoYnCEN6y/s40MbI9eRbfW3yk16HMmKGTzlg4/QNVoBbPLAWzSCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6JxmFr2uEvkeEy1L2qk+fYTwbYoGGQouT3DPqcOhgs0=; b=MKTy3VoZOPT3itCkkRJ3vmVJG80Jb3TlTycrTg7RXDhYLkvXBUWgi+QIh7w/GPSBtuGNgFUW5eT0EJVzwElmmkmLGBN7K5aeWA/nR0TEtwgN18jMp9wmQ7PEEKIjDxIZlE+LFhip/gRdTyPgBnqQ1asUzU3wu3zsl4ml9iiwgbRa4bi/y7DIEbqMEk1EcLhSUyp9/6MTsp1hvyjCdtYuhyLlQst6xAVVGpgp6Ui85DNlMZEWJKooTbpdf3whwDMUvhUKIzndkEB8/xMt2yqldDDbcVVllP1iReMs9bmpxJOVeQs1UMxz4wgtIiQsfMbwr08opn0UVddQy8/uHGl1YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by CY8PR11MB7923.namprd11.prod.outlook.com (2603:10b6:930:7e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 13:22:49 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5ce5:e8ac:70b0:6908]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::5ce5:e8ac:70b0:6908%9]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 13:22:49 +0000 Date: Mon, 19 Dec 2022 13:22:43 +0000 From: Bruce Richardson To: Thomas Monjalon CC: Tyler Retzlaff , , Morten =?iso-8859-1?Q?Br=F8rup?= , Subject: Re: [RFC PATCH 2/7] telemetry: add uint type as alias for u64 Message-ID: References: <20221213182730.97065-1-bruce.richardson@intel.com> <2122310.KiezcSG77Q@thomas> <1914029.PYKUYFuaPT@thomas> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1914029.PYKUYFuaPT@thomas> X-ClientProxiedBy: LO2P265CA0275.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::23) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|CY8PR11MB7923:EE_ X-MS-Office365-Filtering-Correlation-Id: 9358c878-3bb5-4ffc-d9ac-08dae1c41ff5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8X8pn7ZEwfp+OsRnbV0J/sXuvW9aJUUIT12J8grRI+JAW3RPFVwNCe7VGBEu/8/FtwJJNguiff05WPhEhrKFU0/CCMGoLOCBabIwBH5TH2vPtntKkvzVXKZkTW3zWs5AJUYf50k312NuBdRX9feBXMc7+wYWeh3LeeXamI5lw0aiTVOCQSydeil4Xca00uQkdS8c2A+ASL0kP1SenlEaq3nZQxhQmyf/zRGdoGcw844ZmUIySp1qJf67BhDrAUngXfb7631Y5HPviCtQsVgtzC6XlpEjCtb/BIjpUjqFIBleIG/u/FNzKlja937igxoAQJegsqqcFq3DpoO6e4tsPg/SBISIU7Md0K0xVJ9A7vnWKdOpupHKKhx462PDnAtCmqGVGzaUN+qnkexOF+lyAIVVG14Bas456V+/s8Bh6wIgqGbsHC8X4CFXw65UvOuwvPeawoT1r9fItzkkJRD/htZx8sPF42AE4T2KRZ0PgkIknVfczk5rbzYxPbuZv7JZj/DgH9oqAa+/86U6NUdh4XYZp+wB5ZaCh7muDOUuARR5esF+Hd55pS29sRn3op4LaE2eYuZhhYT7cqpJa6kAOiOMcycxYOAeUAzq7moFUqWeDfLdXX9bADDnvhMf61xFwvAvwHdBB2Xz4/0xPSbrdg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(39860400002)(346002)(366004)(136003)(376002)(451199015)(38100700002)(86362001)(83380400001)(2906002)(4326008)(44832011)(66476007)(66556008)(66946007)(8676002)(5660300002)(41300700001)(8936002)(26005)(186003)(6506007)(6666004)(66574015)(6512007)(316002)(478600001)(54906003)(6486002)(82960400001)(6916009)(66899015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?sGzMaLcD0W8uRBDiCx1HQEwHLPmoXPheYuGbQ9pC/GY0lBhPb9vp2qXPms?= =?iso-8859-1?Q?VJ/lO0UtunC+ELdnc7mcsrpaz908akRJBR7q6FRaQIuUgT8A3ob3uVxmsa?= =?iso-8859-1?Q?8ALRrMnseIxbGfVcRe5puYr2JR6DY8xaMECWFlaQ1nUwDlPZjzsmwsNL9V?= =?iso-8859-1?Q?+9k/7l2R/+eiO87X9QrXBosYxoeFVh0XOywzyOfBIkg2WZDqlR5wB8qvPL?= =?iso-8859-1?Q?C/a63G1MdB90opWNVFzoP2e47KvoIm6IoVj6m1sNP++riWgeh1quz7DOwg?= =?iso-8859-1?Q?myl6bK2WtqyVNAQGeg9/txdZ4SY9rCimotnwGuhcw9QSCL0eb6uXkPfNVH?= =?iso-8859-1?Q?CkUH2bYjDzQ30oQZ/lZz6aXg2yfvVdksXl+5QMNKVfQESwd7qUVpjymNUX?= =?iso-8859-1?Q?2m9QQxEkr0Ileikr/inXlZUJrxh+ISkdtFnVpartROChuOzUrWND6f19N9?= =?iso-8859-1?Q?pn42yYYayH5VdErbLYJIswtFDlw8wH0ay0RZeROOFBLyuKBIzkoZAK6Tzd?= =?iso-8859-1?Q?xjKdX1EUw9CK4XNGS5XVX1u9RbCT2SEABBWOIw8u8n+DS8z/aFuCLMQB2Y?= =?iso-8859-1?Q?rT1zoLMnsX4pOPCOpvjWRaFRJuxo49Z4suhqo8W/MNe/Tu/JPyVCWtajUY?= =?iso-8859-1?Q?ev/sxrw/8zmw7WvchF12dmBr4623yDT+eHtC4ETwrK18LLYnPEGAKXRgQf?= =?iso-8859-1?Q?rnO2PV9F3OQEXc4/lLmkPqpizZ4pCvBiKlOzvkgAyRmVMG0XXeA9Rx4acp?= =?iso-8859-1?Q?lQ6wuZqB6bvvtfnUj6ksQwUElKOY/yMw7aoiQV8iJfQHTtvh8J5Q36i0N3?= =?iso-8859-1?Q?fF3a1FJ9lE7szcMhRcfRvybeCtyJPDw9QxObnV3az27wY6G+A/nA2AfHVq?= =?iso-8859-1?Q?XgGNBisg5Wb7PTBQV9njrPvihd4WHxjU0Bk0vz387+BWYPaP6tK3Yp5h2I?= =?iso-8859-1?Q?u4hmm9JlFGMwZ/6Q4MW91uEwWeVzK7Jv+jsmUMVwDLUWUfuoN/2oWZh0Sh?= =?iso-8859-1?Q?rjUpkjNI4KPKoLNRYpx9w0xSGtpLKxkXeEJIaFveqstv6XCVS773mSOdJ3?= =?iso-8859-1?Q?NhS+5hIdG1/NxpsoXV1XlaPChOKugrSrn2tMnQRzASux9Gw2bAsjey8fJN?= =?iso-8859-1?Q?Pb74lb/WmUu9fQGIsojIOla3jsUf3xjmTZ5K0sOnpSXjrp5NRoDQiT3jJa?= =?iso-8859-1?Q?caMZ2Fh69AMInDTR3l1NMqqEhxA+TeJ4igLAvy5J2kfI0hIHypDtj7QNWr?= =?iso-8859-1?Q?63qu1/Cb+F+KxsuHMn9exYpV7imhZyNu/AojX3GfV1seeIIbJF1kxXW+Vw?= =?iso-8859-1?Q?RdprDdTn/JhflR73g9z4IiNk9txs9AguKqU/U5hB88GD9mQWUIplnqG9Bt?= =?iso-8859-1?Q?0qUe74UeWp97n/plHfo2ynjm8AiYM6tVRa2ntZTfFHK0tCcmytsYEO6JNg?= =?iso-8859-1?Q?JkQI1dsdTJsfFED5xfy/OquSBz604s94dXQbL9HrTwTJGxsZhvDvf30DN7?= =?iso-8859-1?Q?TyKhQQ7ooWuDnI2Kx0ewGBBKzYOZa8y5AnG6oOJkOzg3GwWqf2vs7y+Miy?= =?iso-8859-1?Q?NPs0ALWtKq/VpLFLfpqqVB5GXTcuxEg1e1eaAjDHrJpxWvucMnqcHHJXvq?= =?iso-8859-1?Q?89bdofX685h3V1ETmikBpisgxB9lJeYw6CyWjwUXizxwOMS8MXIM2+dQ?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9358c878-3bb5-4ffc-d9ac-08dae1c41ff5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 13:22:49.5047 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R0MHB7xafqX4ZzZLNVrhz0WTMVyou4KjD6lbIZZwfr5TTucaacJnHqYN82cJiFCNiGi4H8vPkoAyC+h3WP0ZkHsWsmwOw9+pT462zN+YIVg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7923 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 19, 2022 at 11:37:19AM +0100, Thomas Monjalon wrote: > 15/12/2022 14:58, Bruce Richardson: > > On Thu, Dec 15, 2022 at 02:36:51PM +0100, Thomas Monjalon wrote: > > > 15/12/2022 10:44, Bruce Richardson: > > > > On Wed, Dec 14, 2022 at 09:38:45AM -0800, Tyler Retzlaff wrote: > > > > > On Tue, Dec 13, 2022 at 06:27:25PM +0000, Bruce Richardson wrote: > > > > > > For future standardization on the "uint" name for unsigned values rather > > > > > > than the existing "u64" one, we can for now: > > > > > > * rename all internal values to use uint rather than u64 > > > > > > * add new function names to alias the existing u64 ones > > > > > > > > > > > > Suggested-by: Morten Brørup > > > > > > Signed-off-by: Bruce Richardson > > > > > > > > > > when adding __rte_experimental api i have been asked to add the > > > > > following boilerplate documentation block. i'm not pushing it, just > > > > > recalling it is what i get asked for, so in case it's something we do? > > > > > see lib/eal/include/rte_thread.h as an example > > > > > > > > > > > > > > > ``` > > > > > * @warning > > > > > * @b EXPERIMENTAL: this API may change without prior notice. > > > > > ``` > > > > > > > > > > > > > Ok, thanks for the notice. > > > > > > > > Actually, related to this, since we are adding these functions as aliases > > > > for existing stable functions, I would like to see these being added not as > > > > experimental. The reason for that, is that while they are experimental, we > > > > cannot feasibly mark the old function names as deprecated. :-( > > > > > > > > Adding Thomas and David on CC for their thoughts. > > > > > > Is it related to telemetry? > > > > > > In general, yes we cannot deprecate something if there is no stable replacement. > > > The recommended step is to introduce a new experimental API > > > and deprecate the old one when the new API is stable. > > > > > Yes, understood. > > What we are really trying to do here is to rename an API, by process of > > adding the new API and then marking the old one as deprecated. The small > > issue is that adding the new one it is by default experimental, meaning we > > need to wait for deprecating old one. Ideally, as soon as the new API is > > added, we would like to point people to use that, but can't really do so > > while it is experimental. > > > > --- > > > > By way of explicit detail, Morten pointed out the inconsistency in the > > telemetry APIs and types: > > > > * we have add_*_int, which takes a 32-bit signed value > > * we have add_*_u64 which takes 64-bit unsigned (as name suggests). > > > > The ideal end-state is to always use 64-bit values (since there is no space > > saving from 32-bit as a union is used), and just name everything as "int" > > or "uint" for signed/unsigned. The two big steps here are: > > > > * expanding type of the "int" functions to take 64-bit parameters - this is > > ABI change but not API one, since existing code will happily promote > > values on compile. Therefore, we just use ABI versioning to have a 32-bit > > version for older linked binaries. > > * the rename of the rte_tel_data_add_array_u64 and > > rte_tel_data_add_dict_u64 to *_uint variants. Though keeping > > compatibility is easier, as we can just add new functions, the overall > > process is slower since the new functions technically should be added as > > experimental - hence the email. For the case of function renaming, do we > > still need to have the "renamed" versions as experimental initially? > > If a function is simply renamed, I think there is no need for the experimental step. > Would we keep an alias with the old name for some time? > Yes, the old name should go through the deprecation process. No hurry with removal. /Bruce