From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08DDB423B5; Thu, 12 Jan 2023 12:05:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD11B42D28; Thu, 12 Jan 2023 12:05:27 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 7A9BF40E25; Thu, 12 Jan 2023 12:05:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673521526; x=1705057526; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=DwIFRUKowkuD5et+edDsTkVUk+IjrQGGZanqmHLg95g=; b=LvFVfevAyATkwZwPfg6+JXadRwUbOt2ueYtTBnX/jiL7DS6mebIbIX1G Htuc+osVfNh/GSYhy0uBoGTAK7l/ZkwGRZ8WfOGrWc1edjBYim+ipoGmi EQdrND+SZ6GJU+0cg3vD6FcNBp6BqO8reeXKSlkJb8+fkqzbwZmG6sMcg krFjYjhJv7K5rGuEmxvx+abi0ZEdJQim6sUF3xIKu/9VB35Xm2FqXQ36n z9FBkDJ7iDZUme4DlA/W/LEHkvLh+krdQNO9cDsyA1ipbPA+PaGNxOuth 8D9OEiWyeGc8b2LmsjhHVCnPEwzjw3dNJk24dbdG1EkrpvBA1Jc8IOF6P w==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="304050369" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="304050369" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 03:02:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="651089746" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="651089746" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 12 Jan 2023 03:02:55 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 12 Jan 2023 03:02:55 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 12 Jan 2023 03:02:54 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 12 Jan 2023 03:02:54 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 12 Jan 2023 03:02:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eYlEb5kbBr2+3eQSe/jieYfxBB/xH222d3+ykCZ1qbSDGoV7uiyNeMgMiUH0/I7Wr0NrXWWz4EVxmdkB+bHSxGQmcRw8eV/4Ouw1btL4MQaZGu0GjG5X4dzvmsBUOfrdnBcTDq3wxdF7g7MRDwOfWyldel3FuCexV6HDcCFx+zELK1faTNTfmChRFrWkQ873yASdC9KL0O4U93BW6NNKSe+bPE/1XadNstOQplHxR1SrpOzbpMq9pdzEviFn/piWByvmhvVuMFIYxLE5DvBVlwcHe/X5vWP5rOUzJg5R40gzjcUU5/jdZ/sx7akRL0ksxlLX5rdzvK5uS/jI+u3Q6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/LN+z3PBh7OqpK/77qEbsIv7TwELjl1+wtuw9BrhGEA=; b=OyPxGPd3kBKWGbASSkmJaX5SzdV1jzU+g6XLm/NAsx5ynn+fGdHlIFnxLIO+IWClA2ozJiJsNXMtTFZvuwjWxKboJY9GHbdVSEihcNDapyloAua0ckmAXd/VnNFbY8UkbmNO8wpB2KvKyRqEwMelSUiG+ACHUMXkn2skHTyGkx3vittdJ+s+HceDcxfir9zrs+XYA7ytV519gGMZBay5HRTFOPfuXg23K6GiwJjHWk4JdVAb4KsvpD00EyZqlLk/kH33NUTwcU03w3vDg2WIZtBAE29DE2mcpXUauyD3lTineegbDCa4KmBQYtLtRYEJ+dmg1OJHNk9/1hCaUr3wAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB5122.namprd11.prod.outlook.com (2603:10b6:303:95::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 11:02:52 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee%8]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 11:02:52 +0000 Date: Thu, 12 Jan 2023 11:02:44 +0000 From: Bruce Richardson To: CC: , Subject: Re: [PATCH] bus/vdev: automatically add eth alias for net drivers Message-ID: References: <20220921133451.4164506-1-ferruh.yigit@amd.com> <20221019131118.32394-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221019131118.32394-1-bruce.richardson@intel.com> X-ClientProxiedBy: LO4P265CA0224.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB5122:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d72559e-6e90-4fc1-f388-08daf48c8c72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WTJ+6bJLYjc5B5xePbztcn8QSZPSdgAXu35lS0itXxvfx5pmHWN1oxa8sd3u1INwuyRVE4zX+OhBQ0b/0uVTejw03aYtT4cLW030AW5OMZOHvXbbmWHcrktTQ7Zl0cvlpM41nii6GQOv03eFmRopPe9lRhTqqFc4TOULqu+DLdJf4AdlJa22gKhMnZ2iE9sy65J2wifBwm65viUjTF1GSMzC53do39+tdCloWHn1eFZFt5yPL2zSlOJmycFEc+skqkXxJA9U3NzqQ+RjvTjkMUmTVZ5B2f894APDQFDIMU0kVSFO8jJVCU2ggdkOyPQvU4qGIN70Y8Fyg80ByUqWwPHqoGLHVzHNyOTF7RRjnve4nOFZl9cHm8rmuNUaIqxAiIKpI0K+SlCIeISDygS9Arc8P7dVd3PdUXvqtaFQzbfH0gtKRnV2i6DlZNyGiHcjaCYsrg1DqGArKZgYUJexxJeMVNM07Hn/AzQwMrwn8VoSvHo3li0wUikbMi0nBU/wE/dlB2tlO2My7GrOPtVnkQh7shdSn41EP8lxfMmjFtDDkg13VNQGqqE+SiM/rb6VY7DWmzqssN/lRqtg4gaTclPWFgGaRMlSmWIqgmytSWPxAKiTXoEazLfJhNLM/+VI06Ako+XVYDW5bWweCAmLpg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(376002)(366004)(396003)(346002)(136003)(451199015)(82960400001)(4326008)(6486002)(41300700001)(478600001)(38100700002)(316002)(26005)(66946007)(186003)(86362001)(8676002)(66476007)(5660300002)(6666004)(6506007)(6916009)(2906002)(83380400001)(44832011)(66556008)(6512007)(8936002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4daHb6xYTiTjFriFLiXHkYfwAi2nN2/ngNYQfW1QByh6ylSFYpsL986kRbne?= =?us-ascii?Q?h1If1vKBMP2CH+yFCb/MqwUVKDW9uFqblm7Y90xdmqa13Cu0b6u56So30zzZ?= =?us-ascii?Q?fRcA77qEgRZuwJflUKm9sI3l+vyT6qfaI/0VJioOqkRPXuLMK16okwzmKClH?= =?us-ascii?Q?u21ClUwtPVYYtzWGutjNeroZrNW+VLS72O0aSiFC44zo99UKVDT51ZFlv0eV?= =?us-ascii?Q?em9pCh+aZTkVSdebl1cplN57xXIf3eaUd4ISi1LzDq0ZkYqjSb7qDLJ2KYPn?= =?us-ascii?Q?zQq8VssRCAX9L4mano7wCzHpXdqUYadK9gFpmxzgebzUa7+fdIQvWoed9oZQ?= =?us-ascii?Q?Sc+DvFjvcBYl8svq/5QDOIPg/oHTCPMl4x1x6vI6iLIx5qhEMoJOXZgFV6LA?= =?us-ascii?Q?KtXGd1R2sgXuQ4859ReJl53z+7juvuRAyowunqAuyVIsrKqXuDD8D0X+GLbS?= =?us-ascii?Q?MYja8J3rwNZa0E3aeyiGy+UBkDI9zE3y22NKqyb1yWHNNx1VRQcfJSMowz9T?= =?us-ascii?Q?ZwXhq9fCxjj+2X9TBTQxNDbbWE+Pcil2eaMThPPIcgAokPXrHvtvV27+/EDP?= =?us-ascii?Q?Fys4t0yIYMvTg9yM1fi/xrg3lRcY5ZDlM4oVZJ0T/5GpA+VPzhjBHcOPLPYV?= =?us-ascii?Q?CxBe4sXAhDbGh8RNu4lNAqbP2ENw4JgDQdyvoeTRswY5kD9STEkXBubb/11Q?= =?us-ascii?Q?Q6f7KFhPzUKUEkyoYrXav33L/Goraw9RmldTcJSSFbMLmcp9TCwz5EQER1VO?= =?us-ascii?Q?bNjfVMS/jd8h++sWxCYj1pUzPkrKjfyHtkxjrsvDwTIchKcVjjKFSk30hD91?= =?us-ascii?Q?nSZmc7KwABKFdWQm3+esHivYG1viL+n7O/C5/MyxfdeEwAtcv2tTjRhN2rIz?= =?us-ascii?Q?mZB/DQgjg9c8D8QBnKaCAOwHtqqWkWdip5XXJlisZSxqNZsSpKVIhr04pHFX?= =?us-ascii?Q?ZldVFNV1oQuAVMIvqoTlhBYYUPnmmCNJoHzZfD2Qxnqm+SsDv49UqdS8nBpi?= =?us-ascii?Q?BJR6skx3fOhbkRxxxIRVXTWipcaIAnKF1lQrbZkbHpvitoEgXkUpyQHJKm7n?= =?us-ascii?Q?GOOO2RyVveqJEfZvIrCPDaGmoRhD+k85dkGIwNdM469C5xXF0xnHULreLldS?= =?us-ascii?Q?k90tgsxgGfj3TlTLoGZ0ffuc+ofOChw+0FZg/U+KORnGvJj3qJIbZh0Mg7a/?= =?us-ascii?Q?0ob6vquo/ET3+GWfxoqoXrd4HdGjuHCvQjO2DSNbMMlesXmvyI+d7O6IgQuz?= =?us-ascii?Q?xuMdRlU2JwNh7DPl1kEOiF1mpPb+/qX7vHtChuQYnh41RjsTVl0zDSBgM7LU?= =?us-ascii?Q?3Fs44U5AJKA7E6MPgIj0eDYBSbeJ2GfUqJWADygDjFS4xPB3fUItjRADQrj9?= =?us-ascii?Q?duT43p5UGe+VXfmLDD+Gof1KVjq8T4NoDS0AIXl8Ot7R2v3NlacGdqQJd9Bk?= =?us-ascii?Q?69P8VjgxbG7nx2CBtQSHzOJolYdthWam7K6tEkbSb8DsebZKgs1X2ji4T2Hr?= =?us-ascii?Q?EJNlr/KjHbjOVpPuXL3uH0odlrssV7lP31xmoxi/V3jTSQaOaiwlJMoaVLZo?= =?us-ascii?Q?XvoZuehINZ1txO+/0Ed40pvXqdbX3E21FHAGoXPf/3B9CC9DJtsReNhYr2wR?= =?us-ascii?Q?PgD2/xeaJ9DZjaFXNdLX8+8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7d72559e-6e90-4fc1-f388-08daf48c8c72 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 11:02:51.7945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lhIHW1G9YZiwbDnKwC9uOgb2c0DZjPEL1UH/EznParZO43zdG4VGLXDa5dC3SXzx3OGGf3aGzVkow2rJS0iQgAdb1ja4XFnX+3HlHxwawq4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5122 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 19, 2022 at 02:11:18PM +0100, Bruce Richardson wrote: > For historical reasons, a number of net vdev drivers also add a driver > alias using the "eth_" prefix. Since this is done on a per-driver basis, > the use of the alias in inconsistent and is spread across multiple > files. We can remove the per-driver aliases by just adding the alias > automatically at the vdev bus level. > > Signed-off-by: Bruce Richardson > --- > drivers/bus/vdev/vdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c > index f5b43f1930..bfd7ce60c1 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -54,6 +54,12 @@ static rte_spinlock_t vdev_custom_scan_lock = RTE_SPINLOCK_INITIALIZER; > void > rte_vdev_register(struct rte_vdev_driver *driver) > { > + /* For net driver vdevs, add an automatic alias using "eth" prefix */ > + if (strncmp(driver->driver.name, "net_", 4) == 0 && driver->driver.alias == NULL) { > + char *alias = strdup(driver->driver.name); > + memcpy(alias, "eth_", 4); > + driver->driver.alias = alias; > + } > TAILQ_INSERT_TAIL(&vdev_driver_list, driver, next); > } > Just to close this off... Following the discussion in the thread, it seems a fix is not needed/wanted here, so dropping patch and marked "rejected" in patchwork.