From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>,
Stanislaw Kardach <kda@semihalf.com>,
"dev@dpdk.org" <dev@dpdk.org>,
David Marchand <david.marchand@redhat.com>, <bluca@debian.org>,
<christian.ehrhardt@canonical.com>
Subject: Re: [PATCH] build: avoid deprecated function for Meson properties
Date: Fri, 6 Jan 2023 12:30:38 +0000 [thread overview]
Message-ID: <Y7gUbqIZ68XRyakv@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <3394891.QJadu78ljV@thomas>
On Thu, Jan 05, 2023 at 10:14:04AM +0100, Thomas Monjalon wrote:
> 05/01/2023 05:25, Ruifeng Wang:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > -* Meson (version 0.53.2+) and ninja
> > > +* Meson (version 0.54+) and ninja
> > >
> > meson.build:15 needs update to reflect the version pump.
> > And .ci/linux-setup.sh:7 also defines meson version. But I'm not sure whether this file is still in use.
> >
> > With the changes:
> > Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Thanks Ruifeng for the good review.
> It will be fixed in v2.
>
> The question remaining is about distributions support.
> Do we care or rely on pip?
> Why did we recently agree to use 0.53.2?
>
> Do we want to wait a little for using 0.54?
>
Personally I am fine either way. Since using pip is so easy I don't
think we need to be that concerned about distro support.
next prev parent reply other threads:[~2023-01-06 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 11:36 Thomas Monjalon
2023-01-04 11:59 ` Stanisław Kardach
2023-01-05 4:25 ` Ruifeng Wang
2023-01-05 9:14 ` Thomas Monjalon
2023-01-06 12:30 ` Bruce Richardson [this message]
2023-01-06 20:33 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7gUbqIZ68XRyakv@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kda@semihalf.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).