From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FC104246E; Mon, 23 Jan 2023 15:37:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15D8C400EF; Mon, 23 Jan 2023 15:37:38 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 5F981400D4 for ; Mon, 23 Jan 2023 15:37:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674484656; x=1706020656; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9s4QQ1qft+I2P0Ee1ifSeOJ4d+kHEoeHuCewrc+xUSk=; b=ALsQYjejMEpwHdjnhW8obNqYDiICmwG+GK31c/D+gJyRPlktKhNTPCcW bQ58cayo3ZPAe1xPolp5rKfv6Pv3ahMFqKCr/VzfSxa4cdT1flO5AOX0/ du0kZmX5zC2avyui6eEz2s9+ayPe0JLIAkXEuqnzR5LzERwEGP8loNWnG eTRwVZ4nr+0jUIHKmJ2IZ9c/cCn+RfL6AHyfAtetV+Mq7Q55N2uGOZH1w oz68w1y4DKMny04oaDHSJJh0B7Rejy7d9V27KkwjAGpD9w+phdfSDO5NJ iSSHxS42r6MqW3Xba1xCfAyoLlaPbDEXOpvTPLJavYQrj19qG/tacV8sF g==; X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="353316088" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="353316088" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 06:37:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="639168479" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="639168479" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 23 Jan 2023 06:37:09 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 23 Jan 2023 06:37:09 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 23 Jan 2023 06:37:09 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 23 Jan 2023 06:36:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gd7OGG9ZUGoY9E2gnxx/A4wVauvUpqpQHaHheMvJ4MjhVzxd3dcYbmBGWsw3fa4l0m2tUavX5kA6bK/zA47eADOfag5uhGcjrg9Yh4l8eUO2XkgD6Z6n+obm8DUeiVfCKI6NIsr2NgFbd5VcTPshD02U5j/1WuInR3uZb06PSQu4P3Hv5d0ydUNx1fDD0N4P0J2QLVfhWnLV/qobknpqhJGQFMrJBhLvzz5+AUpnjVsfNCt5DHYZF4XLRu/Nt37YK5Pw1zeXCjSAvBXGavT56MCHZhiXrEvlsjibiMPM8bhqgzKKMHtlgERn5JcEsKrrO2dmtFdQVuk0KwIkc5EyBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9mRlRohAiM914oa5qZVuKqc6w8WQH+4Hyw0JQcsHBfg=; b=MSsaqRP0AJK2L7NAYvLWcqD4hN8Yi2pTgTB3wEcOUAuuivFX2JF3n4Fp1iKyTzk6h5D8oQRVzKcOF1r0fLVd9i+0gvn9aj5twYl2qWsnXiJlDImvhTjbO/sxdSKOyrLf6Z6e4ka7rXP2WWBCXHPAr3ARQu/qljxHJzD5X+JxhvFZxBmwmtX26hDaVSpO3c+Tbu9Mg5pQslPo8g8ZZEZt+19XPGPTPkum3sXfFJNAFC2tj2x71guvMHBQNfjdNJtxrFudRTBd+dzdmShzbZd2HakJrSLNI5JaDdAtJpvxLroudQ8F6PffCzTewE++AFhIpbvIsjv3JZ4P1LVShXIFpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB5913.namprd11.prod.outlook.com (2603:10b6:510:137::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Mon, 23 Jan 2023 14:36:46 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee%7]) with mapi id 15.20.6002.027; Mon, 23 Jan 2023 14:36:46 +0000 Date: Mon, 23 Jan 2023 14:36:39 +0000 From: Bruce Richardson To: David Marchand CC: , Thomas Monjalon , Dodji Seketeli Subject: Re: [PATCH v4 0/3] Split logging functionality out of EAL Message-ID: References: <20220829151901.376754-1-bruce.richardson@intel.com> <20230120182154.481039-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P123CA0081.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB5913:EE_ X-MS-Office365-Filtering-Correlation-Id: bfac2f55-11b2-448e-4b07-08dafd4f411a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cVXbr3JKdX93SJQ2i+RWu6WKVy6VJJOVNKQ3ItI3iVpC1Tac+LfWVAG6d13zDdUxZvA6OWI1pxr5k59+CwAhzxZ1Juf9naMtEr8QgHutBwRJ5CPE4yzMjZNSqgOTW8zb/8ST4N04lgq3QlH9VRye7jPzAJ2M2Gga0JOeFjY4Eo8sMutCMg0LGpnuiFLOHNjr+qo6KCLfNDjJnjaebE7Gjg28WEc6oRfE2/KCWoN9GfZT8xOfSFkTWpoL5jPiRbRp5tQFIwfDF2QYAgmMo/IrkryPgHEONtceGqsgWZ2j9/gxDTHsNaYqHYnZxTZRlF4jWVPavPNTXXovyXCdckxgknZqQDglaYzW87GeWphMZb5/DONhGj+fpakLEMW8790CQd9Hv1EPl853HW8k67EXmW4aU6oGaNQPAUTjHV2JtrHhNLNeIM0l6IsWceSf90B4htessDl9By5vTijkPlguppM1XKCgmdskOPWo4unAhvDlUEz62NGPLEKgWaF+QRqDmZAQpPGPlOOyEf2Uj/PlBIVrFAStHfkFfUR6AdyLpQq23RZVDXIBn/2MN6ppDchHjXbGf+G1NTwLWEp4ZiDsXBUnehLKoxeNO4DukW5lqiSKK57QnPwJuaVDELndWQWGA+f+ui6t0kHe5D0nx0J8ag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199015)(316002)(4326008)(66946007)(66476007)(8676002)(86362001)(6916009)(66556008)(54906003)(26005)(6512007)(186003)(6666004)(53546011)(6506007)(83380400001)(478600001)(6486002)(5660300002)(44832011)(8936002)(41300700001)(82960400001)(2906002)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Lb4/Lx3h26eeg+Co0WJtZIkDI62ksAdq3HM8bbZR6RwzEEy9Pfc6MXkno3km?= =?us-ascii?Q?5++QTfDw11ylpWBmSUSxYP2dDlUgc+4G1VmmetZVj/vq5+T6J6toazyySj0R?= =?us-ascii?Q?Lss3FEE5EXd2lHd1Pkhnw/UpZha8bTvxZgjflIaYl6jEc1G74cQ9MmlF023k?= =?us-ascii?Q?p5xAbBSfkeGHsyg1hfq7kWtA02aSnlmcg2BHh3H8IrUzjAalAQbl5jNTl8bR?= =?us-ascii?Q?54d651P58OgXONtkWpQYl4cHOacgZI6LMWUXpf+wWiMbW970hAVzsd2A14td?= =?us-ascii?Q?+CxKQikLE80SgQgSRL1D1BhaTP/dAzYDyZNYwzRJSJDxOMP6nKl01CcT+8YU?= =?us-ascii?Q?c3ucuSazv25akZOJ99tnhDbjkNrG4dxGjmv7ClPCFrpt/sqx7Zsi/kB702aQ?= =?us-ascii?Q?GR1Jr0Avg6XdthSsLI8iKB0Ckeu7OM7bIKQjU89CIISr+ZlN9Gj1mAwZugmu?= =?us-ascii?Q?3S1McZ2Q18btAiq5Bz0h/VfCLFB+t8Lyk0Acbd00nXWxQPyIqNpvRRH4pxzp?= =?us-ascii?Q?ZjAiEozO748bLQbpFi8sZJ4Vp/cjd2t30vVMTmtgO4+YsZVCqd6Wpbun2hyG?= =?us-ascii?Q?Vr+BF8sZ9/qsj3VCkwnEs45RdnMhB2R8s8SPNzBi9cP8zpdYNli/HW/fN1Cf?= =?us-ascii?Q?6nRqnXxcz+INDKZZZaQoXYg6sbkVC/A3wCNdHa7GJStCC8iJzCc3MINk0Qot?= =?us-ascii?Q?J/ZAXbwoeZEIcAURSvy4fPADlCv1bgHKWMBUF1RkAxxROlawTlSxnpntd31w?= =?us-ascii?Q?0LsfE7Vn5XXO5HBctm0pCSPIK5sPoxwy9kMRyXMyhTnkaXikBCZV67VNYfV9?= =?us-ascii?Q?iFFEEp4CmPM3uNOSqHZlUaNl2fTN/XM2UO77WjlsDGShRcRzuGlCF4TnP1MX?= =?us-ascii?Q?HtzQIKLO63Ikogm4BYJvxGw4xqRNyUytCrXiz27vGcwfDjfJ1BgnGwzAbrRg?= =?us-ascii?Q?PvQtWmfZMyUyPgtBcVNQsHzAS1FgAEMQnUxQEFo5DGDCrdUBghLlCFJwVcFf?= =?us-ascii?Q?rkCWL7jrH/ckmOajVaJA0r6ASwRptx6knv34mZnqMdrAZKrDocK4cZwpU2UQ?= =?us-ascii?Q?bkcRHmJ2atuyQ9LzBK0jH6d4NIuoYW+a9kNKljc9NgW3YhEcdEdNerf0xGCq?= =?us-ascii?Q?Cup3R+bbjQOAMdmM6oz8ojYph0dXPn9C1CP/9y9WzkvVnxNEjSdIn/3yTFNH?= =?us-ascii?Q?MV/2RGa4WhAkiIALdkkHF5peI6HYkSBPO4cInyV3Hjny0nYBCnw4DsPkMRle?= =?us-ascii?Q?SqxG3uf6qk0CP9cJnvifc0cvXLgolDPGrHxhUvuBvFS9MT9I5kmKxW5F6fYF?= =?us-ascii?Q?Cwq6G1K5dwdEwiK7/s8mRaA97xDNLg9QIJGc9Q0xE2lMcwDDdiSU1u89kFDZ?= =?us-ascii?Q?oLUM7R0I5HcU2N6Q/2itb+QAkIaFSzGCh/szifhdMAkeeOvsMr5NuMJe3biv?= =?us-ascii?Q?iMQQGp0qWMqw1ZdCXVJ2TJGGp0eOTkxSJ45BGYSloOqtAimEtDbwUQH9QC78?= =?us-ascii?Q?dVj1oBSEEapk81oYR10S5UjV/ohICHiEM8miKqmNIf6XCtj1vnpnBuMcxHXn?= =?us-ascii?Q?6vrKWrptelPfqRgFRVO1xOM7HvnzpN5LolzarM3kfyMMGL4N1Wzt/vIay+Rb?= =?us-ascii?Q?QQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bfac2f55-11b2-448e-4b07-08dafd4f411a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 14:36:46.5020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UE6JSR4VzxZFYpbPcNS2zVou946ezkuGRcq2F5/53nvzQRvfO83qAY+I0+nATfk/Nxr7JokoNy68IpXwHlDnaInm00y5d4s1Bzy0nPTIRZg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5913 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 23, 2023 at 03:31:58PM +0100, David Marchand wrote: > On Mon, Jan 23, 2023 at 3:24 PM Bruce Richardson > wrote: > > > > On Sun, Jan 22, 2023 at 03:56:12PM +0100, David Marchand wrote: > > > Hi Bruce, > > > > > > On Fri, Jan 20, 2023 at 7:22 PM Bruce Richardson > > > wrote: > > > > > > > > There is a general desire to reduce the size and scope of EAL. To this > > > > end, this patchset makes a (very) small step in that direction by taking > > > > the logging functionality out of EAL and putting it into its own library > > > > that can be built and maintained separately. > > > > > > > > As with the first RFC for this, the main obstacle is the "fnmatch" > > > > function which is needed by both EAL and the new log function when > > > > building on windows. While the function cannot stay in EAL - or we would > > > > have a circular dependency, moving it to a new library or just putting > > > > it in the log library have the disadvantages that it then "leaks" into > > > > the public namespace without an rte_prefix, which could cause issues. > > > > Since only a single function is involved, subsequent versions take a > > > > different approach to v1, and just moves the offending function to be a > > > > static function in a header file. This allows use by multiple libs > > > > without conflicting names or making it public. > > > > > > > > The other complication, as explained in v1 RFC was that of multiple > > > > implementations for different OS's. This is solved here in the same > > > > way as v1, by including the OS in the name and having meson pick the > > > > correct file for each build. Since only one file is involved, there > > > > seemed little need for replicating EAL's separate subdirectories > > > > per-OS. > > > > > > There is another complication. > > > > > > The ABI check is not handling properly the case where symbols are > > > moved to the new log library (even though the dependency to librte_log > > > is explicit in librte_eal elf). > > > For now, I don't have a good way to handle this. > > > > > > A workaround to pass the check is to suppress those symbols wrt the eal dump: > > > [suppress_function] > > > symbol_name_regexp = rte_log > > > [suppress_function] > > > symbol_name = rte_openlog_stream > > > [suppress_function] > > > symbol_name = rte_vlog > > > > > > But this is not a good solution because we would be losing checks on > > > them for the rest of the v23 ABI life. > > > > > Right, I got error messages from the CI job for this too, but I also have > > no idea how to work around this. Perhaps we only get to move content > > between libraries when we do an ABI bump? Seems a bit restrictive, though. > > Moving symbols as you did does not seem an ABI breakage. > An application that links to eal would see the dt_needed entry for the > new log library, load it accordingly and gets the right symbols. > Yes, I agree. However, I also agree with you that it is risky to lose symbol checking for the moved symbols if we need to remove them from analysis. That said, maybe others have some ideas as to how to work around this, or perhaps we just take the risk of disabling checking. /Bruce