From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED00842490; Thu, 26 Jan 2023 12:10:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDF0B40A79; Thu, 26 Jan 2023 12:10:38 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 4E86040697 for ; Thu, 26 Jan 2023 12:10:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674731437; x=1706267437; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9kM8X9dHui6MtewtKn1tOkh2rJomOpCkr9crmuCNiYg=; b=ILF1SCSZmJ6f3uSBo3rnTdj0svUV3vCUt3ciYnIMs/QvDyaUtd2qHXbz WIX4oz5RFCztdatZHHPaB8yuGuVChqvhLFevP5+k/WwCbo8hUosCpyW9f 2QIzbt05PhYnKVnSgEEzFRhZJmTrsuTNJ2bhLScwiIB3iTdptOv5NVn8/ QV+5A1arbX3kwMvV8G2835fIyGXUFIh5PqTnv/y+QUxiRj6fIDzE7JT5b eECG9eZbc2GZAw/7UDOKl+siSSalssw9vb07l7FCG5Twj2o5/1WIvixzg 4kHW1H/WNx5GtEqyxwCcS9mBqheesU9SbFDXbXHUHp6138Ggl1vlCv0YI w==; X-IronPort-AV: E=McAfee;i="6500,9779,10601"; a="306447715" X-IronPort-AV: E=Sophos;i="5.97,248,1669104000"; d="scan'208";a="306447715" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2023 03:10:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10601"; a="726246435" X-IronPort-AV: E=Sophos;i="5.97,248,1669104000"; d="scan'208";a="726246435" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 26 Jan 2023 03:10:36 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 26 Jan 2023 03:10:36 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 26 Jan 2023 03:10:35 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 26 Jan 2023 03:10:35 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 26 Jan 2023 03:10:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kg4vMuM0uCpyw/nvaaWuMD0WKYhEwr8tKmZ7C1Q2h9TFDVqOAhmBgos4u2ySeX3ijYnAW0WwPnC8Jd0jdyP9Dla0riLJRm7XOSRlsn6RTJEiAVl5hMHtuiIdL67vqIcyB6RUCrwj/O9WB4kIoKt4O5BGTd+zOFv8ETWK9kZsE9VQLVmRJk66IRg3t1LBt8N3HZkE+MLVq+++BJI2kCiaEw0kGnll4APsPHgxlGJXT1btJ62Iyzc0eVxEadgiLZ2CjgUM2KFOB5DWWdU9dTJ/8vSQItZ5aKmKbGAimz7HvMos7QXKduS6TCy5a6ShboGxczGOsdhfjTpoEOvTFlWoDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ZVfpJ+1b2I8HDHrRmhxo5wUQgrI56PCeWzEE+ty73k=; b=PdUNsd3PQjYVb0bKrbrK2AZGDiYqNBu/v2sgurqgaTBAoJqYAqNgqb5h1FiiQi6LOQ0lyzAM5DiFvn0U71nFlFqsosBFsx/FUyaT2E9AeBcXSWpHyUFIVy8DVwI3dh3I1BFfPmjZKzEnMs7eYcfPODu3R8cQCK1Oq29Gmt08FDTNkGcR/4AqC5VmWoAPlOli5W7Xou4EFi7zACL+80KTj2RzFQ5v8JSNyEqXxzbAdcJF1G0XqWssp1uJ/eQPuricrWZ0hE4gG4mpMeMlA3CgCowp9VY8YK75jePcXGSekEl/1ITVixXBbMc5OmbQnF+zWxdyUP6Ju/XsacbqJD+5nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH0PR11MB5219.namprd11.prod.outlook.com (2603:10b6:610:e2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Thu, 26 Jan 2023 11:10:33 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee%7]) with mapi id 15.20.6002.027; Thu, 26 Jan 2023 11:10:33 +0000 Date: Thu, 26 Jan 2023 11:10:26 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: Subject: Re: [PATCH 3/3] build: limit what is built when using MSVC compiler Message-ID: References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com> <1674674707-3094-4-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1674674707-3094-4-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DU2PR04CA0158.eurprd04.prod.outlook.com (2603:10a6:10:2b0::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH0PR11MB5219:EE_ X-MS-Office365-Filtering-Correlation-Id: f5b82e0a-9a24-4181-e4b9-08daff8df119 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +eNLw471L/2dzQZq5nxZ4bw2MsyUKWVxEvGrnzubcWrmbMsi41bp//gNrEZR+NsnWe6PjT9cwI0kWE625/We4Tzbv/zi3v/oQBiO2YfgjqeqGE+EPuUy4ynd8boP/2it16eUktjPfYltO4/vWnjcEDM4aPRU3ye8UyZxHgtGevY9rSt4W4J13GSvHpxozktKxrfQYV+RfinoYvVoimgJuTe25ZZSVpSO0eCM28qSudX7bQimIfnrWbK+sLgRVXMUeIjl4D/nykNx7SxdWmgkmBKefcgams7kS6pDnXwPiqC4/eVK5lVOlwhbiubL+Gyl1v6XWItG4h1CXQ2ESYxHJPn6XTfMf6RFIh6TEk9bBVaXKEee7sGnKmmQzJHhO7O0lfvqUhHxeHBF5vIi0RZG4RohdOoa7qpBRpsxSdIhh77I4CUz45EOsvQhOTpdyxzwTSdCdmaUyr8MMz5H9jt29Unh4kh2wbXMoBcXPKR1r2uBh2urx7qNT4kCPrGVLbZWiII8mudd79FhoiLqS8qpD78HO0XCBV2XFaHG7eej7rMfxOy3PWxTMN99Ak+lnNvRslOqmuBMQdRvg4/m0v7V6IfHmB7OjSaHPQUNX/yEJtF2hpxCetEZZcmmc57YvZn+A/Av7plT/SXimXTB+ItGUg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(346002)(376002)(136003)(39860400002)(366004)(451199018)(4744005)(2906002)(66946007)(6916009)(82960400001)(478600001)(6666004)(66556008)(66476007)(6486002)(86362001)(6506007)(8936002)(5660300002)(38100700002)(41300700001)(44832011)(8676002)(83380400001)(6512007)(26005)(186003)(316002)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?36l3DHBkMjWbCdYBdLR+uGBNRXoZFUDwmtDaM9Ijj/hLw6bfyusyRGlwJSks?= =?us-ascii?Q?VDampy5A3aAYs2eJn4yDV9ueSfF7sWU8SNBGGEid+N2BDv0cXrGj2hj/nzt+?= =?us-ascii?Q?5c/SWzzFgh6P1CV1jXmbZ5anPrqyQaEXpd5R8TvGW4DyR2QXIKEK7F4wO23h?= =?us-ascii?Q?dciIZiSLPTWoKZMOwtpI1JnUj4+0G1cyh2fWJLE8mIb1iueq752DL7n3EsW3?= =?us-ascii?Q?WW4sYMYSzJEgR7bClhbtYrxPnALijnAcEvjtIQk37b7L3eIZsEKJqx7nfdzM?= =?us-ascii?Q?BvRXTmOznm1yP12WvRxEwP/OOfKPUFrgJtRCp6S2IZgNhB5QJdYRSHtnZO9N?= =?us-ascii?Q?9Tep0r7Ri8Xm8GRk1xNbnehfWZLSATp7EC72O85BhN3hVLgsVTHakLbq6Qo3?= =?us-ascii?Q?oZQfeJx0HSSpzPtIPo5hBr0xSkmmEyavicbHam0NY5eldm/cNpUicmWlrgYf?= =?us-ascii?Q?T3Hv8UA5jalDZPqOmsFxn0/jPKjBIYr/ns7sdXnSlpxRlKKa6R+/067EcuoV?= =?us-ascii?Q?2AlcPwid4orwM8hs//GmOKX0UnV+qyQ7Z2VSKylLk8eHdw+DW3aW4HkEmJ4M?= =?us-ascii?Q?tC2EIq/bucstXbxoBWzSAsprHjUYnjt9+vVvp4Y8ua1dFYyOzDBC/SU+PyY4?= =?us-ascii?Q?qPs8PDkOZe6/1BFYulcE311889LQWG1KqBu3AXug5WEU9jKWhcOtta+G13HW?= =?us-ascii?Q?GowzsJiIXjH2Vg9VKya8cuqYBwmpGAQMDxmt9rNGBzrCne0i3zjZXHKqW4XK?= =?us-ascii?Q?ZsSIM5LFDLRQ/MoFML8Ff4CRxjPXLgl14pkn4/nLVH0qUDUpCqso1Cq4stmH?= =?us-ascii?Q?qqFFiR50q5roLbAK35USU08dnU5sOKeSLFydBQalJAWO948agiWfjz74eBVC?= =?us-ascii?Q?Y/lNkP6lz38PXQMTWoAwsdQCOlKA2bU1211AnV13QlCPvJFmSjmv7/pRC2Tj?= =?us-ascii?Q?NQjAHbmIn+iNDIB9+BK0KJ1Vr3qxgqa3G7MNk2vyj8iSy9mWrQECSlx4/dAb?= =?us-ascii?Q?EzCyZqDf2KBLGTSqWhA+4FfzQCdFFTmTmWV00c/3S6Sy1IsxwSSGdL3DG/T7?= =?us-ascii?Q?nqvgXL/kVCC3Cq/1MyknVAffj6P3KQP5nUdRExTFz5XEQT617gDt/qZYXQHI?= =?us-ascii?Q?1kEgcVSBsPIdoN07JT4jxNizBeJPQ2jZxfpOQ0UhSieDs0O3kNXZ7rE2W8qI?= =?us-ascii?Q?/mzUfF9v+6Kefoo3MJWSh+GwKfQT8WhfP2ZjwbCdy4ZXCnTh0bmhZ8TqKL0E?= =?us-ascii?Q?JxgmdlkZpK9/xH6EQZ6uZ18wdAdA13VYvKmv28d+oywGu/vt8KrYAk4kepSY?= =?us-ascii?Q?7C71UxH+CDQhA85J6UMCrrpg2COwVTg4aqru1NYIsY/Dp/vCq0Ib48DQfFXk?= =?us-ascii?Q?RRYx0gKEEQ1NcrtsraSEHeTKWKnkRtaCmqNn9YP6jJHwGtZNyqa/rfKqefBs?= =?us-ascii?Q?gqdlT/9HZf6as/FsSK5yKPr1XiCXX5kspnqPHo6HsatFvdtMRZy4KdFa0oce?= =?us-ascii?Q?O9TxqKeU83HZi5CrapuvYl9Z6ktLVm61Tvw3UzrTPLtOjAVNfSy81EmOpe3v?= =?us-ascii?Q?r1ChoMh4OIjNKp9XYzol8eX7MVRshQ5X3/fpD3RcFLS2jkWwtvYh5aUjz1eg?= =?us-ascii?Q?dUQ0QiWz7wboy1wDB8SX3aY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f5b82e0a-9a24-4181-e4b9-08daff8df119 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 11:10:32.9168 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bRmfizdu3k/fIr7vxlnmePPRfTVn2t49FvlCbPstQbFzK5YkJp+j47Dwu8o0RouEhmygIbkNZ3dgo9jYKjeLODiZkcRbx/VOUxOHIDVTFrQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5219 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 25, 2023 at 11:25:07AM -0800, Tyler Retzlaff wrote: > Build only kvargs and telemetry when is_ms_compiler. > > Signed-off-by: Tyler Retzlaff > --- > lib/meson.build | 7 +++++++ > meson.build | 13 +++++++++---- > 2 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/lib/meson.build b/lib/meson.build > index 82e4666..8e99e21 100644 > --- a/meson.build > +++ b/meson.build > @@ -76,11 +76,16 @@ subdir('config') > > # build libs and drivers > subdir('lib') > -subdir('drivers') > > -# build binaries and installable tools > -subdir('usertools') > -subdir('app') > +if is_ms_compiler > + enabled_apps = [] > +else > + subdir('drivers') > + > + # build binaries and installable tools > + subdir('usertools') > + subdir('app') > +endif > My own preference here would be to put the checks inside the subdirectories, and try and keep the top-level meson.build file clean. Would that work ok? > # build docs > subdir('doc') > -- > 1.8.3.1 >