From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA7242495; Thu, 26 Jan 2023 18:35:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6CA740143; Thu, 26 Jan 2023 18:35:01 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id E9361400D7 for ; Thu, 26 Jan 2023 18:34:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674754500; x=1706290500; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=1w3+ydAHTCHqvau0ImE+WGdK4mkajDWdTu8OlKql/c0=; b=Nux9o4VBMRL89fd+Ql1YlZ55qhb9bowChIlA7Z9c/FUXzQUOl5yb2SSf 3iFpEqKG7BOiDUZJXdrXH7krJPFGo2KtNvlWm/fikhXcpq3XDmySxL/8P 5CLITNSJSJPtFJG1muFqVwelM0VTYRy/LoS6/vBCznxGdgxMOBk1NlEWN PneZ2My+o+u47zMyZbwYkF5cpc+5wvvkUFvxntfa8XK+brmi7DiJLIbS3 f3cDOLYWRIgJcm87iemex3N852IPgiaLWOxzVs5FOtPipPl8saROA8o2d n+bn+9u8Xr42AhzES+AdsKlw0Pe3f63SLNCwOzIpdYkqfh2pMq4upmPQb g==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="413106781" X-IronPort-AV: E=Sophos;i="5.97,249,1669104000"; d="scan'208";a="413106781" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2023 09:34:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="908320874" X-IronPort-AV: E=Sophos;i="5.97,249,1669104000"; d="scan'208";a="908320874" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 26 Jan 2023 09:34:58 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 26 Jan 2023 09:34:58 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 26 Jan 2023 09:34:58 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 26 Jan 2023 09:34:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TX/hojQwkTJCopJqb/MRXXBTQ17wI9vBX6wiIg/h73i9SsFj4SVrWw+ocujhEegyhEWHG+57F3XzKb/d9KZ1F1hyK7Yq50Lk93CanmMsWZrYg7YxsQ0yP/W37vzTrRNTRlWXkSsV2x368ER1MSruttFB+t3GuFLaVCmg7QcpfTOeOtpRgVKzSHHTmHfkYpgYT3J2HrePrQUPnM9dNvg0ZEDS9hNJcYrVVc0kvn10d8YIH+FYUkrm+rgKsdMHFz4TzxVYLJUp0sCDQSQ+sDxRNuX+a2Z+96XlowkI4jdmuyaFSzi4cbaHgU+F+9tLKiXmmsXaQvu0puB8F5cYqEArRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UJeb+SyYL/o5ZOm7InkXE/B91EAQjMTnu805YuS6ZFw=; b=MLx+Uoybug3xLuWCn/Ruvwe95WvAq2yS8kH8QJzVhviMKLqzd+3fp8OSiCVuvphFv1jwQCG8JYIaqJXvwBLD/93b1c68B085Me4hTrEGxufnYbgpJMm/jRMxofxMfxr48erfniK/acksMukTgl735bwvsYp94tI9OKw1Uub4VUgsuPSYwTS3s3DWjnuOAyJ/IuO+NqOOA9uVSNT84Flb9/Plag6JJUwJpsVNxlb1da4VjpwgSjrbtOZDmB7G+ncMsGjdnaEtcsYIYug0eskCYKok3GJBRO400ubb5FU47BKQ8Eqm6dtdS3aZE5n7lX+zn3dCjtsr2EegrASVQtwYdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB5477.namprd11.prod.outlook.com (2603:10b6:208:31f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Thu, 26 Jan 2023 17:34:56 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee%7]) with mapi id 15.20.6002.027; Thu, 26 Jan 2023 17:34:55 +0000 Date: Thu, 26 Jan 2023 17:34:50 +0000 From: Bruce Richardson To: Tyler Retzlaff CC: Subject: Re: [PATCH 3/3] build: limit what is built when using MSVC compiler Message-ID: References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com> <1674674707-3094-4-git-send-email-roretzla@linux.microsoft.com> <20230126172858.GC13258@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230126172858.GC13258@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-ClientProxiedBy: DB7PR05CA0007.eurprd05.prod.outlook.com (2603:10a6:10:36::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL1PR11MB5477:EE_ X-MS-Office365-Filtering-Correlation-Id: 12b98216-e0d6-4fb6-5aed-08daffc3a397 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tRhIiNMg50XGYjNyJkHC3Wphy/3g4uIDVnvXhMiAVXtfdOYW/Kn0LxsC8MNazYHEkfW+ZED0ZkvUat3teTNng+WiFowzrmkRz7EsozFqqtab7dp98+2gwnXGMJfmcyRx5iCulbF3KEUGnfV8NXsboNppGKNntJNoWTzY1AvySXbR5Fbqm83wmnwJrPeF/8xD/1YnmHwISHTabogB+kpZdZVC1ALu3voaQSkBsquvjdV7XvV80Emew79aBSVhCIsb5Q5j1mT8nqXtjS4mMhrDkx/xatoRdN2zLOL5O/2S5gOsubPIrrd7tbmODD1OoFbiwsWu2U0eQ86Fjfuz356kTMz8EgUlJXXe9r6kNi0YZ8Ix0N+2zx9rPecMEXpdsgB9Un9o9GKiaHEpWRU6va3w1bwMEtQznq2xRnIOGrkAZz7goxI3g5frXKeXXrrd/gbyyQMXnkBBFTJaBKo8kS6Rogmi65tXRXV5Z1LcI1ZiUvlVBlYGog4hMxAxUfwOkG0kbzzGgg0gbJ2861rWLwPqxWE4cCAAzTH7WNkUQD/0Id32TONMh6CpVVuQ6U0zL7ILrgBkw8LFOK+GUnkbGlqCjTefljT/rsSNUKhAqlImPsAD72vSOKTegUMo8s/hY/SLe5cxEJe6UCuI7NF3bp1ugA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(396003)(39860400002)(376002)(346002)(366004)(451199018)(83380400001)(186003)(26005)(6512007)(2906002)(6506007)(82960400001)(6666004)(5660300002)(316002)(8676002)(8936002)(66476007)(4326008)(6916009)(66946007)(66556008)(38100700002)(41300700001)(478600001)(44832011)(86362001)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7LBGqJc0F3djqQX7ZpzeAjbD7rdu0r+2Gwct3RWlqH6XzRi/XxZkTyI53shp?= =?us-ascii?Q?j1ayhaMwRGEJL+DRVOieg7Co1vKn5LQXhyYOZ/fbwOLUWDCuRX6G0/O5BIEv?= =?us-ascii?Q?E8+9wQ2ggszlk2lOB1cy5RdDxHq+N73mh7XTZPu9Sp1ml/dPbRBRc0aj254+?= =?us-ascii?Q?Z1ItuT5uywcCHrEwCRuSxhLna+sxBvgPaV9oRE4islQYIIl0bbu+kkNrs4iL?= =?us-ascii?Q?XPQAQVbeAGw4cstDNN4L9t/JAh+qC8ZaPWmksY0FcbyeZsPptabRW55NFt7T?= =?us-ascii?Q?NcAR0J33zRV60viVYQmQTqs2WKy4kbpqOmV6GKo7opC2oFBRxvZRAYel8bIv?= =?us-ascii?Q?MKstcle45EV6IoHry2nw2z2hi5ez4IXYBvlcPccBpFQEjLSYldq6PGia2iXK?= =?us-ascii?Q?5fLQaaNoyj/3DrRPIuTztD+S5XP8Ll3fKD3/TKsZ0oxE1HoJMXPGsrQqmlMg?= =?us-ascii?Q?P7hDJOk5q8r6LD6BtXkZiqQ8hhU6RzLu46oNO401GighH2j0U3Cxd9pLZiEb?= =?us-ascii?Q?IL7mq1jns5S9Mn/lnzWbcbqYvnb/8INaRMU7C8BeqGFBxRZHD9a9W1byK5yS?= =?us-ascii?Q?9YFv7tsO/cvE/FLBYSX49V2fDx63j5Qu5JOITtf7ya+kFi1pxt4Mss2sJq+d?= =?us-ascii?Q?QlOBiDQ78aHuO2SJ60JWpLVJ9MRNTmcpAzcgWCNo6Axn4v8CvU/xHdvyLNdA?= =?us-ascii?Q?1QRhORtwG/FzirVP/Ot3McQRkKVNkOtdyzFbDZd56mTXa0oJuCpMeg+ih4WI?= =?us-ascii?Q?Mqq/gzjajntSMzLVwnhKaG8DTe/YTvRUuUioJ2TASnK+g4t4aziEcyB0As+/?= =?us-ascii?Q?63aeNhvWDBVniRq5Gnt7z7wQExWuiTYfN9VY+HJFKqZrMeEo113njy1ZvbJc?= =?us-ascii?Q?P9i73DHEhJxyui4P0lCIyBTFrLpI24ehGueXwV3BuavlIZdSHSUdn1NBDC+Z?= =?us-ascii?Q?ynS6vCFqQUkAl4aukJVin0rHPQTlKpULFj6afDFmJuw4mOPvtHRQUx3inZeM?= =?us-ascii?Q?ory/137sgrNjmr5Z2UxAkA98Ya5AV+y6jw4/rtIj9P4lEa+dq+LbBz8zh1pX?= =?us-ascii?Q?+CzseH1sI7jOVvr1NkldrGVtGd4Yke0d3kaCSIMgxXiftbO7PT2WDcO1oeu7?= =?us-ascii?Q?08WN7mQLlYN+t6K3/XGVZdCSI2Le8C9s66j4rU6vnluydHrHjeofgFGZQdZP?= =?us-ascii?Q?9U7vfB1U+6TCK9ahsLC2fvKEVZ0E/9jzgP2g/R5Q5thfjBRU90CsVsepWUAI?= =?us-ascii?Q?qkKmxmylSL6ctrvyClJRqhVbNEChKOXM2v80kioqIX6ed+H1Usk1qIH+R5ZS?= =?us-ascii?Q?fks8gO8DsVMS0svr2HuC3jqZJPGBUTSYe4+AaKMld3xchLkp+DteaOh/h6+/?= =?us-ascii?Q?mbN42EhLs45vhC0i49T8nAM31OkeqWiRZ2hXtAGROfgVElLcDrali6hUS0Yt?= =?us-ascii?Q?rRx2YKuOHLdl9g+Lfjz/6twYme3q5mQuNzneqDz0zB45Cqc8Gpxb4AkqWR3B?= =?us-ascii?Q?JA43ioB3KiruZohLyuKvBP3/4npoIOjnvFi44C+jS5okWQUTi7P9/DTsKp2p?= =?us-ascii?Q?+bLNu37jchJWB2NkgjKqShDxYaqpknp/SwWYk2w26RK+D9TJrov5yYKTffHJ?= =?us-ascii?Q?iw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 12b98216-e0d6-4fb6-5aed-08daffc3a397 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 17:34:55.7001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PFxp8HY8neDPvTU4dZy+4IEhRYEs2x2KPW7JfIeC2pxaCNU5aEdKfWWG6FWxO2DuRm5iataOSbP793Nw9/BuhXC52kw2SWwqHTkVlCXpSZk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5477 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 26, 2023 at 09:28:58AM -0800, Tyler Retzlaff wrote: > On Thu, Jan 26, 2023 at 11:10:26AM +0000, Bruce Richardson wrote: > > On Wed, Jan 25, 2023 at 11:25:07AM -0800, Tyler Retzlaff wrote: > > > Build only kvargs and telemetry when is_ms_compiler. > > > > > > Signed-off-by: Tyler Retzlaff > > > --- > > > lib/meson.build | 7 +++++++ > > > meson.build | 13 +++++++++---- > > > 2 files changed, 16 insertions(+), 4 deletions(-) > > > > > > diff --git a/lib/meson.build b/lib/meson.build > > > index 82e4666..8e99e21 100644 > > > > > --- a/meson.build > > > +++ b/meson.build > > > @@ -76,11 +76,16 @@ subdir('config') > > > > > > # build libs and drivers > > > subdir('lib') > > > -subdir('drivers') > > > > > > -# build binaries and installable tools > > > -subdir('usertools') > > > -subdir('app') > > > +if is_ms_compiler > > > + enabled_apps = [] > > > +else > > > + subdir('drivers') > > > + > > > + # build binaries and installable tools > > > + subdir('usertools') > > > + subdir('app') > > > +endif > > > > > > > My own preference here would be to put the checks inside the > > subdirectories, and try and keep the top-level meson.build file clean. > > Would that work ok? > > no objection. one clarification request though. > > do you mean just for drivers, usertools and app or do you mean for every > lib/ as well? > No, not for every lib, there are far too many of them. What you have done there makes most sense. But for drivers/apps/usertools, putting the check in the subfolder help keep the top-level file cleaner.