From: Bruce Richardson <bruce.richardson@intel.com>
To: Ophir Munk <ophirmu@nvidia.com>
Cc: <dev@dpdk.org>, Ophir Munk <ophirmu@mellanox.com>,
Matan Azrad <matan@nvidia.com>,
Thomas Monjalon <homas@monjalon.net>,
Lior Margalit <lmargalit@nvidia.com>
Subject: Re: [RFC] config: customize max memzones configuration
Date: Mon, 30 Jan 2023 09:47:05 +0000 [thread overview]
Message-ID: <Y9eSGWOzh+VY86jT@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230130092302.376145-1-ophirmu@nvidia.com>
On Mon, Jan 30, 2023 at 11:23:02AM +0200, Ophir Munk wrote:
> In current DPDK the RTE_MAX_MEMZONE definition is unconditionally hard
> coded as 2560. For applications requiring different values of this
> parameter – it is more convenient to set its value as part of the meson
> command line or to set the max value via an rte API - rather than
> changing the dpdk source code per application.
>
> An example would be of an application that uses the DPDK mempool library
> which is based on DPDK memzone library. The application may need to
> create a number of steering tables, each of which will require its own
> mempool allocation. This RFC is not about how to optimize the
> application usage of mempool nor about how to improve the mempool
> implementation based on memzone. It is about how to make the max
> memzone definition - build-time or run-time customized.
>
> I would like to suggest three options.
>
> Option 1
> ========
> Add a Meson option in meson options.txt and remove the
> RTE_MAX_MEMZONE definition from config/rte_config.h
>
> For example,
>
> config/meson.build
>
> # set other values pulled from the build options
> dpdk_conf.set('RTE_MAX_LCORE', get_option('max_lcores'))
> +dpdk_conf.set('RTE_MAX_MEMZONE', get_option('max_memzones'))
> dpdk_conf.set('RTE_MAX_NUMA_NODES', get_option('max_numa_nodes'))
>
> meson_options.txt
>
> option('max_lcores', type: 'integer', value: 128,
> description: 'maximum number of cores/threads supported by EAL')
> +option('max_memzones', type: 'integer', value: 2560,
> + description: 'maximum number of memory zones supported by EAL')
> option('max_numa_nodes', type: 'integer', value: 32,
> description: 'maximum number of NUMA nodes supported by EAL')
>
> config/rte_config.h
>
> #define RTE_MAX_MEM_MB_PER_TYPE 65536
> -#define RTE_MAX_MEMZONE 2560
> #define RTE_MAX_TAILQ 32
>
Of the 3 options, I think this first option would probably be my preferred one.
/Bruce
next prev parent reply other threads:[~2023-01-30 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 9:23 Ophir Munk
2023-01-30 9:47 ` Bruce Richardson [this message]
2023-01-30 10:00 ` Dmitry Kozlyuk
2023-02-12 8:14 ` Ophir Munk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9eSGWOzh+VY86jT@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=homas@monjalon.net \
--cc=lmargalit@nvidia.com \
--cc=matan@nvidia.com \
--cc=ophirmu@mellanox.com \
--cc=ophirmu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).