From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 12E68A0579;
	Thu,  8 Apr 2021 15:05:37 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B68EF140FA8;
	Thu,  8 Apr 2021 15:05:36 +0200 (CEST)
Received: from sysclose.org (smtp.sysclose.org [69.164.214.230])
 by mails.dpdk.org (Postfix) with ESMTP id 3C24240138
 for <dev@dpdk.org>; Thu,  8 Apr 2021 15:05:35 +0200 (CEST)
Received: from localhost (unknown [45.71.105.250])
 by sysclose.org (Postfix) with ESMTPSA id 3EE842618;
 Thu,  8 Apr 2021 13:05:35 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 sysclose.org 3EE842618
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sysclose.org;
 s=201903; t=1617887135;
 bh=7R4WghEJRxXfWqpw1uriTzBZiDCq20FourT9i2BpDxk=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=I0gWMDA1NQSWLsHPxe0bLjbmLlYwqkqV+5u5sXQEpbY+RK++OytWFGNoPIOfFVoIh
 GL3Cb44X+4/tx5Zp8CjqyZQpzXmW9HMeXJHYXeNbLm45gM5R/0/XdKxoaAR6i3tWg0
 LqfbUISvQ2r86ldLgjOd8u3VQ3ZFNM2TDcE5PNxwNF/aDbqIGT9sQtdgvLEMx4kuEk
 c+UR4S7SAQy3TFC3weiH32AkFuWUhyjlqG3JtBSasJtV92FJTP+mKMxlXuoC7JrCsX
 IZFBlRiD7zxNyepTQRiNS7KLMlWkZep+AYb/EHtaLrfgRIsXGrXROm/asTCyztczXP
 80u7CWOkGDr4A==
Date: Thu, 8 Apr 2021 10:05:30 -0300
From: Flavio Leitner <fbl@sysclose.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, olivier.matz@6wind.com,
 i.maximets@ovn.org, Chenbo Xia <chenbo.xia@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Jerin Jacob <jerinj@marvell.com>, Ruifeng Wang <ruifeng.wang@arm.com>
Message-ID: <YG7/mvWhGVJlrd1z@p50.lan>
References: <20210401095243.18211-1-david.marchand@redhat.com>
 <20210401095243.18211-5-david.marchand@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210401095243.18211-5-david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: refactor Tx offload helper
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Apr 01, 2021 at 11:52:42AM +0200, David Marchand wrote:
> Purely cosmetic but it is rather odd to have an "offload" helper that
> checks if it actually must do something.
> We already have the same checks in most callers, so move this branch
> in them.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Reviewed-by: Flavio Leitner <fbl@sysclose.org>