From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42720A0579; Thu, 8 Apr 2021 20:38:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B84B8141171; Thu, 8 Apr 2021 20:38:52 +0200 (CEST) Received: from sysclose.org (smtp.sysclose.org [69.164.214.230]) by mails.dpdk.org (Postfix) with ESMTP id 1C80B14111D for ; Thu, 8 Apr 2021 20:38:51 +0200 (CEST) Received: from localhost (unknown [45.71.105.250]) by sysclose.org (Postfix) with ESMTPSA id C7A6C2618; Thu, 8 Apr 2021 18:38:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 sysclose.org C7A6C2618 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sysclose.org; s=201903; t=1617907131; bh=QiF+s2+qfupRY00HwBkpqhAs0cgCXMSw9wK/NVMVh7M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tXJSENkrFkyiKCQEVJ3RtdB1asDZ3yO9GujuQjjyf2u2bcpKDX63ovXEwz4voTH+J OYXx8p4sHIsGSoa8sLzFJtpxJwQ/MminagTGYrnUDIxnaALPB4CGJxCCEBDH2E0tQ3 fgOHmOkOQ+zwez46qfkiecUK+17mFw7XYGXexQLC0r8ZZ4xfF+rU91WW+bN0it0t15 /fsDaNLGmAloGWwZOH2UFV2/NDnx7RDY/AdEPn7EzrNDl+5RXrTL4/h0soz2XCqlb5 ueawU0WnVbmQFpAzjr12rmEoUulcnBIWhThnK6CJsQf233M16MVOfiz6rk9XIEGJD6 JpyRg8hKmz0xA== Date: Thu, 8 Apr 2021 15:38:41 -0300 From: Flavio Leitner To: David Marchand Cc: dev@dpdk.org, maxime.coquelin@redhat.com, olivier.matz@6wind.com, i.maximets@ovn.org, Chenbo Xia , Jijiang Liu , Yuanhan Liu Message-ID: References: <20210401095243.18211-1-david.marchand@redhat.com> <20210401095243.18211-6-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401095243.18211-6-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH 5/5] vhost: fix offload flags in Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 01, 2021 at 11:52:43AM +0200, David Marchand wrote: > The vhost library current configures Tx offloading (PKT_TX_*) on any > packet received from a guest virtio device which asks for some offloading. > > This is problematic, as Tx offloading is something that the application > must ask for: the application needs to configure devices > to support every used offloads (ip, tcp checksumming, tso..), and the > various l2/l3/l4 lengths must be set following any processing that > happened in the application itself. > > On the other hand, the received packets are not marked wrt current > packet l3/l4 checksumming info. > > Copy virtio rx processing to fix those offload flags. > > The vhost example needs a reworking as it was built with the assumption > that mbuf TSO configuration is set up by the vhost library. > This is not done in this patch for now so TSO activation is forcibly > refused. > > Fixes: 859b480d5afd ("vhost: add guest offload setting") There is change that before ECN was ignored and now it is invalid. I think that's the right way to go, but not sure if virtio blocks the negotiation of that feature. Reviewed-by: Flavio Leitner fbl