From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB835A0548; Mon, 26 Apr 2021 12:56:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF84B41104; Mon, 26 Apr 2021 12:56:47 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 0862A40140 for ; Mon, 26 Apr 2021 12:56:45 +0200 (CEST) IronPort-SDR: a00u3k/JTE7P8JqdSBwTv88WX9m7PlY/sW5/doKkrEnvZWN26tvaXoLyj1CK6hAJc6dN+Dpxy/ 8bXjAWQhrJlA== X-IronPort-AV: E=McAfee;i="6200,9189,9965"; a="196374159" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="196374159" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 03:56:44 -0700 IronPort-SDR: a5p4HC91okiiyB+ForEkqt+6jqVT+pczmnR+V9IBrIy9Nf6wO9r3uPr+wHlfg0G+CWIakHbvg0 BWhuNgClXTHA== X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="429352557" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.12.160]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Apr 2021 03:56:42 -0700 Date: Mon, 26 Apr 2021 11:56:38 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, John Griffin , Fiona Trahe , Deepak Kumar Jain , Nipun Gupta , Hemant Agrawal Message-ID: References: <20210421220358.2597249-1-thomas@monjalon.net> <3561141.xXdziFVvtq@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3561141.xXdziFVvtq@thomas> Subject: Re: [dpdk-dev] [PATCH] drivers: fix indentation in build files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 22, 2021 at 11:20:19AM +0200, Thomas Monjalon wrote: > 22/04/2021 10:39, Bruce Richardson: > > On Thu, Apr 22, 2021 at 12:03:57AM +0200, Thomas Monjalon wrote: > > > A couple of mistakes slipped in the mass change. > > > > > > More mistakes could happen, especially when rebasing pending patches, so > > > we need an automatic check. > > > > > I have a partially-done script from when I was doing the original > > reindenting work, which I'll clean up a little and send on shortly. > > > > It only checks indent of lists and I'm extending it to check for trailing > > commas, but it may serve as a basis for further checks. On the plus side, > > it does automatic fixing of those issues though. Running it will probably > > show up more minor misses, so I'd suggest holding off on this patch until > > then. > > OK, I've sent this patch just for remembering. > I am happy to leave it to you for a v2 :) > Feel free to change the author of course. > > Note: I've found tabs with this simple grep: > git grep ' ' '**/meson.build' > The tab is inserted with ^V-tab. > I've included fixes for these issues in V2 set of the python script to check for them. http://patches.dpdk.org/project/dpdk/patch/20210426105403.226004-2-bruce.richardson@intel.com/