From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A059AA0562; Tue, 4 May 2021 14:08:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8361140147; Tue, 4 May 2021 14:08:16 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 653FB40141 for ; Tue, 4 May 2021 14:08:14 +0200 (CEST) IronPort-SDR: SpUYclNCdqvfQtL0o3iwPkmTNtFsw4DFIIM+AZ8GqPO+44es/GYzuOjyG2N/+zCGYy3xNXga67 lBWbsregjIRg== X-IronPort-AV: E=McAfee;i="6200,9189,9973"; a="198051127" X-IronPort-AV: E=Sophos;i="5.82,272,1613462400"; d="scan'208";a="198051127" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 05:08:13 -0700 IronPort-SDR: ZfP/QiNXnFc6E//o9EiSUqY+Ci66PN87WnhXFTF9dbG23nD1o8cDeocuWmVKkA478BeA9ltU+u e6+OUBDwvlLg== X-IronPort-AV: E=Sophos;i="5.82,272,1613462400"; d="scan'208";a="389943752" Received: from plaurenx-mobl.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.15.85]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 May 2021 05:08:11 -0700 Date: Tue, 4 May 2021 13:08:08 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, kevin.laatz@intel.com, sunil.pai.g@intel.com, jiayu.hu@intel.com Message-ID: References: <20210318182042.43658-1-bruce.richardson@intel.com> <20210430150637.362610-1-bruce.richardson@intel.com> <20210430150637.362610-10-bruce.richardson@intel.com> <7298907.SmeENqnXTm@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7298907.SmeENqnXTm@thomas> Subject: Re: [dpdk-dev] [PATCH v4 09/12] raw/ioat: move idxd functions to separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 03, 2021 at 11:35:20PM +0200, Thomas Monjalon wrote: > 30/04/2021 17:06, Bruce Richardson: > > Split the rte_ioat_rawdev_fns.h file into two separate headers, so that the > > data structures for the original ioat devices and the newer idxd ones can > > be kept separate from each other. This makes code management and rework > > easier. > > > > Signed-off-by: Bruce Richardson > > --- > > --- /dev/null > > +++ b/drivers/raw/ioat/rte_idxd_rawdev_fns.h > > @@ -0,0 +1,275 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2021 Intel Corporation > > + */ > > +#ifndef _RTE_IDXD_RAWDEV_FNS_H_ > > +#define _RTE_IDXD_RAWDEV_FNS_H_ > > Please add a doxygen @file to explain the purpose of this file. > The same is needed for rte_ioat_rawdev_fns.h. > We miss the explanation of the difference between ioat and idxd. > Agreed. Will do in new revision of this set.