From: Bruce Richardson <bruce.richardson@intel.com>
To: jerinj@marvell.com
Cc: Nicolas Chautru <nicolas.chautru@intel.com>,
Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Olivier Matz <olivier.matz@6wind.com>,
David Hunt <david.hunt@intel.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Ori Kam <orika@nvidia.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <gakhil@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Sunil Kumar Kori <skori@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Reshma Pattan <reshma.pattan@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Kirill Rybalchenko <kirill.rybalchenko@intel.com>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Byron Marohn <byron.marohn@intel.com>,
Yipeng Wang <yipeng1.wang@intel.com>,
Robert Sanford <rsanford@akamai.com>,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] examples: allow pkg-config to override
Date: Wed, 5 May 2021 14:00:04 +0100 [thread overview]
Message-ID: <YJKRCAjX+3wItFRC@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20210505111944.1294519-1-jerinj@marvell.com>
On Wed, May 05, 2021 at 04:49:44PM +0530, jerinj@marvell.com wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> In the cross-compilation environment, it possible to have
> different package config such as aarch64-linux-gnu-pkg-config.
> Use PKGCONF variable to detect the libdpdk availability.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
+1 to the change, but on the commit log side, this looks more like a bugfix
where the PKGCONF value is set too far down the file rather than adding a
new feature. The support for overriding pkg-config is meant to be already
there, and test-meson-builds.sh already sets PKGCONF in the environment to
override it.
/Bruce
next prev parent reply other threads:[~2021-05-05 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 11:19 jerinj
2021-05-05 13:00 ` Bruce Richardson [this message]
2021-05-05 14:25 ` [dpdk-dev] [PATCH v2] examples: fix pkg-config override sequence jerinj
2021-05-05 15:30 ` Bruce Richardson
2021-05-05 20:23 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJKRCAjX+3wItFRC@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=byron.marohn@intel.com \
--cc=chas3@att.com \
--cc=chenbo.xia@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=ferruh.yigit@intel.com \
--cc=gakhil@marvell.com \
--cc=harry.van.haaren@intel.com \
--cc=humin29@huawei.com \
--cc=jasvinder.singh@intel.com \
--cc=jerinj@marvell.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=kirankumark@marvell.com \
--cc=kirill.rybalchenko@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=ndabilpuram@marvell.com \
--cc=nicolas.chautru@intel.com \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=pbhagavatula@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=reshma.pattan@intel.com \
--cc=rsanford@akamai.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
--cc=tomasz.kantecki@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).