From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2BD0A0524; Wed, 5 May 2021 15:00:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51EF440040; Wed, 5 May 2021 15:00:22 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 21B434003C for ; Wed, 5 May 2021 15:00:20 +0200 (CEST) IronPort-SDR: UgR3X8wApSMuUKnjBGA2+6JhtpYOYexngzvgiWE+JCFyqVvCQeux9ihEBus7dYT47bM/ET4FZ9 m1dKohJFDd8g== X-IronPort-AV: E=McAfee;i="6200,9189,9974"; a="262145727" X-IronPort-AV: E=Sophos;i="5.82,274,1613462400"; d="scan'208";a="262145727" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2021 06:00:18 -0700 IronPort-SDR: FumHAJwSLzF3DVq+T9T/mas586oP/EacwCNKgVPWsx97kP/CN7tyXLlVn+iBSYtCGGfKyQMgIe 4M/WY+hdbkTg== X-IronPort-AV: E=Sophos;i="5.82,274,1613462400"; d="scan'208";a="390321670" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.14.204]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 05 May 2021 06:00:08 -0700 Date: Wed, 5 May 2021 14:00:04 +0100 From: Bruce Richardson To: jerinj@marvell.com Cc: Nicolas Chautru , Chas Williams , "Min Hu (Connor)" , Olivier Matz , David Hunt , Harry van Haaren , Marko Kovacevic , Bernard Iremonger , Ori Kam , Konstantin Ananyev , Cristian Dumitrescu , Radu Nicolau , Akhil Goyal , Ferruh Yigit , Tomasz Kantecki , Declan Doherty , Sunil Kumar Kori , Pavan Nikhilesh , Kiran Kumar K , Nithin Dabilpuram , Anatoly Burakov , Xiaoyun Li , Jingjing Wu , Reshma Pattan , John McNamara , Kirill Rybalchenko , Jasvinder Singh , Byron Marohn , Yipeng Wang , Robert Sanford , Erik Gabriel Carrillo , Maxime Coquelin , Chenbo Xia , dev@dpdk.org, thomas@monjalon.net Message-ID: References: <20210505111944.1294519-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210505111944.1294519-1-jerinj@marvell.com> Subject: Re: [dpdk-dev] [PATCH] examples: allow pkg-config to override X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 05, 2021 at 04:49:44PM +0530, jerinj@marvell.com wrote: > From: Jerin Jacob > > In the cross-compilation environment, it possible to have > different package config such as aarch64-linux-gnu-pkg-config. > Use PKGCONF variable to detect the libdpdk availability. > > Signed-off-by: Jerin Jacob > --- +1 to the change, but on the commit log side, this looks more like a bugfix where the PKGCONF value is set too far down the file rather than adding a new feature. The support for overriding pkg-config is meant to be already there, and test-meson-builds.sh already sets PKGCONF in the environment to override it. /Bruce