From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BFDFA0A0C; Thu, 13 May 2021 11:59:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0DA54067E; Thu, 13 May 2021 11:59:21 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 71DB24003F for <dev@dpdk.org>; Thu, 13 May 2021 11:59:20 +0200 (CEST) IronPort-SDR: zCldrxPZtsCGiHILcstIGNVA6cXoSetFOPPV2v51PstK45cIJAxUMrg1Q15NZSsgUlGODGvtJL 2LBiqP5Il2TA== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="199965911" X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="199965911" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 02:59:18 -0700 IronPort-SDR: BHR/g6JH7wc/JI1O6/Vb3uNuRxEatp9FSeJpQzfW2Qa3f2pQqZgEb1Bt6OO5JiMZg8D/3eqCQV 8G4d6L9lfXaQ== X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="400870444" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.207]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 May 2021 02:59:12 -0700 Date: Thu, 13 May 2021 10:59:07 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com> Cc: Heinrich Kuhn <heinrich.kuhn@netronome.com>, dev@dpdk.org, "Chaoyong.He" <chaoyong.he@corigine.com>, Simon Horman <simon.horman@netronome.com>, konstantin.ananyev@intel.com Message-ID: <YJz4a6T4GF5iswIh@bricha3-MOBL.ger.corp.intel.com> References: <20210510165319.9153-1-heinrich.kuhn@netronome.com> <YJwDBht4I8pEIatX@bricha3-MOBL.ger.corp.intel.com> <fc0e7fac-6141-cbc8-4527-11f70efbcfeb@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <fc0e7fac-6141-cbc8-4527-11f70efbcfeb@intel.com> Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: change mq-mode on single queue devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, May 12, 2021 at 09:43:57PM +0300, Medvedkin, Vladimir wrote: > Hi Bruce, > > On 12/05/2021 19:32, Bruce Richardson wrote: > > On Mon, May 10, 2021 at 06:53:19PM +0200, Heinrich Kuhn wrote: > > > From: "Chaoyong.He" <chaoyong.he@corigine.com> > > > > > > Set the Rx multi-queue mode to NONE when configuring a port that is > > > associated with hardware that only supports a single Rx queue. > > > > > > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com> > > > Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com> > > > Signed-off-by: Simon Horman <simon.horman@netronome.com> > > > --- > > > examples/l3fwd/main.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > > > index bb49e5faf..87b638ac0 100644 > > > --- a/examples/l3fwd/main.c > > > +++ b/examples/l3fwd/main.c > > > @@ -953,6 +953,10 @@ l3fwd_poll_resource_setup(void) > > > local_port_conf.rx_adv_conf.rss_conf.rss_hf &= > > > dev_info.flow_type_rss_offloads; > > > + > > > + if (dev_info.max_rx_queues == 1) > > > + local_port_conf.rxmode.mq_mode = ETH_MQ_RX_NONE; > > > + > > > > While it makes sense to do this when the port only supports a single queue, > > would it not also make sense to do this when the requested queues are 1 > > too? > > > > Adding some lookup library maintainers on CC - I assume that the RSS value > > is not actually used for lookup anywhere in l3fwd. > > > > As far as I can see the rss hash value is not used anywhere in l3fwd. In > LPM/FIB this is not required at all, in EM CRC or Jenkins hash is used. > That's what I thought from looking at the code too. Since this is not really a bug fix, I think it can be pushed till 21.08. With or without the change I suggest above: Acked-by: Bruce Richardson <bruce.richardson@intel.com>