From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B67AFA0C46; Wed, 9 Jun 2021 13:02:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71B7E4069B; Wed, 9 Jun 2021 13:02:37 +0200 (CEST) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id CA5914003C for ; Wed, 9 Jun 2021 13:02:36 +0200 (CEST) Received: by mail-pg1-f178.google.com with SMTP id e22so19109102pgv.10 for ; Wed, 09 Jun 2021 04:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QI4vPfxepg2TEFE61fdx6dQP7Dj3QZFdnpi2WMGJuPE=; b=sEZXls+9UQbJs8CfbG3wLWpd8grkZrG1iLwc6wZyyBilPTZo5qGyti+xS5pXWb3qX/ kCuotzMYprTDSJ7aHzZDkiXBlkDmT9isbFktho7MVfeMzMyPOwwI5EDEsfnwslQxtLMm cbZgi8XmMsLuie0UitpA9rOSjJb8MnMYup0kg5kaxyH3rBGDZu30Q7Abi+S1YWjhY1HR yioZmCCYpCBgVpC2lUPxyA0zgNExDveEsHl/zTADIt5pPScv0eClOnjIbpk0zMSENgXA MnyWjViMz7h1ojIUdylCcjy2qzt6gKg8OR59aLX/kKCaGUUjr9mrlSzMX9IqX+cG2755 I1YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QI4vPfxepg2TEFE61fdx6dQP7Dj3QZFdnpi2WMGJuPE=; b=roNQ9fADpwWEjI8FYKgQHnEVgp6RjLA0I7CSz5xbEJYONk1wkAPDME1yCq5i9+D0Tj VzhlYdb6plOF8rWvW/mjtnjdxEvjBazn5jD0CdadRGrCRJ+SLRMHPvGOR9JJh9In5L4d 7m7hFQdzc149iUNs20yS1B3FKMJsVY/w4KSZU39+wU0i7FWO6DMJe1ZIvLzzaUtZavTS 41R56n/wCen+DtcYGV2OH40Su+tQJfyPyqg/KgH0mDeKgg7GGmq6ixFKssiT1zCyiX0c XBtU8fB8elryMchvkwm8CEXZEUUdAjLqEYux2Wi9WnUc/VH5uuQd4ufLfE5rMKYdzb+p OwXQ== X-Gm-Message-State: AOAM533NYwo31ox3Fm+wJ98tVnL3/sY74SMZJMuJGuCA6GBnl2yhI59m +NcHee0J6CP+gQ4LRurgCDQ= X-Google-Smtp-Source: ABdhPJzuvtbXcee4L1zXp35atQ73q6RnQjn5cBbXVc7XN2TmnZzddv91NSNMVDAsBf4KR8PtKQRc0Q== X-Received: by 2002:a63:2125:: with SMTP id h37mr3214869pgh.205.1623236555863; Wed, 09 Jun 2021 04:02:35 -0700 (PDT) Received: from gmail.com ([1.6.215.26]) by smtp.gmail.com with ESMTPSA id 11sm13076391pfh.182.2021.06.09.04.02.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Jun 2021 04:02:35 -0700 (PDT) Date: Wed, 9 Jun 2021 16:32:09 +0530 From: Nithin Dabilpuram To: Andrew Rybchenko Cc: dev@dpdk.org, jerinj@marvell.com, skori@marvell.com, skoteshwar@marvell.com, pbhagavatula@marvell.com, kirankumark@marvell.com, psatheesh@marvell.com, asekhar@marvell.com, Srujana Challa Message-ID: References: <20210306153404.10781-1-ndabilpuram@marvell.com> <20210607175943.31690-1-ndabilpuram@marvell.com> <20210607175943.31690-3-ndabilpuram@marvell.com> <9ffa7ba0-e506-4c31-284a-c9bc6238e6d5@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ffa7ba0-e506-4c31-284a-c9bc6238e6d5@oktetlabs.ru> Subject: Re: [dpdk-dev] [PATCH v2 02/62] common/cnxk: update Rx inline IPsec mbox message format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 08, 2021 at 03:26:08PM +0300, Andrew Rybchenko wrote: > On 6/7/21 8:58 PM, Nithin Dabilpuram wrote: > > From: Srujana Challa > > > > Updates Rx inline IPSEC mailbox message format to make it > > sync with latest CPT PF driver. > > > > Signed-off-by: Srujana Challa > > --- > > drivers/common/cnxk/roc_mbox.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h > > index f6b11b6..fe4df21 100644 > > --- a/drivers/common/cnxk/roc_mbox.h > > +++ b/drivers/common/cnxk/roc_mbox.h > > @@ -1328,6 +1328,9 @@ struct cpt_rxc_time_cfg_req { > > struct cpt_rx_inline_lf_cfg_msg { > > struct mbox_msghdr hdr; > > uint16_t __io sso_pf_func; > > + uint16_t __io param1; > > + uint16_t __io param2; > > + uint16_t __io reserved; > > }; > > > > enum cpt_eng_type { > > > > Isn't is a dead code? > May be it should be added when it is actually used? This patch is just a sync of this data structure b/w Kernel and Userspace used for mbox communication. It is already used to generate mbox message request response API's via and drivers/common/cnxk/roc_mbox_priv.h:158 for all mbox messages. Since it is common code and just a datastructure update to be in sync with kernel, isn't it fine ?