From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3E75A0C4E; Thu, 10 Jun 2021 11:22:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60EEF4067C; Thu, 10 Jun 2021 11:22:29 +0200 (CEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id 1256C4003C for ; Thu, 10 Jun 2021 11:22:28 +0200 (CEST) Received: by mail-wm1-f46.google.com with SMTP id m3so506652wms.4 for ; Thu, 10 Jun 2021 02:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DLamTi9zYZXWQovr5BtKJydxb8U/YwWs0+Q41ZSArO0=; b=OoFYwXqy50ffwkVvv3XLl/z2nMY50kJzyj/fcfW7xVuSpJLTfQjxe8goBPJCITs9fD T52zcuv62Qb7uecMqDA9OiJCHuNZ2r+vBqCBbpKge5re8uibx5yeJSBFdwPWiQzM5Gvi oBO6f0+wlWgofgF6zgw7lZ/4RwbOnYhJB5rWKizn9g+l+OK7JPVvEZOX2ae63nQD951d y4j61YfammE571toMXLf53o+WR4dktPFwJzoXwRa0HehWS9p6Jb885EAjDR03yxhkra7 qxA/xX1d0a8xBIUgnjdE2khhVkRABw7Hlep0e1xeA8WhuiwgN6hoA18OdBHYzULZnJWX +dHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DLamTi9zYZXWQovr5BtKJydxb8U/YwWs0+Q41ZSArO0=; b=dyvuwaRO1FE702N2s7hKfM/2KjjAD/ncn6ny6krH4on7X50eLW5WhPgvpgjaoLKNpB kZ+iJQ2ixV/LkguLRoGU++NR6l2utn2ilpY4WL890ONSQNsL30+DE1VEudp1jxPdaVG9 R6cTmy2sDYCCpr+JP3sB7qnHX8xrteojBxcJHpQTDInBwxHd1qOdUnIUP7XY1665HqX4 ZLrljKHoY04O1hsdomLJH8s0kRXjEda8lc+SIycvOXvPAjYagtZnM8rmacnJgNZJvWHM U4o2qLn147YYEk2oCud7nEIn4XMVGMopbCMBUdeqaordQRekI5yh05y3EKmXAXRalW0k Vu6w== X-Gm-Message-State: AOAM532V4v6kbSH+UdnleOJAKu3OCiFQbs/Z9Xgj4DAisa9/E4SG+IZ5 2QlFA/h4HV5+TcSojyquaK28qQ== X-Google-Smtp-Source: ABdhPJy4O7JuT6fbFpAg1suR8gTJhU3M7Y8u5rlEZcTuV/wL0/x+fuyeNhzPqsf6WnRABJ2+M0CEbg== X-Received: by 2002:a05:600c:22cf:: with SMTP id 15mr4096312wmg.144.1623316947795; Thu, 10 Jun 2021 02:22:27 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id b10sm2243292wrx.57.2021.06.10.02.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 02:22:27 -0700 (PDT) Date: Thu, 10 Jun 2021 11:22:26 +0200 From: Olivier Matz To: Gregory Etelson Cc: "Iremonger, Bernard" , Morten =?iso-8859-1?Q?Br=F8rup?= , "dev@dpdk.org" , Matan Azrad , Ori Kam , Raslan Darawsheh , Asaf Penso Message-ID: References: <20210527152858.13312-1-getelson@nvidia.com> <98CBD80474FA8B44BF855DF32C47DC35C617E2@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35C617E6@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Gregory, On Thu, Jun 10, 2021 at 04:10:25AM +0000, Gregory Etelson wrote: > Hello, > > There was no activity that patch for a long time. > The patch is marked as failed, but we verified failed tests and concluded that the failures can be ignored. > https://patchwork.dpdk.org/project/dpdk/patch/20210527152858.13312-1-getelson@nvidia.com/ > How should I proceed with this case ? > Please advise. > I like the idea of this patch: to me it is more convenient to access to these fields with a bitfield. I don't see a problem about using bitfields here, glibc or FreeBSD netinet/ip.h are doing the same. However, as stated previously, this patch breaks the initialization API. The DPDK ABI/API policy is described here: http://doc.dpdk.org/guides/contributing/abi_policy.html#the-dpdk-abi-policy >From this document: The API should only be changed for significant reasons, such as performance enhancements. API breakages due to changes such as reorganizing public structure fields for aesthetic or readability purposes should be avoided. So to follow the project policy, I think we should reject this path. Regards, Olivier