From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C6B3A0C42; Fri, 11 Jun 2021 15:22:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9BE44067C; Fri, 11 Jun 2021 15:22:07 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 9D5424014F for ; Fri, 11 Jun 2021 15:22:05 +0200 (CEST) IronPort-SDR: gCPdtuECCBwZirahFJQ9+yKMONMY/UfPvloN4G9eAxj2PhH/E3dI/e90gey9mF8kj8HUf/YzGw pC412V04aaUQ== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="205339537" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="205339537" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 06:22:04 -0700 IronPort-SDR: TQCH147LxASYTltjSyO6yZQIFjpFsnGXlbEgItoCP8lmjCjO176GkPba+8iscztwdJKbDOZj71 ecRIAYSu7nMw== X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="449106866" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.39]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Jun 2021 06:22:02 -0700 Date: Fri, 11 Jun 2021 14:21:59 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Andrew Rybchenko , "Li, Xiaoyun" , "dev@dpdk.org" Message-ID: References: <20210527162452.1568351-1-andrew.rybchenko@oktetlabs.ru> <1f419fbb-b951-1a84-3329-97701c32c956@oktetlabs.ru> <87dd3fd0-9dab-8079-d135-50d966d6a5cd@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87dd3fd0-9dab-8079-d135-50d966d6a5cd@intel.com> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: send failure logs to stderr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 11, 2021 at 11:35:59AM +0100, Ferruh Yigit wrote: > On 6/11/2021 10:19 AM, Andrew Rybchenko wrote: > > On 6/11/21 5:06 AM, Li, Xiaoyun wrote: > >> Hi > >> -----Original Message----- > >> From: Andrew Rybchenko > >> Sent: Friday, May 28, 2021 00:25 > >> To: Li, Xiaoyun > >> Cc: dev@dpdk.org > >> Subject: [PATCH] app/testpmd: send failure logs to stderr > >> > >> Running with stdout suppressed or redirected for further processing is very confusing in the case of errors. > >> > >> Signed-off-by: Andrew Rybchenko > >> --- > >> > >> This patch looks good to me. > >> But what do you think about make it as a fix and backport to stable branches? > >> Anyway works for me. > > > > I have no strong opinion on the topic. > > > > @Ferruh, what do you think? > > > > Same here, no strong opinion. > Sending errors to 'stderr' looks correct thing to do, but changing behavior in > the LTS may cause some unexpected side affect, if it is scripted and testpmd > output is parsed etc... For this possibility I would wait for the next LTS. > There are really 3 options, though: * apply and backport * apply now * apply only to next LTS I would tend to support the middle option, because sending errors to stderr is the right thing to do as you say, and I don't think we need to wait for next LTS to make the change. However, since we don't want to change behaviour in the older LTS's, I'd suggest not backporting. /Bruce