From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 889E0A0C4B; Thu, 17 Jun 2021 16:20:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60EB44069C; Thu, 17 Jun 2021 16:20:43 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id BECCA40150; Thu, 17 Jun 2021 16:20:41 +0200 (CEST) IronPort-SDR: cAN5XHDxnWgBgOa66StJGtBxyMESxoT+2Ksoy+pgDjuXSTuqX4HsnYryjtNRso+GxWRIrutg3v AQ1/h7d2g8wQ== X-IronPort-AV: E=McAfee;i="6200,9189,10017"; a="206332023" X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="206332023" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 07:20:40 -0700 IronPort-SDR: l8x5ZYTg5GM5VLGsPWZbdoLXwIfJuwsL9Kddia7alnSL1XSShqKePx+L4EwaUoHTBBgB8jHQ2U bW47RYlWWFyw== X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="404951223" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.26]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 17 Jun 2021 07:20:39 -0700 Date: Thu, 17 Jun 2021 15:20:35 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org, stable@dpdk.org Message-ID: References: <20210617141752.93312-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617141752.93312-1-kevin.laatz@intel.com> Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix memory leak in device configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 17, 2021 at 02:17:52PM +0000, Kevin Laatz wrote: > During device configure, memory is allocated for "hdl_ring_flags". In the > event of another call to the device configure function (reconfigure), a > memory leak would occur. This patch fixes the memory leak by free'ing the > memory before reallocating it. > > Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs") > > Signed-off-by: Kevin Laatz > --- Thanks, Kevin. Acked-by: Bruce Richardson