From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2FDFA0C4B; Thu, 17 Jun 2021 16:21:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C37D9410E4; Thu, 17 Jun 2021 16:21:29 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 14B1940150; Thu, 17 Jun 2021 16:21:27 +0200 (CEST) IronPort-SDR: 2WN9ZzJxcfnYWLQDRXr2Nik5Yga075FsOYX6IIw7azK7dm7L8rg3BgqY8WfeGd9oeXXT89k9du Xs/GlGtQ5kiA== X-IronPort-AV: E=McAfee;i="6200,9189,10017"; a="206415122" X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="206415122" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 07:21:27 -0700 IronPort-SDR: KOW7mO8aLqYE5b3TATX+Gd8Mm5K1CJ19B9/raSEU3ZK1PGz3Xp63hun77uWXP8V8GOv8JLe/DU nXW2/vG/La7Q== X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="404951452" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.26]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 17 Jun 2021 07:21:26 -0700 Date: Thu, 17 Jun 2021 15:21:22 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org, stable@dpdk.org Message-ID: References: <20210617141815.93367-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617141815.93367-1-kevin.laatz@intel.com> Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix missing ring pointer reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 17, 2021 at 02:18:15PM +0000, Kevin Laatz wrote: > In the event of a device reconfigure, "hdls_avail" is not being reset. This > can lead to miscalculations in rte_ioat_completed_ops(), causing the > function to report an incorrect amount of completed operations. This patch > fixes the issue by resetting "hdls_avail" during the device configure. > > Fixes: 74464005a2af ("raw/ioat: rework SW ring layout") > > Signed-off-by: Kevin Laatz > --- To catch more of these reconfigure issues, we should look to add an appropriate unit test. Acked-by: Bruce Richardson