From: Bruce Richardson <bruce.richardson@intel.com>
To: Luca Boccassi <bluca@debian.org>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
dev@dpdk.org, Rob Scheepens <rob.scheepens@nutanix.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix build on Windows with meson 0.58
Date: Thu, 1 Jul 2021 10:57:49 +0100 [thread overview]
Message-ID: <YN2RnUKPxn73X+67@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <57d6b6a0808b899e6b23cd204a1018d519326fd0.camel@debian.org>
On Thu, Jul 01, 2021 at 09:34:04AM +0100, Luca Boccassi wrote:
> On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote:
> > The `doc` target used `echo` as its command.
> > On Windows, `echo` is always a shell built-in, there is no binary.
> > Starting from meson 0.58, `run_target()` always searches for command
> > executable and no longer accepts `echo` as such on Windows.
> > Replace plain `echo` with a Python one-liner.
> >
> > Fixes: d02a2dab2dfb ("doc: support building HTML guides with meson")
> > Cc: Bruce Richardson <bruce.richardson@intel.com>
> > Cc: Luca Boccassi <bluca@debian.org>
> > Cc: stable@dpdk.org
> >
> > Reported-by: Rob Scheepens <rob.scheepens@nutanix.com>
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
>
> Acked-by: Luca Boccassi <bluca@debian.org>
One small suggestion might be to move the "echo" command definition to
buildtools folder in case it's wanted for use anywhere in the build at some
point in the future. However, this patch is fine without that change too.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2021-07-01 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 16:22 Dmitry Kozlyuk
2021-07-01 8:34 ` Luca Boccassi
2021-07-01 9:57 ` Bruce Richardson [this message]
2021-07-09 12:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN2RnUKPxn73X+67@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=rob.scheepens@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).