From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98B59A0C41; Tue, 22 Jun 2021 11:20:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10B474003F; Tue, 22 Jun 2021 11:20:00 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 1042D4003C for ; Tue, 22 Jun 2021 11:19:57 +0200 (CEST) IronPort-SDR: uD7SGc2AWoUpGxA4d2zHXnOltu1G0PN+Yhhjm8oy3RbPMZuYbYvUEsLXirNl6blRWwDXHIKrvQ zUMbc0vjkV5g== X-IronPort-AV: E=McAfee;i="6200,9189,10022"; a="204009796" X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="204009796" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 02:19:55 -0700 IronPort-SDR: BdZ1zRMqUlAKjfQBxKalGkKqahzsarqe8gs9bFUc4Js1I8Orf9/1Nrj3LqlyHHN0BZMuwtGCyg tEpUZML12nKw== X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="452543130" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.16.221]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 22 Jun 2021 02:19:52 -0700 Date: Tue, 22 Jun 2021 10:19:47 +0100 From: Bruce Richardson To: Feifei Wang Cc: dev@dpdk.org, nd@arm.com, Phil Yang , Juraj =?utf-8?Q?Linke=C5=A1?= , Ruifeng Wang Message-ID: References: <20210601015653.14499-1-feifei.wang2@arm.com> <20210601015653.14499-2-feifei.wang2@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210601015653.14499-2-feifei.wang2@arm.com> Subject: Re: [dpdk-dev] [PATCH v1 1/2] devtools: add relative path support for ABI compatibility check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 01, 2021 at 09:56:52AM +0800, Feifei Wang wrote: > From: Phil Yang > > Because dpdk guide does not limit the relative path for ABI > compatibility check, users maybe set 'DPDK_ABI_REF_DIR' as a relative > path: > > ~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=build-gcc-shared > ./test-meson-builds.sh > > And if the DESTDIR is not an absolute path, ninja complains: > + install_target build-gcc-shared/v19.11/build build-gcc-shared/v19.11/build-gcc-shared > + rm -rf build-gcc-shared/v19.11/build-gcc-shared > + echo 'DESTDIR=build-gcc-shared/v19.11/build-gcc-shared ninja -C build-gcc-shared/v19.11/build install' > + DESTDIR=build-gcc-shared/v19.11/build-gcc-shared > + ninja -C build-gcc-shared/v19.11/build install > ... > ValueError: dst_dir must be absolute, got build-gcc-shared/v19.11/build-gcc-shared/usr/local/share/dpdk/ > examples/bbdev_app > ... > Error: install directory 'build-gcc-shared/v19.11/build-gcc-shared' does not exist. > > To fix this, add relative path support using 'readlink -f'. > > Signed-off-by: Phil Yang > Signed-off-by: Feifei Wang > Reviewed-by: Juraj Linkeš > Reviewed-by: Ruifeng Wang > --- > devtools/test-meson-builds.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index daf817ac3e..43b906598d 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -168,7 +168,8 @@ build () # [meson options] > config $srcdir $builds_dir/$targetdir $cross --werror $* > compile $builds_dir/$targetdir > if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then > - abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION > + abirefdir=$(readlink -f \ > + ${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION) > if [ ! -d $abirefdir/$targetdir ]; then > # clone current sources > if [ ! -d $abirefdir/src ]; then This looks a simple enough change. Acked-by: Bruce Richardson