From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02383A0A0C; Tue, 29 Jun 2021 13:28:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E5314117C; Tue, 29 Jun 2021 13:28:50 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 5E8BE40E01 for ; Tue, 29 Jun 2021 13:28:48 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="188506907" X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="188506907" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 04:28:47 -0700 X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="447003091" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.18.210]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 29 Jun 2021 04:28:44 -0700 Date: Tue, 29 Jun 2021 12:28:40 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: thomas@monjalon.net, david.marchand@redhat.com, Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, ferruh.yigit@intel.com, jerinjacobk@gmail.com, dev@dpdk.org Message-ID: References: <1618827522-31828-1-git-send-email-juraj.linkes@pantheon.tech> <1624964105-6525-1-git-send-email-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1624964105-6525-1-git-send-email-juraj.linkes@pantheon.tech> Subject: Re: [dpdk-dev] [PATCH v4] build: optional NUMA and cpu counts detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 29, 2021 at 12:55:05PM +0200, Juraj Linkeš wrote: > Add an option to automatically discover the host's numa and cpu counts > and use those values for a non cross-build. > Give users the option to override the per-arch default values or values > from cross files by specifying them on the command line with -Dmax_lcores > and -Dmax_numa_nodes. > > Signed-off-by: Juraj Linkeš > Reviewed-by: Honnappa Nagarahalli > --- Two very minor suggestions inline below. Acked-by: Bruce Richardson > > +max_lcores = get_option('max_lcores') > +if max_lcores == 'auto' Rather than "auto", would "detect" be a clearer name for this option value? > +option('max_lcores', type: 'string', value: 'default', description: > + 'Set maximum number of cores/threads supported by EAL. The default is different per-arch. Set to auto to detect the number of cores on the build machine.') > +option('max_numa_nodes', type: 'string', value: 'default', description: > + 'Set highest NUMA node supported by EAL. The default is different per-arch. Set to auto to detect the highest numa node on the build machine.') I'd put the explicit values of "default" and "auto"(or "detect") in quotes "" to make clear they are literal values.