From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4D2D0A0A0C;
	Mon,  5 Jul 2021 12:58:37 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0933F4068C;
	Mon,  5 Jul 2021 12:58:37 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by mails.dpdk.org (Postfix) with ESMTP id 4E6CB4003C
 for <dev@dpdk.org>; Mon,  5 Jul 2021 12:58:35 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10035"; a="294602532"
X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="294602532"
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 05 Jul 2021 03:58:34 -0700
X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="485465495"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.23.142])
 by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 05 Jul 2021 03:58:32 -0700
Date: Mon, 5 Jul 2021 11:58:29 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Power, Ciara" <ciara.power@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>
Message-ID: <YOLl1flS83WizYFP@bricha3-MOBL.ger.corp.intel.com>
References: <20210702152305.606933-1-bruce.richardson@intel.com>
 <MN2PR11MB3821C51AD37E49DCAADE6520E61C9@MN2PR11MB3821.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MN2PR11MB3821C51AD37E49DCAADE6520E61C9@MN2PR11MB3821.namprd11.prod.outlook.com>
Subject: Re: [dpdk-dev] [PATCH 21.11] telemetry: remove experimental tags
 from APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jul 05, 2021 at 11:09:38AM +0100, Power, Ciara wrote:
> 
> 
> >-----Original Message-----
> >From: Richardson, Bruce <bruce.richardson@intel.com>
> >Sent: Friday 2 July 2021 16:23
> >To: dev@dpdk.org
> >Cc: Ray Kinsella <mdr@ashroe.eu>; Power, Ciara <ciara.power@intel.com>;
> >Richardson, Bruce <bruce.richardson@intel.com>
> >Subject: [PATCH 21.11] telemetry: remove experimental tags from APIs
> >
> >The telemetry APIs have been present and unchanged for >1 year now, so
> >remove experimental tag from them.
> >
> >Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >---
> > lib/telemetry/rte_telemetry.h | 18 ------------------
> > lib/telemetry/version.map     |  2 +-
> > 2 files changed, 1 insertion(+), 19 deletions(-)
> >
> <snip>
> 
> Hi Bruce,
> 
> +1 for this change.
> 
> I think there are some experimental tags missing from this patch - the legacy telemetry functions that are in "metrics/rte_metrics_telemetry.h" currently have the tags too.

I'm not sure about making those part of the stable ABI.

> Also, there is a reference to the library being experimental in the Telemetry User Guide doc.
> 
I missed checking the "howto" doc on telemetry, yes. I'll include that in a
v2.