From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13FFAA0C47; Tue, 6 Jul 2021 12:02:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A5D741262; Tue, 6 Jul 2021 12:02:25 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id D1AC94120E for ; Tue, 6 Jul 2021 12:02:23 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="209042538" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="209042538" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 03:02:22 -0700 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="647262247" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.23.242]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 Jul 2021 03:02:18 -0700 Date: Tue, 6 Jul 2021 11:02:15 +0100 From: Bruce Richardson To: fengchengwen Cc: Andrew Rybchenko , thomas@monjalon.net, ferruh.yigit@intel.com, jerinj@marvell.com, jerinjacobk@gmail.com, dev@dpdk.org, mb@smartsharesystems.com, nipun.gupta@nxp.com, hemant.agrawal@nxp.com, maxime.coquelin@redhat.com, honnappa.nagarahalli@arm.com, david.marchand@redhat.com, sburla@marvell.com, pkapoor@marvell.com, konstantin.ananyev@intel.com, liangma@liangbit.com Message-ID: References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <9b771d4d-5b63-4cc5-f063-27995ff33de3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b771d4d-5b63-4cc5-f063-27995ff33de3@huawei.com> Subject: Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 06, 2021 at 11:56:03AM +0800, fengchengwen wrote: > Many thanks, mostly OK, a few comment inline > > On 2021/7/4 22:57, Andrew Rybchenko wrote: > > On 7/2/21 4:18 PM, Chengwen Feng wrote: > >> This patch introduces 'dmadevice' which is a generic type of DMA > >> device. > > Do we really need both stats and xstats from the very > > beginning? I think it is better to start from just > > generic stats and add xstats when it is really required. > > OK, but I think we should add one dump ops, which could be useful to > find the problem. > +1 to both suggestions - dropping xstats (for now) and adding dump fn.