From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 088ADA0C50; Wed, 7 Jul 2021 15:59:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE515413B6; Wed, 7 Jul 2021 15:59:17 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 74195413A8 for ; Wed, 7 Jul 2021 15:59:16 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="273149777" X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="273149777" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2021 06:59:15 -0700 X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="491719784" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.4.148]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Jul 2021 06:59:13 -0700 Date: Wed, 7 Jul 2021 14:59:09 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: thomas@monjalon.net, david.marchand@redhat.com, Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, ferruh.yigit@intel.com, jerinjacobk@gmail.com, dev@dpdk.org Message-ID: References: <1625058550-9567-1-git-send-email-juraj.linkes@pantheon.tech> <1625564668-23695-1-git-send-email-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1625564668-23695-1-git-send-email-juraj.linkes@pantheon.tech> Subject: Re: [dpdk-dev] [PATCH v7] build: use platform for generic and native builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 06, 2021 at 11:44:28AM +0200, Juraj Linkeš wrote: > The current meson option 'machine' should only specify the ISA, which is > not sufficient for Arm, where setting ISA implies other settings as well > (and is used in Arm configuration as such). > Use the existing 'platform' meson option to differentiate the type of > the build (native/generic) and set ISA accordingly, unless the user > chooses to override it with a new option, 'cpu_instruction_set'. > The 'machine' option set the ISA in x86 builds and set native/default > 'build type' in aarch64 builds. These two new variables, 'platform' and > 'cpu_instruction_set', now properly set both ISA and build type for all > architectures in a uniform manner. > The 'machine' option also doesn't describe very well what it sets. The > new option, 'cpu_instruction_set', is much more descriptive. Keep > 'machine' for backwards compatibility. > > Signed-off-by: Juraj Linkeš Acked-by: Bruce Richardson