From: Bruce Richardson <bruce.richardson@intel.com>
To: John Levon <john.levon@nutanix.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/test: flush stdout after forking
Date: Mon, 26 Jul 2021 13:27:48 +0100 [thread overview]
Message-ID: <YP6qRE24ahRJxn/u@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20210726121627.2324730-1-john.levon@nutanix.com>
On Mon, Jul 26, 2021 at 01:16:27PM +0100, John Levon wrote:
> meson test was not capturing the intended output from the child
> process; force a flush to ensure it reaches the test log.
>
> Signed-off-by: John Levon <john.levon@nutanix.com>
> ---
> app/test/process.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test/process.h b/app/test/process.h
> index a09a088477..0ed91a939e 100644
> --- a/app/test/process.h
> +++ b/app/test/process.h
> @@ -110,6 +110,7 @@ process_dup(const char *const argv[], int numargs, const char *env_value)
> for (i = 0; i < num; i++)
> printf("'%s' ", argv_cpy[i]);
> printf("\n");
> + fflush(stdout);
>
I thought that "\n" normally flushes in most cases, but if explicit flush
is necessary for some cases, let's add it.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2021-07-26 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 12:16 John Levon
2021-07-26 12:27 ` Bruce Richardson [this message]
2021-07-26 12:33 ` John Levon
2021-07-31 17:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP6qRE24ahRJxn/u@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.levon@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).