From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 109B7A0C4B; Tue, 27 Jul 2021 14:53:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C604410F0; Tue, 27 Jul 2021 14:53:01 +0200 (CEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id B6CC5410ED for ; Tue, 27 Jul 2021 14:53:00 +0200 (CEST) Received: by mail-wr1-f50.google.com with SMTP id b9so14246064wrx.12 for ; Tue, 27 Jul 2021 05:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=L+a71Z4chNjt7t4vgXi7a2Mn/vR218QqVnhhNRBSUfw=; b=H5E0bPyddzd1s3iu6yboKzVDbKvKtSYFyVtdVmR1JcmKV/5m+NSGMKgmv0LLv110cj qeBCuSWA7yBU/h2I5iwB8TKwcCYFvf+FEdWe6YesTMQHYOQkRdw+mErrdODAEblEy32E PdGuLapSjm3w85oPfj+QdW2pRKMyl8bTceSp2s7WJmmJQ3qC/Ig5jYOhfzT2D57/d5Ya Feff3psKHyY9EY2rKBlYY2K0ePFnhRqu5BQCQa6DK8TGh13VZdkdQ7nf9J559ivaAC7/ X5ZsC5v+u4qqd30FhHhzgDDpAOq5Op1BB5ZRz0s4AbKVSmPtwf7ZrHIVQZIayyB1l6e8 KBpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L+a71Z4chNjt7t4vgXi7a2Mn/vR218QqVnhhNRBSUfw=; b=kBVrN4lJqFzYCZhitizvucLJI0/ogm4sO4dMkZGVYVQZasF4b5a5y+kD14PFaA0h7x zxHsyH13qRRUSA4EHiMiaC80CROzlQ17T8xynva9O8eaO3hLWi04oL6mmc7EGvI6JTpp bCg3qojlw1vNPrjRExqZuizlpOyy9D1Y6/bDXxXTlbJxSAYBCPtsWuHEmtjmYpjz2bKL A8aRSDSHrY8SKiqh66rVOYXccwvwaMUQMVpNNgSVRcf5dqktw/vX0AO+/t/VggKgutHg bLhJLhakJmQDMBCA1VFkxdTY6xnYqh2NxelNcdMV+yT3HEqNCBJ9eTujoErdOnH1SrxT FHqg== X-Gm-Message-State: AOAM533YiLi2SggoZNxykPQyKwAtYFup4h8dyUqFdESaWiuE9eiS1anS 92BnLp/XKP4vbb24CZ96LLexDw== X-Google-Smtp-Source: ABdhPJxXTejQJNYzKB9jDJziJdzRYzUo0g7I08ywgqadJvcP9JuzD+u9kgbGpSIa8rJJfKqt0LjV4Q== X-Received: by 2002:adf:e0c8:: with SMTP id m8mr24565148wri.261.1627390380378; Tue, 27 Jul 2021 05:53:00 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id m9sm1968135wrz.75.2021.07.27.05.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 05:52:59 -0700 (PDT) Date: Tue, 27 Jul 2021 14:52:58 +0200 From: Olivier Matz To: Thomas Monjalon Cc: Mohsin Kazmi , dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com, maxime.coquelin@redhat.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@intel.com Message-ID: References: <20210630110404.21209-1-mohsin.kazmi14@gmail.com> <20210707094019.40945-1-mohsin.kazmi14@gmail.com> <7265315.64hUE0sMR9@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7265315.64hUE0sMR9@thomas> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net: fix Intel-specific Prepare the outer ipv4 hdr for checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 22, 2021 at 09:56:25PM +0200, Thomas Monjalon wrote: > +Cc more people for reviews. > > 07/07/2021 11:40, Mohsin Kazmi: > > Preparation the headers for the hardware offload "of" is missing after Preparation? > > misses the outer ipv4 checksum offload. > > It results in bad checksum computed by hardware NIC. > > > > This patch fixes the issue by setting the outer ipv4 > > checksum field to 0. > > nit: please write "IPv4" here and below. > > > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Mohsin Kazmi > > Acked-by: Qi Zhang Acked-by: Olivier Matz