From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A248A0C47; Fri, 30 Jul 2021 10:39:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 146AC40040; Fri, 30 Jul 2021 10:39:23 +0200 (CEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id E8A434003E for ; Fri, 30 Jul 2021 10:39:21 +0200 (CEST) Received: by mail-wm1-f43.google.com with SMTP id m19so5476324wms.0 for ; Fri, 30 Jul 2021 01:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Oah56xYD8aF2NUn5yVBU1brZn09GalxFRcynf1kOvJs=; b=dkAhys/4z3nSuO1kJJg/8wwdWYn7rQNLFCiNBy2m43F4zJAONlk8eFwcM9dR2pIY26 OCij/vQqOSnEVTHhQrRLMXKmCbNAgvxrx/Dp5kJE2oaya6WOBIHqwx8g7xTC2l6Tsnqv hgxTy5kUDSxXWzAX0e6JYKv2LfEdjCJJzrXroz5pPMw0pyniNtLLYZCbcSTlNGj+XtU9 fj0tuBK6Upt4ZINT2z4JGf71XSk/QXBI4lfLf9oAYbxAxwPO5MG6sWlChyZPnMFpjB28 Qxml0td2I/G65zts88iLr8UTL65M9f2ent+6s1ccQeSa5I66f81RytySQsxuc78H8/u9 s3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Oah56xYD8aF2NUn5yVBU1brZn09GalxFRcynf1kOvJs=; b=ackM6Goaj2KbVcHRUcU93ezcbNvYxgQHS7JyGjDSvmFnlTI1E4/azu9jioj+ukuy0D BJ4Kwr5NwLMZuUzBf+io0d/GBq8IE2ilKQ5BI1jMH1m5RyYTE5VzXHuE9FpJgeXfqwPb papQMP7+oowSu7m4Rvy9qyZ/smjf7UIw4c+mhnPEEjY4LsICpiRRZpBNIpS/jZe5bS83 qAPsqZ2VIBwROZ1Ef25oWmNXUTOVgZakDmi6S889Da7kPtIn+wXTv7RvRlju/V3JdyAG uFr7Xarjs99CUBXYbrn/b8vo3qCQFeinJhprEUV/RkU3u3INtlCDQrZSBjt+Xxqiq067 Krvw== X-Gm-Message-State: AOAM531rSfS9hekykUeh9d2yhmLarJ939QatuvdL/0cB/lTPypJPlHex fIBiE5r3qPxO5yQwEA9hzjOCzw== X-Google-Smtp-Source: ABdhPJzORLh0NkEOpTKyL+DQshHCw/ysc0paHQvYVShjtdx7b8tqswVo5yPUZh/qb1+T9chsuIxJpw== X-Received: by 2002:a1c:a54b:: with SMTP id o72mr1832447wme.114.1627634361705; Fri, 30 Jul 2021 01:39:21 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id t15sm951115wrx.17.2021.07.30.01.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 01:39:21 -0700 (PDT) Date: Fri, 30 Jul 2021 10:39:20 +0200 From: Olivier Matz To: Gregory Etelson Cc: dev@dpdk.org, Ajit Khaparde , Andrew Rybchenko , Ferruh Yigit , Thomas Monjalon , stable@dpdk.org, Xiaoyun Li , Tomasz Kulasek , Konstantin Ananyev Message-ID: References: <20210719083309.15428-1-getelson@nvidia.com> <20210729170141.26563-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729170141.26563-1-getelson@nvidia.com> Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum calculation for tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 29, 2021 at 08:01:41PM +0300, Gregory Etelson wrote: > csumonly engine calculates TX checksum of a tunnelled packet for outer > headers only or separately for outer and inner headers. The > calculation method is determined by checksum configuration options. > If TX checksum calculation is separated, the inner headers are > processed before outer headers. > > Inner headers processing sets checksum values to 0 unconditionally. > If TX configuration offloads inner checksums only, outer checksum > calculation in software will read 0 instead of real values and > produce wrong result. > > The patch zeroes inner checksums only before software calculation. > > Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum engine") > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson Acked-by: Olivier Matz