DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec
@ 2021-07-27 17:36 Nithin Dabilpuram
  2021-07-30 19:06 ` Akhil Goyal
  2021-07-30 22:16 ` Thomas Monjalon
  0 siblings, 2 replies; 7+ messages in thread
From: Nithin Dabilpuram @ 2021-07-27 17:36 UTC (permalink / raw)
  To: konstantin.ananyev, jerinj, gakhil, roy.fan.zhang, hemant.agrawal, matan
  Cc: dev, Nithin Dabilpuram

Announce changes to make rte_security_set_pkt_metadata() and
rte_security_get_userdata() inline instead of C functions and
also addition of another field in structure rte_security_ctx for
holding flags.

Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---

- Series at  
  https://inbox.dpdk.org/dev/20210624102848.3878788-1-gakhil@marvell.com/T/#mc4ba3500c024f9911b7af7e5a6e95e23f6197fdd

 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 9584d6b..6a35c76 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,7 @@ Deprecation Notices
 * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific
   content. On Linux and FreeBSD, supported prior to DPDK 20.11,
   original structure will be kept until DPDK 21.11.
+
+* security: The functions ``rte_security_set_pkt_metadata`` and
+  ``rte_security_get_userdata`` will be made inline functions and additional
+  flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
-- 
2.8.4


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec
  2021-07-27 17:36 [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec Nithin Dabilpuram
@ 2021-07-30 19:06 ` Akhil Goyal
  2021-07-30 22:16 ` Thomas Monjalon
  1 sibling, 0 replies; 7+ messages in thread
From: Akhil Goyal @ 2021-07-30 19:06 UTC (permalink / raw)
  To: Nithin Kumar Dabilpuram, konstantin.ananyev,
	Jerin Jacob Kollanukkaran, roy.fan.zhang, hemant.agrawal, matan
  Cc: dev, Nithin Kumar Dabilpuram

> Announce changes to make rte_security_set_pkt_metadata() and
> rte_security_get_userdata() inline instead of C functions and
> also addition of another field in structure rte_security_ctx for
> holding flags.
> 
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec
  2021-07-27 17:36 [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec Nithin Dabilpuram
  2021-07-30 19:06 ` Akhil Goyal
@ 2021-07-30 22:16 ` Thomas Monjalon
  2021-08-03  2:11   ` Nithin Dabilpuram
  1 sibling, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2021-07-30 22:16 UTC (permalink / raw)
  To: konstantin.ananyev, jerinj, gakhil, roy.fan.zhang,
	hemant.agrawal, Nithin Dabilpuram
  Cc: matan, dev, ferruh.yigit, bruce.richardson, mdr, david.marchand

27/07/2021 19:36, Nithin Dabilpuram:
> Announce changes to make rte_security_set_pkt_metadata() and
> rte_security_get_userdata() inline instead of C functions and
> also addition of another field in structure rte_security_ctx for
> holding flags.

I guess there is a performance reason but the motivation
is not explained. Also it is going in the opposite direction
of what is discussed in the Technical Board meetings:
we should avoid and reduce the number of inline functions
to reduce the ABI surface.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec
  2021-07-30 22:16 ` Thomas Monjalon
@ 2021-08-03  2:11   ` Nithin Dabilpuram
  0 siblings, 0 replies; 7+ messages in thread
From: Nithin Dabilpuram @ 2021-08-03  2:11 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: konstantin.ananyev, jerinj, gakhil, roy.fan.zhang,
	hemant.agrawal, matan, dev, ferruh.yigit, bruce.richardson, mdr,
	david.marchand

On Sat, Jul 31, 2021 at 12:16:12AM +0200, Thomas Monjalon wrote:
> 27/07/2021 19:36, Nithin Dabilpuram:
> > Announce changes to make rte_security_set_pkt_metadata() and
> > rte_security_get_userdata() inline instead of C functions and
> > also addition of another field in structure rte_security_ctx for
> > holding flags.
> 
> I guess there is a performance reason but the motivation
> is not explained. Also it is going in the opposite direction
> of what is discussed in the Technical Board meetings:
> we should avoid and reduce the number of inline functions
> to reduce the ABI surface.

Yes, it is a performance improvement. It is discussed in detail in
https://inbox.dpdk.org/dev/20210624102848.3878788-1-gakhil@marvell.com/T/#mc4ba3500c024f9911b7af7e5a6e95e23f6197fdd

To summarize, initially the two per-pkt fast path API's rte_security_set_pkt_metadata()
and rte_security_get_userdata() where added with anticipation that PMD's would
have lot of processing to be done on per-pkt basis for security offload packets
unlike other ethdev Rx/Tx offloads. 

Now that we have few PMD's that implemented inline ipsec support, it looks more
benefitial to have PMD specific logic in tx_burst()/rx_burst() for
performance instead of doing a per-pkt function ptr jump to do the same in
rte_security_set_pkt_metadata() or rte_security_get_userdata(). 
In our PMD rte_security_set_pkt_metadata() is currently just to copy private SA ptr 
from rte_security_session to security mbuf dynamic field and rte_security_get_userdata()
is to copy userdata ptr from mbuf dynamic field.

Hence the above proposal provides an alternative to PMD's which want to avoid 
function ptr jump, by doing a simple metadata get/set to mbuf security dynamic
field apart from existing function ptr jump. 

Also, in future when there will be no PMD's that need the function ptr support
for the same operations, this new method can be made the only method and rest
of the function pointer jump logic can be removed probably without breaking ABI.

> 
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec
  2021-07-27 17:51 Nithin Dabilpuram
  2021-07-27 21:28 ` Ananyev, Konstantin
@ 2021-07-30  7:09 ` Hemant Agrawal
  1 sibling, 0 replies; 7+ messages in thread
From: Hemant Agrawal @ 2021-07-30  7:09 UTC (permalink / raw)
  To: Nithin Dabilpuram, konstantin.ananyev, jerinj, gakhil,
	roy.fan.zhang, matan
  Cc: dev

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec
  2021-07-27 17:51 Nithin Dabilpuram
@ 2021-07-27 21:28 ` Ananyev, Konstantin
  2021-07-30  7:09 ` Hemant Agrawal
  1 sibling, 0 replies; 7+ messages in thread
From: Ananyev, Konstantin @ 2021-07-27 21:28 UTC (permalink / raw)
  To: Nithin Dabilpuram, jerinj, gakhil, Zhang, Roy Fan, hemant.agrawal, matan
  Cc: dev



> Announce changes to make rte_security_set_pkt_metadata() and
> rte_security_get_userdata() inline instead of C functions and
> also addition of another field in structure rte_security_ctx for
> holding flags.
> 
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> 
> - Series at
>   https://inbox.dpdk.org/dev/20210624102848.3878788-1-gakhil@marvell.com/T/#mc4ba3500c024f9911b7af7e5a6e95e23f6197fdd
> 
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 9584d6b..6a35c76 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,7 @@ Deprecation Notices
>  * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific
>    content. On Linux and FreeBSD, supported prior to DPDK 20.11,
>    original structure will be kept until DPDK 21.11.
> +
> +* security: The functions ``rte_security_set_pkt_metadata`` and
> +  ``rte_security_get_userdata`` will be made inline functions and additional
> +  flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.8.4


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec
@ 2021-07-27 17:51 Nithin Dabilpuram
  2021-07-27 21:28 ` Ananyev, Konstantin
  2021-07-30  7:09 ` Hemant Agrawal
  0 siblings, 2 replies; 7+ messages in thread
From: Nithin Dabilpuram @ 2021-07-27 17:51 UTC (permalink / raw)
  To: konstantin.ananyev, jerinj, gakhil, roy.fan.zhang, hemant.agrawal, matan
  Cc: ndabilpuram, dev

Announce changes to make rte_security_set_pkt_metadata() and
rte_security_get_userdata() inline instead of C functions and
also addition of another field in structure rte_security_ctx for
holding flags.

Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---

- Series at  
  https://inbox.dpdk.org/dev/20210624102848.3878788-1-gakhil@marvell.com/T/#mc4ba3500c024f9911b7af7e5a6e95e23f6197fdd

 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 9584d6b..6a35c76 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,7 @@ Deprecation Notices
 * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific
   content. On Linux and FreeBSD, supported prior to DPDK 20.11,
   original structure will be kept until DPDK 21.11.
+
+* security: The functions ``rte_security_set_pkt_metadata`` and
+  ``rte_security_get_userdata`` will be made inline functions and additional
+  flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
-- 
2.8.4


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-08-03  2:11 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 17:36 [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec Nithin Dabilpuram
2021-07-30 19:06 ` Akhil Goyal
2021-07-30 22:16 ` Thomas Monjalon
2021-08-03  2:11   ` Nithin Dabilpuram
2021-07-27 17:51 Nithin Dabilpuram
2021-07-27 21:28 ` Ananyev, Konstantin
2021-07-30  7:09 ` Hemant Agrawal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).