From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26036A0C4C; Mon, 16 Aug 2021 12:56:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95E8540040; Mon, 16 Aug 2021 12:56:03 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id E4E0E4003C; Mon, 16 Aug 2021 12:56:01 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d17so20226827plr.12; Mon, 16 Aug 2021 03:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NRcadZtRlpEqgGRwrHghCpx5xjwfRGR7h4jEXFsOhXE=; b=g4vY2TIO749+A6qI+WUdzia1Ub944IIPuzBEEjyXjLn1J81jSqhcNvfLT1d0AueKSw WDznoPaAXXeZLvKUll7ag0nh4kD83wek7ml8dxZTWc1jHDgH9RW20UIZfz/l+3vB6JBX 6RfxsCW+Se9g3E7b5IWv9TDLh18HtLqWu6DyR7TT1kAKo5ZwtTfwC+ERNKlpH+heXOTa rXftXRs6GEyOMSN5EwaQKqs60dLFpdKbWuPNvdcvOSsNXGx76mRgCpTTJT0Gs8u3VoyU Y1XbKp6eHRieDgD8HbSJK0N+k8XrXLsEoGLjz06DOIQ42m64DW8EV61lC3JJ6Y2FKOi6 8DJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NRcadZtRlpEqgGRwrHghCpx5xjwfRGR7h4jEXFsOhXE=; b=XKf0S3Dc3temuuethMuXb/I0iQ6MHP3NcTfXKOiC24fwGwNojVNiINrZBryiR/kQFY UoBQpeNfSNum1fgwdOgFmw5BMw3JgInLwlGKJa7Dj6e38IKmEz3QVLj2OWq8ra/Q2C8b cQenkPR2NgF0UPXgg4aaYaLdj6Hlc3+rf/FI86fmB2lrZJIPxf3nNzGH+w16d/EMjCQ+ PT1LPEyf/7ym46qr7uGbyVISOhUjfhN1iMC9cLiuaNg2uZROzG2MfteeEAOqa40hRCnE l381xC1gP1LXXeAw1n3hLDFMAnVdqLbV8RhIRkYlSaRTrX20ByMn2HdlFlr5QDkzV2Oh nzoQ== X-Gm-Message-State: AOAM531jKkCHuPDpMWkmmNbC3YindeThnaFcl8sNCYAUSv/bGtlHkTeV eb6Ku8g7j7ADrySp6J2Dijo= X-Google-Smtp-Source: ABdhPJzBwcRxAt3jeFcHfHeVPpUWTzVAoazBx8cYL+vIElbE7zIvZf3Xi4M2kMv6RW0rRt43lI++WQ== X-Received: by 2002:a17:903:2c2:b029:101:9c88:d928 with SMTP id s2-20020a17090302c2b02901019c88d928mr12887899plk.62.1629111361041; Mon, 16 Aug 2021 03:56:01 -0700 (PDT) Received: from gmail.com ([1.6.215.26]) by smtp.gmail.com with ESMTPSA id w145sm11234236pfc.169.2021.08.16.03.55.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Aug 2021 03:56:00 -0700 (PDT) Date: Mon, 16 Aug 2021 16:25:32 +0530 From: Nithin Dabilpuram To: "Li, Xiaoyun" Cc: "jerinj@marvell.com" , "dev@dpdk.org" , "jia.guo@intel.com" , "stable@dpdk.org" Message-ID: References: <20210816070943.26807-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 16, 2021 at 08:48:20AM +0000, Li, Xiaoyun wrote: > Hi > > > -----Original Message----- > > From: Nithin Dabilpuram > > Sent: Monday, August 16, 2021 15:10 > > To: Li, Xiaoyun > > Cc: jerinj@marvell.com; dev@dpdk.org; Nithin Dabilpuram > > ; jia.guo@intel.com; stable@dpdk.org > > Subject: [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer > > chksum > > > > Donot use outer metadata when neither outer ip checksum nor outer udp > > checksum is enabled. PMD's will ignore the outer_l2_len and outer_l3_len in > > cases where none of the outer checksum is enabled and hence only l2_len and > > l3_len will be used to calculate the offsets for L2 or L3 header. > > I don't understand. > In process_outer_chksum, only PKT_TX_OUTER_IPV6 Will be set if it's ipv6 packets. > So PKT_TX_OUTER_IPV6 means this packet is tunnel ipv6 packet. So it actually needs outer l2 len and outer l3 len put them to hw. > At least i40e needs outer l2 len and outer l3 len as far as I know. Ok, do you mean m->outer_l2_len and m->outer_l3_len will be referred in i40e driver even when both DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM and DEV_TX_OFFLOAD_OUTER_UDP_CKSUM are not enabled in ethdev Tx offloads ? I thought as per spec, those fields will only be used when the Outer offloads are enabled. > > > > > Fixes: 3c32113a1aac ("app/testpmd: fix IPv6 tunnel checksum") > > Cc: jia.guo@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Nithin Dabilpuram > > --- > > app/test-pmd/csumonly.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index > > 607c889..38cc256 100644 > > --- a/app/test-pmd/csumonly.c > > +++ b/app/test-pmd/csumonly.c > > @@ -961,8 +961,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > > (tx_offloads & > > DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) || > > (tx_offloads & > > - DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) || > > - (tx_ol_flags & PKT_TX_OUTER_IPV6)) { > > + DEV_TX_OFFLOAD_OUTER_UDP_CKSUM)) { > > m->outer_l2_len = info.outer_l2_len; > > m->outer_l3_len = info.outer_l3_len; > > m->l2_len = info.l2_len; > > -- > > 2.8.4 >