From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7520A0548; Tue, 17 Aug 2021 14:29:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E6E0407FF; Tue, 17 Aug 2021 14:29:35 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 40E7B4014E for ; Tue, 17 Aug 2021 14:29:33 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="212946552" X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="212946552" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 05:29:32 -0700 X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="487990252" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.74]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 17 Aug 2021 05:29:27 -0700 Date: Tue, 17 Aug 2021 13:29:24 +0100 From: Bruce Richardson To: jerinj@marvell.com Cc: Andrew Rybchenko , Haiyue Wang , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Qiming Yang , Jiawen Wu , Harman Kalra , Rasesh Mody , Devendra Singh Rawat , Igor Russkikh , Maciej Czekaj , Jian Wang , Rosen Xu , Tianfei zhang , dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com Message-ID: References: <20210730052434.2627818-1-jerinj@marvell.com> <20210730073548.3596659-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210730073548.3596659-1-jerinj@marvell.com> Subject: Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 30, 2021 at 01:05:48PM +0530, jerinj@marvell.com wrote: > From: Jerin Jacob > > Since meson 0.59.0 version, the extract_all_objects() API > need to pass explicit boolean value. > > To remove the following warning[1], added explicit `true` for > extract_all_objects() use in codebase whever there is > no argument. > > [1] > WARNING: extract_all_objects called without setting recursive > keyword argument. Meson currently defaults to > non-recursive to maintain backward compatibility but > the default will be changed in the future. > Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct? > Signed-off-by: Jerin Jacob > --- > v2..v1 > - Corrrect the meson version number in git commit log(0.46.0 to 0.59.0) > > drivers/common/sfc_efx/base/meson.build | 2 +- > drivers/meson.build | 2 +- > drivers/net/e1000/base/meson.build | 2 +- > drivers/net/fm10k/base/meson.build | 2 +- > drivers/net/hinic/base/meson.build | 2 +- > drivers/net/i40e/base/meson.build | 2 +- > drivers/net/ice/base/meson.build | 2 +- > drivers/net/igc/base/meson.build | 2 +- > drivers/net/ixgbe/base/meson.build | 2 +- > drivers/net/ngbe/base/meson.build | 2 +- > drivers/net/octeontx/base/meson.build | 2 +- > drivers/net/qede/base/meson.build | 2 +- > drivers/net/thunderx/base/meson.build | 2 +- > drivers/net/txgbe/base/meson.build | 2 +- > drivers/raw/ifpga/base/meson.build | 2 +- > 15 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/common/sfc_efx/base/meson.build b/drivers/common/sfc_efx/base/meson.build > index 9fba47b1cc..ff7f33fb44 100644 > --- a/drivers/common/sfc_efx/base/meson.build > +++ b/drivers/common/sfc_efx/base/meson.build > @@ -86,7 +86,7 @@ if build > dependencies: static_rte_eal, > c_args: c_args) > > - base_objs = base_lib.extract_all_objects() > + base_objs = base_lib.extract_all_objects(recursive: true) > else > base_objs = [] > endif > diff --git a/drivers/meson.build b/drivers/meson.build > index bc6f4f567f..d9e331ec85 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -160,7 +160,7 @@ foreach subpath:subdirs > include_directories: includes, > dependencies: static_deps, > c_args: cflags) > - objs += tmp_lib.extract_all_objects() > + objs += tmp_lib.extract_all_objects(recursive: true) > sources = custom_target(out_filename, > command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen], > output: out_filename, > diff --git a/drivers/net/e1000/base/meson.build b/drivers/net/e1000/base/meson.build > index 317692dfab..528a33f958 100644 > --- a/drivers/net/e1000/base/meson.build > +++ b/drivers/net/e1000/base/meson.build > @@ -35,4 +35,4 @@ endforeach > base_lib = static_library('e1000_base', sources, > dependencies: static_rte_eal, > c_args: c_args) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/fm10k/base/meson.build b/drivers/net/fm10k/base/meson.build > index ca98d34d4e..bd19df27f7 100644 > --- a/drivers/net/fm10k/base/meson.build > +++ b/drivers/net/fm10k/base/meson.build > @@ -25,4 +25,4 @@ endforeach > base_lib = static_library('fm10k_base', sources, > dependencies: static_rte_eal, > c_args: c_args) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/hinic/base/meson.build b/drivers/net/hinic/base/meson.build > index a00c90c14e..3aa53df881 100644 > --- a/drivers/net/hinic/base/meson.build > +++ b/drivers/net/hinic/base/meson.build > @@ -34,4 +34,4 @@ c_args = cflags > base_lib = static_library('hinic_base', sources, > dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash], > c_args: c_args) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build > index 79a887a297..d94108629b 100644 > --- a/drivers/net/i40e/base/meson.build > +++ b/drivers/net/i40e/base/meson.build > @@ -27,4 +27,4 @@ endforeach > base_lib = static_library('i40e_base', sources, > dependencies: static_rte_eal, > c_args: c_args) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build > index 3305e5dd18..30e251876d 100644 > --- a/drivers/net/ice/base/meson.build > +++ b/drivers/net/ice/base/meson.build > @@ -43,4 +43,4 @@ endforeach > base_lib = static_library('ice_base', sources, > dependencies: static_rte_eal, > c_args: c_args) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/igc/base/meson.build b/drivers/net/igc/base/meson.build > index 8affc72e65..f52421f7a9 100644 > --- a/drivers/net/igc/base/meson.build > +++ b/drivers/net/igc/base/meson.build > @@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources, > dependencies: static_rte_eal, > c_args: cflags) > > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build > index 7d3cec002d..22972c6b56 100644 > --- a/drivers/net/ixgbe/base/meson.build > +++ b/drivers/net/ixgbe/base/meson.build > @@ -31,4 +31,4 @@ endforeach > base_lib = static_library('ixgbe_base', sources, > dependencies: static_rte_eal, > c_args: c_args) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/ngbe/base/meson.build b/drivers/net/ngbe/base/meson.build > index a1a9c2ff65..6081281135 100644 > --- a/drivers/net/ngbe/base/meson.build > +++ b/drivers/net/ngbe/base/meson.build > @@ -18,4 +18,4 @@ c_args = cflags > base_lib = static_library('ngbe_base', sources, > dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci], > c_args: c_args) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/octeontx/base/meson.build b/drivers/net/octeontx/base/meson.build > index c86a726704..8e5e8c1b55 100644 > --- a/drivers/net/octeontx/base/meson.build > +++ b/drivers/net/octeontx/base/meson.build > @@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources, > dependencies: static_objs, > ) > > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build > index 614a0c3808..4ad177b478 100644 > --- a/drivers/net/qede/base/meson.build > +++ b/drivers/net/qede/base/meson.build > @@ -54,4 +54,4 @@ endforeach > base_lib = static_library('qede_base', sources, > dependencies: [static_rte_net, static_rte_bus_pci], > c_args: c_args) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/thunderx/base/meson.build b/drivers/net/thunderx/base/meson.build > index 704ee65771..cec45d0ae1 100644 > --- a/drivers/net/thunderx/base/meson.build > +++ b/drivers/net/thunderx/base/meson.build > @@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources, > dependencies: static_rte_ethdev > ) > > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/net/txgbe/base/meson.build b/drivers/net/txgbe/base/meson.build > index c6816b4279..7a30191472 100644 > --- a/drivers/net/txgbe/base/meson.build > +++ b/drivers/net/txgbe/base/meson.build > @@ -24,4 +24,4 @@ endforeach > base_lib = static_library('txgbe_base', sources, > dependencies: static_rte_eal, > c_args: c_args) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > diff --git a/drivers/raw/ifpga/base/meson.build b/drivers/raw/ifpga/base/meson.build > index 8d27c60213..db602cee69 100644 > --- a/drivers/raw/ifpga/base/meson.build > +++ b/drivers/raw/ifpga/base/meson.build > @@ -40,4 +40,4 @@ ext_deps += rtdep > base_lib = static_library('ifpga_rawdev_base', sources, > dependencies: static_rte_eal, > c_args: cflags) > -base_objs = base_lib.extract_all_objects() > +base_objs = base_lib.extract_all_objects(recursive: true) > -- > 2.32.0 >