From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BBC9A0C4D; Wed, 1 Sep 2021 11:59:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FE4440140; Wed, 1 Sep 2021 11:59:18 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 2C9354013F for ; Wed, 1 Sep 2021 11:59:15 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10093"; a="198936040" X-IronPort-AV: E=Sophos;i="5.84,369,1620716400"; d="scan'208";a="198936040" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2021 02:59:15 -0700 X-IronPort-AV: E=Sophos;i="5.84,369,1620716400"; d="scan'208";a="532063432" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.0.231]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Sep 2021 02:59:13 -0700 Date: Wed, 1 Sep 2021 10:59:09 +0100 From: Bruce Richardson To: Conor Walsh Cc: ciara.power@intel.com, keith.wiles@intel.com, dev@dpdk.org, Zhihong Peng , Conor Fogarty Message-ID: References: <20210901093847.2269921-1-conor.walsh@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210901093847.2269921-1-conor.walsh@intel.com> Subject: Re: [dpdk-dev] [PATCH] eal: fix memory leak when saving arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 01, 2021 at 09:38:47AM +0000, Conor Walsh wrote: > This patch fixes a memleak which was reported in Bugzilla within the > eal_save_args function. This was caused by the function mistakenly > adding -- to the eal args instead of breaking beforehand. > > Bugzilla ID: 722 > Fixes: 293c53d8b23c ("eal: add telemetry callbacks") > > Reported-by: Zhihong Peng > Signed-off-by: Conor Walsh > Signed-off-by: Conor Fogarty > --- Acked-by: Bruce Richardson