From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 328D7A0548; Thu, 26 Aug 2021 20:06:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F8AD41233; Thu, 26 Aug 2021 20:06:45 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 2C48241228 for ; Thu, 26 Aug 2021 20:06:42 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10088"; a="217527517" X-IronPort-AV: E=Sophos;i="5.84,354,1620716400"; d="scan'208";a="217527517" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 11:06:39 -0700 X-IronPort-AV: E=Sophos;i="5.84,354,1620716400"; d="scan'208";a="516884301" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.14.33]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Aug 2021 11:06:36 -0700 Date: Thu, 26 Aug 2021 19:06:33 +0100 From: Bruce Richardson To: Gowrishankar Muthukrishnan Cc: dev@dpdk.org, ciara.power@intel.com, thomas@monjalon.net, jerinj@marvell.com, kirankumark@marvell.com, ndabilpuram@marvell.com, skori@marvell.com, skoteshwar@marvell.com Message-ID: References: <0a4a33e9c3cf4b5739a7edceedfd16435da94a59.1629997400.git.gmuthukrishn@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a4a33e9c3cf4b5739a7edceedfd16435da94a59.1629997400.git.gmuthukrishn@marvell.com> Subject: Re: [dpdk-dev] [v4, 1/2] common/cnxk: add telemetry endpoints to npa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 26, 2021 at 10:45:10PM +0530, Gowrishankar Muthukrishnan wrote: > Add telemetry endpoints to npa. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > drivers/common/cnxk/cnxk_telemetry.h | 26 +++ > drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++++++++++++++++++++++ > drivers/common/cnxk/meson.build | 4 + > drivers/common/cnxk/roc_platform.h | 9 + > 4 files changed, 266 insertions(+) > create mode 100644 drivers/common/cnxk/cnxk_telemetry.h > create mode 100644 drivers/common/cnxk/cnxk_telemetry_npa.c > > diff --git a/drivers/common/cnxk/meson.build b/drivers/common/cnxk/meson.build > index 6a7849f31c..3cc9a2ff37 100644 > --- a/drivers/common/cnxk/meson.build > +++ b/drivers/common/cnxk/meson.build > @@ -60,5 +60,9 @@ sources = files( > # Security common code > sources += files('cnxk_security.c') > > +# Telemetry common code > +sources += files('cnxk_telemetry_npa.c') > + > includes += include_directories('../../bus/pci') > includes += include_directories('../../../lib/net') > +includes += include_directories('../../../lib/telemetry') Rather than giving the include directories, I'd recommend using "deps" variable to specify a direct dependency on those libraries. This should probably be: deps += ['bus_pci', 'net', 'telemetry'] Using these as dependencies means that the header paths will be added automatically, and the libraries linked against too if any functions from those are used by the code in this lib. Regards, /Bruce