Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0

[Bruce Richardson <bruce.richardson@intel.com>]

On Fri, Aug 27, 2021 at 02:30:44PM +0200, Thomas Monjalon wrote:
> 17/08/2021 14:54, Jerin Jacob:
> > On Tue, Aug 17, 2021 at 5:59 PM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > >
> > > On Fri, Jul 30, 2021 at 01:05:48PM +0530, jerinj@marvell.com wrote:
> > > > From: Jerin Jacob <jerinj@marvell.com>
> > > >
> > > > Since meson 0.59.0 version, the extract_all_objects() API
> > > > need to pass explicit boolean value.
> > > >
> > > > To remove the following warning[1], added explicit `true` for
> > > > extract_all_objects() use in codebase whever there is
> > > > no argument.
> > > >
> > > > [1]
> > > > WARNING: extract_all_objects called without setting recursive
> > > > keyword argument. Meson currently defaults to
> > > > non-recursive to maintain backward compatibility but
> > > > the default will be changed in the future.
> > > >
> > >
> > > Technically this is changing the default behaviour since it previously
> > > defaulted to "false". However, since there should be no recursion involved
> > > here anyway, I don't think it matters, correct?
> > 
> > Yes. To be on the safer side, I just put "true" in case some drivers
> > using for a recursive way.
> 
> Bruce, are you OK with the change?
> 
Yes.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>