From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9FFAA0547; Fri, 10 Sep 2021 16:09:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46FA540DFD; Fri, 10 Sep 2021 16:09:37 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 0E0C94067E for ; Fri, 10 Sep 2021 16:09:35 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10102"; a="243404416" X-IronPort-AV: E=Sophos;i="5.85,283,1624345200"; d="scan'208";a="243404416" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2021 07:09:28 -0700 X-IronPort-AV: E=Sophos;i="5.85,283,1624345200"; d="scan'208";a="467123745" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.4.132]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Sep 2021 07:09:26 -0700 Date: Fri, 10 Sep 2021 15:09:23 +0100 From: Bruce Richardson To: Cristian Dumitrescu Cc: dev@dpdk.org Message-ID: References: <20210910123003.85448-1-cristian.dumitrescu@intel.com> <20210910133713.93103-1-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210910133713.93103-1-cristian.dumitrescu@intel.com> Subject: Re: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures to internal header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 10, 2021 at 02:36:50PM +0100, Cristian Dumitrescu wrote: > Start to consolidate the data structures and inline functions required > by the pipeline instructions into an internal header file. > > Signed-off-by: Cristian Dumitrescu > --- > Depends-on: series-18297 ("[V4,1/4] table: add support learner tables") > > lib/pipeline/meson.build | 4 + > lib/pipeline/rte_swx_pipeline.c | 1373 +-------------------- > lib/pipeline/rte_swx_pipeline_internal.h | 1383 ++++++++++++++++++++++ > 3 files changed, 1388 insertions(+), 1372 deletions(-) > create mode 100644 lib/pipeline/rte_swx_pipeline_internal.h > > diff --git a/lib/pipeline/meson.build b/lib/pipeline/meson.build > index 9132bb517a..ec009631bf 100644 > --- a/lib/pipeline/meson.build > +++ b/lib/pipeline/meson.build > @@ -18,3 +18,7 @@ headers = files( > 'rte_swx_ctl.h', > ) > deps += ['port', 'table', 'meter', 'sched', 'cryptodev'] > + > +indirect_headers += files( > + 'rte_swx_pipeline_internal.h', > +) internal headers should not appear in meson.build at all, as they are not for installation. "indirect_headers" is for non-internal, public headers which are not directly included by apps, but included via another public header. For example, rte_ethdev_core.h should not be included directly, but by including rte_ethdev.h which will then pull it in. [The reason these are separated out in meson.build is for header sanity checking, to check that normal, non-indirect public headers include all their dependent headers]