From: Olivier Matz <olivier.matz@6wind.com>
To: Julien Meunier <julien.meunier@nokia.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] stack: fix reload head when pop fails
Date: Fri, 24 Sep 2021 10:57:55 +0200 [thread overview]
Message-ID: <YU2TE6+Qs8KkGD4J@platinum> (raw)
In-Reply-To: <20210921161724.20860-1-julien.meunier@nokia.com>
Hello,
On Tue, Sep 21, 2021 at 06:17:24PM +0200, Julien Meunier wrote:
> The previous commit 18effad9cfa7 ("stack: reload head when pop fails")
> only changed C11 implementation, not generic implementation.
>
> List head must be loaded right before continue (when failed to find the
> new head). Without this, one thread might keep trying and failing to pop
> items without ever loading the new correct head.
>
> Fixes: 3340202f5954 ("stack: add lock-free implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks Julien!
next prev parent reply other threads:[~2021-09-24 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 9:39 [dpdk-dev] [PATCH] stack: reload head when pop fails (generic) Julien Meunier
2021-09-21 16:17 ` [dpdk-dev] [PATCH v2] stack: fix reload head when pop fails Julien Meunier
2021-09-24 8:57 ` Olivier Matz [this message]
2021-09-27 15:47 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU2TE6+Qs8KkGD4J@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=julien.meunier@nokia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).