From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08A39A0548; Fri, 24 Sep 2021 10:57:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E96FC412DE; Fri, 24 Sep 2021 10:57:58 +0200 (CEST) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id 85BAD4122D for ; Fri, 24 Sep 2021 10:57:57 +0200 (CEST) Received: by mail-wr1-f43.google.com with SMTP id u18so25174618wrg.5 for ; Fri, 24 Sep 2021 01:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yH0xBSQEHWkRO15zeozB3/TXW9Q46LEU7b++NnEuO18=; b=T9PKE2mtOWPRyl8n0CmnkrnR7TCtvNN51mttz2h3g4g5JS7LdazunQU80+wNxx6Xzo vulVRclk5FnQua683pThx0Loqk/ZIDmvAVwkAkKMZdJZ0rC1ZxHZq4Vbh+CQzgzyq94d Hvwou2rHyhhseLEyPHC3jqhccpuyQXwcw8OCE6qGfAKBX+NvAPwKvB8tsOxBo5/hRxGs CVg8gje6gCpZMCpJD397VBY0qZaghalwh+EnCO1l6WG5rwI0N6DJuAGGvpvvrHgAbikr KfNxFlddMOOSy5LLss6YbTCLaQEn3MGmuU5R5Mhniqch2SyOUs+pn4DqxbRYWM3+eSVE EXdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yH0xBSQEHWkRO15zeozB3/TXW9Q46LEU7b++NnEuO18=; b=1GBm6FUBlyX0da1/q7odUeNR8oQsFq0Mm+evu+d0H/mCV22dyE4+35R7iwJDdVpWSx qLvwpRl7XrFWpRHM+qPCosEc9OvSOLd7Xsc6KmsalasibbbSWhWqNMTIUzJ0VDFrjy/4 o2g0ECtGu2vHxUbUQfozPdRu6IywNzbTGyhegOQS/IrSxRXtu1+UvBd0wqtj+LyCi00Y wdPFMj8gjLV0ketgYxDt1EARWzcSADVOzLT46BJvSki6dEVyNbLnDcsgCD3xq3CtoWMA r2n7qrpDodtVab7o4qcfLYg2hKv+xKTut71q7txp3N8NHBqrGNtSMD4RmMz0NRJv81hI x8BA== X-Gm-Message-State: AOAM530D2m4p1yqNyRLNJny+szQS/ALZYEro5sFxanvP27qSPJIf+Npj CATWoSRtRYbJU6WiCTEZgEIRCZ4MQlrFKA== X-Google-Smtp-Source: ABdhPJzC5xMokm32254suxRlEuqWK6H4lKiznIs/nsVenDzp3LgfcTW0boETnd4w0ttxiY839JID7w== X-Received: by 2002:a05:6000:180d:: with SMTP id m13mr10012830wrh.383.1632473877122; Fri, 24 Sep 2021 01:57:57 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id n15sm7637470wrg.58.2021.09.24.01.57.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 01:57:56 -0700 (PDT) Date: Fri, 24 Sep 2021 10:57:55 +0200 From: Olivier Matz To: Julien Meunier Cc: dev@dpdk.org, stable@dpdk.org Message-ID: References: <20210819093915.5227-1-julien.meunier@nokia.com> <20210921161724.20860-1-julien.meunier@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210921161724.20860-1-julien.meunier@nokia.com> Subject: Re: [dpdk-dev] [PATCH v2] stack: fix reload head when pop fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On Tue, Sep 21, 2021 at 06:17:24PM +0200, Julien Meunier wrote: > The previous commit 18effad9cfa7 ("stack: reload head when pop fails") > only changed C11 implementation, not generic implementation. > > List head must be loaded right before continue (when failed to find the > new head). Without this, one thread might keep trying and failing to pop > items without ever loading the new correct head. > > Fixes: 3340202f5954 ("stack: add lock-free implementation") > Cc: stable@dpdk.org > > Signed-off-by: Julien Meunier Acked-by: Olivier Matz Thanks Julien!